Browse code

Add process for PR acceptance, review, rejection

This is an extremely tentative PR. However, I feel that the suggestions are generally good.

Docker-DCO-1.1-Signed-off-by: Timothy Hobbs <timothyhobbs@seznam.cz> (github: timthelion)

Timothy Hobbs authored on 2014/08/01 08:47:19
Showing 1 changed files
... ...
@@ -55,7 +55,33 @@ All decisions affecting docker, big and small, follow the same 3 steps:
55 55
 
56 56
 * Step 3: Accept (`LGTM`) or refuse a pull request. The relevant maintainers do 
57 57
 this (see below "Who decides what?")
58
-
58
+ + Accepting pull requests
59
+  - If the pull request appears to be ready to merge, give it a `LGTM`, which
60
+    stands for "Looks Good To Me".
61
+  - If the pull request has some small problems that need to be changed, make
62
+    a comment adressing the issues.
63
+  - If the changes needed to a PR are small, you can add a "LGTM once the
64
+    following comments are adressed..." this will reduce needless back and
65
+    forth.
66
+  - If the PR only needs a few changes before being merged, any MAINTAINER can
67
+    make a replacement PR that incorporates the existing commits and fixes the
68
+    problems before a fast track merge.
69
+ + Closing pull requests
70
+  - If a PR appears to be abandoned, after having attempted to contact the
71
+    original contributor, then a replacement PR may be made.  Once the
72
+    replacement PR is made, any contributor may close the original one.
73
+  - If you are not sure if the pull request implements a good feature or you
74
+    do not understand the purpose of the PR, ask the contributor to provide
75
+    more documentation.  If the contributor is not able to adequately explain
76
+    the purpose of the PR, the PR may be closed by any MAINTAINER.
77
+  - If a MAINTAINER feels that the pull request is sufficiently architecturally
78
+    flawed, or if the pull request needs significantly more design discussion
79
+    before being considered, the MAINTAINER should close the pull request with
80
+    a short explanation of what discussion still needs to be had.  It is
81
+    important not to leave such pull requests open, as this will waste both the
82
+    MAINTAINER's time and the contributor's time.  It is not good to string a
83
+    contributor on for weeks or months, having them make many changes to a PR
84
+    that will eventually be rejected.
59 85
 
60 86
 ## Who decides what?
61 87