Browse code

Fix vet errors about unkeyed fields

Signed-off-by: Alexander Morozov <lk4d4@docker.com>

Alexander Morozov authored on 2014/12/13 03:38:48
Showing 6 changed files
... ...
@@ -234,7 +234,7 @@ func (daemon *Daemon) register(container *Container, updateSuffixarray bool) err
234 234
 		log.Debugf("killing old running container %s", container.ID)
235 235
 
236 236
 		existingPid := container.Pid
237
-		container.SetStopped(&execdriver.ExitStatus{0, false})
237
+		container.SetStopped(&execdriver.ExitStatus{ExitCode: 0})
238 238
 
239 239
 		// We only have to handle this for lxc because the other drivers will ensure that
240 240
 		// no processes are left when docker dies
... ...
@@ -266,7 +266,7 @@ func (daemon *Daemon) register(container *Container, updateSuffixarray bool) err
266 266
 
267 267
 			log.Debugf("Marking as stopped")
268 268
 
269
-			container.SetStopped(&execdriver.ExitStatus{-127, false})
269
+			container.SetStopped(&execdriver.ExitStatus{ExitCode: -127})
270 270
 			if err := container.ToDisk(); err != nil {
271 271
 				return err
272 272
 			}
... ...
@@ -76,11 +76,11 @@ func (d *driver) Run(c *execdriver.Command, pipes *execdriver.Pipes, startCallba
76 76
 	})
77 77
 
78 78
 	if err := d.generateEnvConfig(c); err != nil {
79
-		return execdriver.ExitStatus{-1, false}, err
79
+		return execdriver.ExitStatus{ExitCode: -1}, err
80 80
 	}
81 81
 	configPath, err := d.generateLXCConfig(c)
82 82
 	if err != nil {
83
-		return execdriver.ExitStatus{-1, false}, err
83
+		return execdriver.ExitStatus{ExitCode: -1}, err
84 84
 	}
85 85
 	params := []string{
86 86
 		"lxc-start",
... ...
@@ -154,11 +154,11 @@ func (d *driver) Run(c *execdriver.Command, pipes *execdriver.Pipes, startCallba
154 154
 	c.ProcessConfig.Args = append([]string{name}, arg...)
155 155
 
156 156
 	if err := nodes.CreateDeviceNodes(c.Rootfs, c.AutoCreatedDevices); err != nil {
157
-		return execdriver.ExitStatus{-1, false}, err
157
+		return execdriver.ExitStatus{ExitCode: -1}, err
158 158
 	}
159 159
 
160 160
 	if err := c.ProcessConfig.Start(); err != nil {
161
-		return execdriver.ExitStatus{-1, false}, err
161
+		return execdriver.ExitStatus{ExitCode: -1}, err
162 162
 	}
163 163
 
164 164
 	var (
... ...
@@ -182,7 +182,7 @@ func (d *driver) Run(c *execdriver.Command, pipes *execdriver.Pipes, startCallba
182 182
 			c.ProcessConfig.Process.Kill()
183 183
 			c.ProcessConfig.Wait()
184 184
 		}
185
-		return execdriver.ExitStatus{-1, false}, err
185
+		return execdriver.ExitStatus{ExitCode: -1}, err
186 186
 	}
187 187
 
188 188
 	c.ContainerPid = pid
... ...
@@ -193,7 +193,7 @@ func (d *driver) Run(c *execdriver.Command, pipes *execdriver.Pipes, startCallba
193 193
 
194 194
 	<-waitLock
195 195
 
196
-	return execdriver.ExitStatus{getExitCode(c), false}, waitErr
196
+	return execdriver.ExitStatus{ExitCode: getExitCode(c)}, waitErr
197 197
 }
198 198
 
199 199
 /// Return the exit code of the process
... ...
@@ -74,7 +74,7 @@ func (d *driver) Run(c *execdriver.Command, pipes *execdriver.Pipes, startCallba
74 74
 	// take the Command and populate the libcontainer.Config from it
75 75
 	container, err := d.createContainer(c)
76 76
 	if err != nil {
77
-		return execdriver.ExitStatus{-1, false}, err
77
+		return execdriver.ExitStatus{ExitCode: -1}, err
78 78
 	}
79 79
 
80 80
 	var term execdriver.Terminal
... ...
@@ -85,7 +85,7 @@ func (d *driver) Run(c *execdriver.Command, pipes *execdriver.Pipes, startCallba
85 85
 		term, err = execdriver.NewStdConsole(&c.ProcessConfig, pipes)
86 86
 	}
87 87
 	if err != nil {
88
-		return execdriver.ExitStatus{-1, false}, err
88
+		return execdriver.ExitStatus{ExitCode: -1}, err
89 89
 	}
90 90
 	c.ProcessConfig.Terminal = term
91 91
 
... ...
@@ -102,12 +102,12 @@ func (d *driver) Run(c *execdriver.Command, pipes *execdriver.Pipes, startCallba
102 102
 	)
103 103
 
104 104
 	if err := d.createContainerRoot(c.ID); err != nil {
105
-		return execdriver.ExitStatus{-1, false}, err
105
+		return execdriver.ExitStatus{ExitCode: -1}, err
106 106
 	}
107 107
 	defer d.cleanContainer(c.ID)
108 108
 
109 109
 	if err := d.writeContainerFile(container, c.ID); err != nil {
110
-		return execdriver.ExitStatus{-1, false}, err
110
+		return execdriver.ExitStatus{ExitCode: -1}, err
111 111
 	}
112 112
 
113 113
 	execOutputChan := make(chan execOutput, 1)
... ...
@@ -146,7 +146,7 @@ func (d *driver) Run(c *execdriver.Command, pipes *execdriver.Pipes, startCallba
146 146
 
147 147
 	select {
148 148
 	case execOutput := <-execOutputChan:
149
-		return execdriver.ExitStatus{execOutput.exitCode, false}, execOutput.err
149
+		return execdriver.ExitStatus{ExitCode: execOutput.exitCode}, execOutput.err
150 150
 	case <-waitForStart:
151 151
 		break
152 152
 	}
... ...
@@ -161,7 +161,7 @@ func (d *driver) Run(c *execdriver.Command, pipes *execdriver.Pipes, startCallba
161 161
 	// wait for the container to exit.
162 162
 	execOutput := <-execOutputChan
163 163
 
164
-	return execdriver.ExitStatus{execOutput.exitCode, oomKill}, execOutput.err
164
+	return execdriver.ExitStatus{ExitCode: execOutput.exitCode, OOMKilled: oomKill}, execOutput.err
165 165
 }
166 166
 
167 167
 func (d *driver) Kill(p *execdriver.Command, sig int) error {
... ...
@@ -49,7 +49,7 @@ func TestStateRunStop(t *testing.T) {
49 49
 			atomic.StoreInt64(&exit, int64(exitCode))
50 50
 			close(stopped)
51 51
 		}()
52
-		s.SetStopped(&execdriver.ExitStatus{i, false})
52
+		s.SetStopped(&execdriver.ExitStatus{ExitCode: i})
53 53
 		if s.IsRunning() {
54 54
 			t.Fatal("State is running")
55 55
 		}
... ...
@@ -653,7 +653,7 @@ func TestRestore(t *testing.T) {
653 653
 	if err := container3.Run(); err != nil {
654 654
 		t.Fatal(err)
655 655
 	}
656
-	container2.SetStopped(&execdriver.ExitStatus{0, false})
656
+	container2.SetStopped(&execdriver.ExitStatus{ExitCode: 0})
657 657
 }
658 658
 
659 659
 func TestDefaultContainerName(t *testing.T) {
... ...
@@ -16,7 +16,7 @@ import (
16 16
 	"github.com/docker/docker/pkg/reexec"
17 17
 )
18 18
 
19
-var chrootArchiver = &archive.Archiver{Untar}
19
+var chrootArchiver = &archive.Archiver{Untar: Untar}
20 20
 
21 21
 func chroot(path string) error {
22 22
 	if err := syscall.Chroot(path); err != nil {