Browse code
Skip TestStatsAllNewContainersAdded on remote daemons
This test is often failing on remote daemons. We tried many approaches
to fix it but none worked. In order to make the CI more reliable, this
will skip the test when running against a remote daemon (e.g. win2lin).
Signed-off-by: Tibor Vass <tibor@docker.com>
Tibor Vass authored on 2016/03/01 23:50:02Showing 1 changed files
| ... | ... |
@@ -97,7 +97,10 @@ func (s *DockerSuite) TestStatsAllNoStream(c *check.C) {
|
| 97 | 97 |
|
| 98 | 98 |
func (s *DockerSuite) TestStatsAllNewContainersAdded(c *check.C) {
|
| 99 | 99 |
// Windows does not support stats |
| 100 |
- testRequires(c, DaemonIsLinux) |
|
| 100 |
+ // TODO: remove SameHostDaemon |
|
| 101 |
+ // The reason it was added is because, there seems to be some race that makes this test fail |
|
| 102 |
+ // for remote daemons (namely in the win2lin CI). We highly welcome contributions to fix this. |
|
| 103 |
+ testRequires(c, DaemonIsLinux, SameHostDaemon) |
|
| 101 | 104 |
|
| 102 | 105 |
id := make(chan string) |
| 103 | 106 |
addedChan := make(chan struct{})
|