Browse code

Merge pull request #28500 from rhvgoyal/remove-unused-param

devmapper: get rid of unused device id argument in unregisterDevice()

Vincent Demeester authored on 2017/01/13 02:02:00
Showing 1 changed files
... ...
@@ -477,11 +477,10 @@ func (devices *DeviceSet) loadDeviceFilesOnStart() error {
477 477
 }
478 478
 
479 479
 // Should be called with devices.Lock() held.
480
-func (devices *DeviceSet) unregisterDevice(id int, hash string) error {
481
-	logrus.Debugf("devmapper: unregisterDevice(%v, %v)", id, hash)
480
+func (devices *DeviceSet) unregisterDevice(hash string) error {
481
+	logrus.Debugf("devmapper: unregisterDevice(%v)", hash)
482 482
 	info := &devInfo{
483
-		Hash:     hash,
484
-		DeviceID: id,
483
+		Hash: hash,
485 484
 	}
486 485
 
487 486
 	delete(devices.Devices, hash)
... ...
@@ -829,7 +828,7 @@ func (devices *DeviceSet) createRegisterDevice(hash string) (*devInfo, error) {
829 829
 	}
830 830
 
831 831
 	if err := devices.closeTransaction(); err != nil {
832
-		devices.unregisterDevice(deviceID, hash)
832
+		devices.unregisterDevice(hash)
833 833
 		devicemapper.DeleteDevice(devices.getPoolDevName(), deviceID)
834 834
 		devices.markDeviceIDFree(deviceID)
835 835
 		return nil, err
... ...
@@ -929,7 +928,7 @@ func (devices *DeviceSet) createRegisterSnapDevice(hash string, baseInfo *devInf
929 929
 	}
930 930
 
931 931
 	if err := devices.closeTransaction(); err != nil {
932
-		devices.unregisterDevice(deviceID, hash)
932
+		devices.unregisterDevice(hash)
933 933
 		devicemapper.DeleteDevice(devices.getPoolDevName(), deviceID)
934 934
 		devices.markDeviceIDFree(deviceID)
935 935
 		return err
... ...
@@ -2004,7 +2003,7 @@ func (devices *DeviceSet) deleteTransaction(info *devInfo, syncDelete bool) erro
2004 2004
 	}
2005 2005
 
2006 2006
 	if err == nil {
2007
-		if err := devices.unregisterDevice(info.DeviceID, info.Hash); err != nil {
2007
+		if err := devices.unregisterDevice(info.Hash); err != nil {
2008 2008
 			return err
2009 2009
 		}
2010 2010
 		// If device was already in deferred delete state that means