Browse code

integration-cli: clarify multi-stage tests names

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

Tonis Tiigi authored on 2017/12/21 04:55:27
Showing 1 changed files
... ...
@@ -4860,7 +4860,7 @@ func (s *DockerSuite) TestBuildBuildTimeArgDefinitionWithNoEnvInjection(c *check
4860 4860
 	}
4861 4861
 }
4862 4862
 
4863
-func (s *DockerSuite) TestBuildBuildTimeArgMultipleFrom(c *check.C) {
4863
+func (s *DockerSuite) TestBuildMultiStageArg(c *check.C) {
4864 4864
 	imgName := "multifrombldargtest"
4865 4865
 	dockerfile := `FROM busybox
4866 4866
     ARG foo=abc
... ...
@@ -4884,7 +4884,7 @@ func (s *DockerSuite) TestBuildBuildTimeArgMultipleFrom(c *check.C) {
4884 4884
 	c.Assert(result.Stdout(), checker.Contains, "bar=def")
4885 4885
 }
4886 4886
 
4887
-func (s *DockerSuite) TestBuildBuildTimeFromArgMultipleFrom(c *check.C) {
4887
+func (s *DockerSuite) TestBuildMultiStageGlobalArg(c *check.C) {
4888 4888
 	imgName := "multifrombldargtest"
4889 4889
 	dockerfile := `ARG tag=nosuchtag
4890 4890
      FROM busybox:${tag}
... ...
@@ -4909,7 +4909,7 @@ func (s *DockerSuite) TestBuildBuildTimeFromArgMultipleFrom(c *check.C) {
4909 4909
 	c.Assert(result.Stdout(), checker.Contains, "tag=latest")
4910 4910
 }
4911 4911
 
4912
-func (s *DockerSuite) TestBuildBuildTimeUnusedArgMultipleFrom(c *check.C) {
4912
+func (s *DockerSuite) TestBuildMultiStageUnusedArg(c *check.C) {
4913 4913
 	imgName := "multifromunusedarg"
4914 4914
 	dockerfile := `FROM busybox
4915 4915
     ARG foo
... ...
@@ -5727,7 +5727,7 @@ func (s *DockerSuite) TestBuildCacheFrom(c *check.C) {
5727 5727
 	c.Assert(layers1[len(layers1)-1], checker.Not(checker.Equals), layers2[len(layers1)-1])
5728 5728
 }
5729 5729
 
5730
-func (s *DockerSuite) TestBuildCacheMultipleFrom(c *check.C) {
5730
+func (s *DockerSuite) TestBuildMultiStageCache(c *check.C) {
5731 5731
 	testRequires(c, DaemonIsLinux) // All tests that do save are skipped in windows
5732 5732
 	dockerfile := `
5733 5733
 		FROM busybox
... ...
@@ -5888,7 +5888,7 @@ func (s *DockerSuite) TestBuildContChar(c *check.C) {
5888 5888
 	c.Assert(result.Combined(), checker.Contains, "Step 2/2 : RUN echo hi \\\\\n")
5889 5889
 }
5890 5890
 
5891
-func (s *DockerSuite) TestBuildCopyFromPreviousRootFS(c *check.C) {
5891
+func (s *DockerSuite) TestBuildMultiStageCopyFromSyntax(c *check.C) {
5892 5892
 	dockerfile := `
5893 5893
 		FROM busybox AS first
5894 5894
 		COPY foo bar
... ...
@@ -5946,7 +5946,7 @@ func (s *DockerSuite) TestBuildCopyFromPreviousRootFS(c *check.C) {
5946 5946
 	cli.DockerCmd(c, "run", "build4", "cat", "baz").Assert(c, icmd.Expected{Out: "pqr"})
5947 5947
 }
5948 5948
 
5949
-func (s *DockerSuite) TestBuildCopyFromPreviousRootFSErrors(c *check.C) {
5949
+func (s *DockerSuite) TestBuildMultiStageCopyFromErrors(c *check.C) {
5950 5950
 	testCases := []struct {
5951 5951
 		dockerfile    string
5952 5952
 		expectedError string
... ...
@@ -5993,7 +5993,7 @@ func (s *DockerSuite) TestBuildCopyFromPreviousRootFSErrors(c *check.C) {
5993 5993
 	}
5994 5994
 }
5995 5995
 
5996
-func (s *DockerSuite) TestBuildCopyFromPreviousFrom(c *check.C) {
5996
+func (s *DockerSuite) TestBuildMultiStageMultipleBuilds(c *check.C) {
5997 5997
 	dockerfile := `
5998 5998
 		FROM busybox
5999 5999
 		COPY foo bar`
... ...
@@ -6026,7 +6026,7 @@ func (s *DockerSuite) TestBuildCopyFromPreviousFrom(c *check.C) {
6026 6026
 	c.Assert(strings.TrimSpace(out), check.Equals, "def")
6027 6027
 }
6028 6028
 
6029
-func (s *DockerSuite) TestBuildCopyFromImplicitFrom(c *check.C) {
6029
+func (s *DockerSuite) TestBuildMultiStageImplicitFrom(c *check.C) {
6030 6030
 	dockerfile := `
6031 6031
 		FROM busybox
6032 6032
 		COPY --from=busybox /etc/passwd /mypasswd
... ...
@@ -6053,7 +6053,7 @@ func (s *DockerSuite) TestBuildCopyFromImplicitFrom(c *check.C) {
6053 6053
 	}
6054 6054
 }
6055 6055
 
6056
-func (s *DockerRegistrySuite) TestBuildCopyFromImplicitPullingFrom(c *check.C) {
6056
+func (s *DockerRegistrySuite) TestBuildMultiStageImplicitPull(c *check.C) {
6057 6057
 	repoName := fmt.Sprintf("%v/dockercli/testf", privateRegistryURL)
6058 6058
 
6059 6059
 	dockerfile := `
... ...
@@ -6083,7 +6083,7 @@ func (s *DockerRegistrySuite) TestBuildCopyFromImplicitPullingFrom(c *check.C) {
6083 6083
 	cli.Docker(cli.Args("run", "build1", "cat", "baz")).Assert(c, icmd.Expected{Out: "abc"})
6084 6084
 }
6085 6085
 
6086
-func (s *DockerSuite) TestBuildFromPreviousBlock(c *check.C) {
6086
+func (s *DockerSuite) TestBuildMultiStageNameVariants(c *check.C) {
6087 6087
 	dockerfile := `
6088 6088
 		FROM busybox as foo
6089 6089
 		COPY foo /
... ...
@@ -6094,7 +6094,7 @@ func (s *DockerSuite) TestBuildFromPreviousBlock(c *check.C) {
6094 6094
 		FROM foo
6095 6095
 		COPY --from=foo1 foo f1
6096 6096
 		COPY --from=FOo2 foo f2
6097
-		` // foo2 case also tests that names are canse insensitive
6097
+		` // foo2 case also tests that names are case insensitive
6098 6098
 	ctx := fakecontext.New(c, "",
6099 6099
 		fakecontext.WithDockerfile(dockerfile),
6100 6100
 		fakecontext.WithFiles(map[string]string{
... ...
@@ -6108,7 +6108,7 @@ func (s *DockerSuite) TestBuildFromPreviousBlock(c *check.C) {
6108 6108
 	cli.Docker(cli.Args("run", "build1", "cat", "f2")).Assert(c, icmd.Expected{Out: "bar2"})
6109 6109
 }
6110 6110
 
6111
-func (s *DockerTrustSuite) TestCopyFromTrustedBuild(c *check.C) {
6111
+func (s *DockerTrustSuite) TestBuildMultiStageTrusted(c *check.C) {
6112 6112
 	img1 := s.setupTrustedImage(c, "trusted-build1")
6113 6113
 	img2 := s.setupTrustedImage(c, "trusted-build2")
6114 6114
 	dockerFile := fmt.Sprintf(`
... ...
@@ -6130,7 +6130,7 @@ func (s *DockerTrustSuite) TestCopyFromTrustedBuild(c *check.C) {
6130 6130
 	dockerCmdWithResult("run", name, "cat", "bar").Assert(c, icmd.Expected{Out: "ok"})
6131 6131
 }
6132 6132
 
6133
-func (s *DockerSuite) TestBuildCopyFromPreviousFromWindows(c *check.C) {
6133
+func (s *DockerSuite) TestBuildMultiStageMultipleBuildsWindows(c *check.C) {
6134 6134
 	testRequires(c, DaemonIsWindows)
6135 6135
 	dockerfile := `
6136 6136
 		FROM ` + testEnv.MinimalBaseImage() + `
... ...
@@ -6218,7 +6218,7 @@ func (s *DockerSuite) TestBuildCopyFromWindowsIsCaseInsensitive(c *check.C) {
6218 6218
 }
6219 6219
 
6220 6220
 // #33176
6221
-func (s *DockerSuite) TestBuildCopyFromResetScratch(c *check.C) {
6221
+func (s *DockerSuite) TestBuildMulitStageResetScratch(c *check.C) {
6222 6222
 	testRequires(c, DaemonIsLinux)
6223 6223
 
6224 6224
 	dockerfile := `