GitList

Browse code

don't call sort for every add in history

This moves the call to sort in daemon/history to a function to be
called explicitly when we're done adding elements to the list.

This speeds up `docker ps`.

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> (github: unclejack)

unclejack authored on 2014/05/14 20:17:58
Showing 2 changed files

daemon/daemon.go index 38a107b..33ddb87 100644
daemon/history.go index 57a00a2..0b125ad 100644

daemon/daemon.go

History View file @ e963179

@@ -85,6 +85,7 @@ func (daemon *Daemon) List() []*Container {
 	for e := daemon.containers.Front(); e != nil; e = e.Next() {
 		containers.Add(e.Value.(*Container))
 	}
+	containers.Sort()
 	return *containers
 }
 

daemon/history.go

History View file @ e963179

@@ -26,5 +26,8 @@ func (history *History) Swap(i, j int) {
                      func (history *History) Add(container *Container) {
                      	*history = append(*history, container)
                     +}
+                    +
                     +func (history *History) Sort() {
                      	sort.Sort(history)
+                     }

...	...	@@ -85,6 +85,7 @@ func (daemon Daemon) List() []Container {
85	85	for e := daemon.containers.Front(); e != nil; e = e.Next() {
86	86	containers.Add(e.Value.(*Container))
87	87	}
	88	+ containers.Sort()
88	89	return *containers
89	90	}
90	91