Browse code

revert apparmor changes back to how it was in 1.7.1, but keep tests

Signed-off-by: Jessica Frazelle <acidburn@docker.com>

Jessica Frazelle authored on 2015/08/06 12:08:00
Showing 14 changed files
... ...
@@ -4,7 +4,7 @@
4 4
 
5 5
 FROM debian:jessie
6 6
 
7
-RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-apparmor dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
7
+RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
8 8
 
9 9
 ENV GO_VERSION 1.4.2
10 10
 RUN curl -fSL "https://storage.googleapis.com/golang/go${GO_VERSION}.linux-amd64.tar.gz" | tar xzC /usr/local
... ...
@@ -4,7 +4,7 @@
4 4
 
5 5
 FROM debian:stretch
6 6
 
7
-RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-apparmor dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
7
+RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
8 8
 
9 9
 ENV GO_VERSION 1.4.2
10 10
 RUN curl -fSL "https://storage.googleapis.com/golang/go${GO_VERSION}.linux-amd64.tar.gz" | tar xzC /usr/local
... ...
@@ -5,7 +5,7 @@
5 5
 FROM debian:wheezy
6 6
 RUN echo deb http://http.debian.net/debian wheezy-backports main > /etc/apt/sources.list.d/wheezy-backports.list
7 7
 
8
-RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-apparmor dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
8
+RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
9 9
 
10 10
 ENV GO_VERSION 1.4.2
11 11
 RUN curl -fSL "https://storage.googleapis.com/golang/go${GO_VERSION}.linux-amd64.tar.gz" | tar xzC /usr/local
... ...
@@ -50,7 +50,6 @@ for version in "${versions[@]}"; do
50 50
 		build-essential # "essential for building Debian packages"
51 51
 		curl ca-certificates # for downloading Go
52 52
 		debhelper # for easy ".deb" building
53
-		dh-apparmor # for apparmor debhelper
54 53
 		dh-systemd # for systemd debhelper integration
55 54
 		git # for "git commit" info in "docker -v"
56 55
 		libapparmor-dev # for "sys/apparmor.h"
... ...
@@ -4,7 +4,7 @@
4 4
 
5 5
 FROM ubuntu-debootstrap:precise
6 6
 
7
-RUN apt-get update && apt-get install -y bash-completion  build-essential curl ca-certificates debhelper dh-apparmor  git libapparmor-dev  libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
7
+RUN apt-get update && apt-get install -y bash-completion  build-essential curl ca-certificates debhelper  git libapparmor-dev  libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
8 8
 
9 9
 ENV GO_VERSION 1.4.2
10 10
 RUN curl -fSL "https://storage.googleapis.com/golang/go${GO_VERSION}.linux-amd64.tar.gz" | tar xzC /usr/local
... ...
@@ -4,7 +4,7 @@
4 4
 
5 5
 FROM ubuntu-debootstrap:trusty
6 6
 
7
-RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-apparmor dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
7
+RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
8 8
 
9 9
 ENV GO_VERSION 1.4.2
10 10
 RUN curl -fSL "https://storage.googleapis.com/golang/go${GO_VERSION}.linux-amd64.tar.gz" | tar xzC /usr/local
... ...
@@ -4,7 +4,7 @@
4 4
 
5 5
 FROM ubuntu-debootstrap:vivid
6 6
 
7
-RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-apparmor dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
7
+RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
8 8
 
9 9
 ENV GO_VERSION 1.4.2
10 10
 RUN curl -fSL "https://storage.googleapis.com/golang/go${GO_VERSION}.linux-amd64.tar.gz" | tar xzC /usr/local
... ...
@@ -4,7 +4,7 @@
4 4
 
5 5
 FROM ubuntu-debootstrap:wily
6 6
 
7
-RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-apparmor dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
7
+RUN apt-get update && apt-get install -y bash-completion btrfs-tools build-essential curl ca-certificates debhelper dh-systemd git libapparmor-dev libdevmapper-dev libsqlite3-dev --no-install-recommends && rm -rf /var/lib/apt/lists/*
8 8
 
9 9
 ENV GO_VERSION 1.4.2
10 10
 RUN curl -fSL "https://storage.googleapis.com/golang/go${GO_VERSION}.linux-amd64.tar.gz" | tar xzC /usr/local
... ...
@@ -40,20 +40,16 @@ profile {{.Name}} flags=(attach_disconnected,mediate_deleted) {
40 40
   file,
41 41
   umount,
42 42
 
43
-  signal (receive) peer=/usr/bin/docker,
44
-  signal (receive) peer=docker-unconfined,
45
-
46 43
   deny @{PROC}/sys/fs/** wklx,
47 44
   deny @{PROC}/fs/** wklx,
48 45
   deny @{PROC}/sysrq-trigger rwklx,
49 46
   deny @{PROC}/mem rwklx,
50 47
   deny @{PROC}/kmem rwklx,
51
-  deny @{PROC}/kore rwklx,
48
+  deny @{PROC}/kcore rwklx,
52 49
   deny @{PROC}/sys/kernel/[^s][^h][^m]* wklx,
53 50
   deny @{PROC}/sys/kernel/*/** wklx,
54 51
 
55 52
   deny mount,
56
-  deny ptrace (trace) peer=docker-default,
57 53
 
58 54
   deny /sys/[^f]*/** wklx,
59 55
   deny /sys/f[^s]*/** wklx,
... ...
@@ -198,9 +198,8 @@ func (d *Driver) setPrivileged(container *configs.Config) (err error) {
198 198
 	container.Devices = hostDevices
199 199
 
200 200
 	if apparmor.IsEnabled() {
201
-		container.AppArmorProfile = "docker-unconfined"
201
+		container.AppArmorProfile = "unconfined"
202 202
 	}
203
-
204 203
 	return nil
205 204
 }
206 205
 
... ...
@@ -9,4 +9,3 @@ contrib/init/systemd/docker.socket lib/systemd/system/
9 9
 contrib/mk* usr/share/docker-engine/contrib/
10 10
 contrib/nuke-graph-directory.sh usr/share/docker-engine/contrib/
11 11
 contrib/syntax/nano/Dockerfile.nanorc usr/share/nano/
12
-contrib/apparmor/* etc/apparmor.d/
... ...
@@ -32,9 +32,5 @@ override_dh_installudev:
32 32
 	# match our existing priority
33 33
 	dh_installudev --priority=z80
34 34
 
35
-override_dh_install:
36
-	dh_install
37
-	dh_apparmor --profile-name=docker-engine -pdocker-engine
38
-
39 35
 %:
40 36
 	dh $@ --with=bash-completion $(shell command -v dh_systemd_enable > /dev/null 2>&1 && echo --with=systemd)
... ...
@@ -35,8 +35,6 @@ if [ -z "$DOCKER_TEST_HOST" ]; then
35 35
 		(
36 36
 			set -x
37 37
 			/etc/init.d/apparmor start
38
-
39
-			/sbin/apparmor_parser -r -W -T contrib/apparmor/
40 38
 		)
41 39
 	fi
42 40
 
... ...
@@ -72,12 +72,6 @@ bundle_ubuntu() {
72 72
 		done
73 73
 	done
74 74
 
75
-	# Include contributed apparmor policy
76
-	if [ -d contrib/apparmor ]; then
77
-		mkdir -p "$DIR/etc/apparmor.d/"
78
-		cp contrib/apparmor/* "$DIR/etc/apparmor.d/"
79
-	fi
80
-
81 75
 	# Copy the binary
82 76
 	# This will fail if the binary bundle hasn't been built
83 77
 	mkdir -p "$DIR/usr/bin"
... ...
@@ -95,10 +89,6 @@ if [ "$1" = 'configure' ] && [ -z "$2" ]; then
95 95
 	fi
96 96
 fi
97 97
 
98
-if ( aa-status --enabled ); then
99
-	/sbin/apparmor_parser -r -W -T /etc/apparmor.d/docker-engine
100
-fi
101
-
102 98
 if ! { [ -x /sbin/initctl ] && /sbin/initctl version 2>/dev/null | grep -q upstart; }; then
103 99
 	# we only need to do this if upstart isn't in charge
104 100
 	update-rc.d docker defaults > /dev/null || true