Browse code

devmapper: Move base device creation in separate function

This moves base device creation function in a separate function. Pure
code reorganization. Makes reading code little easier.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>

Vivek Goyal authored on 2015/10/06 21:38:03
Showing 1 changed files
... ...
@@ -777,6 +777,38 @@ func (devices *DeviceSet) saveBaseDeviceUUID(baseInfo *devInfo) error {
777 777
 	return nil
778 778
 }
779 779
 
780
+func (devices *DeviceSet) createBaseImage() error {
781
+	logrus.Debugf("Initializing base device-mapper thin volume")
782
+
783
+	// Create initial device
784
+	info, err := devices.createRegisterDevice("")
785
+	if err != nil {
786
+		return err
787
+	}
788
+
789
+	logrus.Debugf("Creating filesystem on base device-mapper thin volume")
790
+
791
+	if err := devices.activateDeviceIfNeeded(info); err != nil {
792
+		return err
793
+	}
794
+
795
+	if err := devices.createFilesystem(info); err != nil {
796
+		return err
797
+	}
798
+
799
+	info.Initialized = true
800
+	if err := devices.saveMetadata(info); err != nil {
801
+		info.Initialized = false
802
+		return err
803
+	}
804
+
805
+	if err := devices.saveBaseDeviceUUID(info); err != nil {
806
+		return fmt.Errorf("Could not query and save base device UUID:%v", err)
807
+	}
808
+
809
+	return nil
810
+}
811
+
780 812
 func (devices *DeviceSet) setupBaseImage() error {
781 813
 	oldInfo, _ := devices.lookupDeviceWithLock("")
782 814
 	if oldInfo != nil && oldInfo.Initialized {
... ...
@@ -817,34 +849,11 @@ func (devices *DeviceSet) setupBaseImage() error {
817 817
 		}
818 818
 	}
819 819
 
820
-	logrus.Debugf("Initializing base device-mapper thin volume")
821
-
822
-	// Create initial device
823
-	info, err := devices.createRegisterDevice("")
824
-	if err != nil {
825
-		return err
826
-	}
827
-
828
-	logrus.Debugf("Creating filesystem on base device-mapper thin volume")
829
-
830
-	if err := devices.activateDeviceIfNeeded(info); err != nil {
831
-		return err
832
-	}
833
-
834
-	if err := devices.createFilesystem(info); err != nil {
835
-		return err
836
-	}
837
-
838
-	info.Initialized = true
839
-	if err := devices.saveMetadata(info); err != nil {
840
-		info.Initialized = false
820
+	// Create new base image device
821
+	if err := devices.createBaseImage(); err != nil {
841 822
 		return err
842 823
 	}
843 824
 
844
-	if err := devices.saveBaseDeviceUUID(info); err != nil {
845
-		return fmt.Errorf("Could not query and save base device UUID:%v", err)
846
-	}
847
-
848 825
 	return nil
849 826
 }
850 827