Browse code

fix tests

Signed-off-by: Victor Vieux <vieux@docker.com>

Victor Vieux authored on 2014/11/26 02:07:04
Showing 1 changed files
... ...
@@ -285,10 +285,10 @@ func TestEventsImageImport(t *testing.T) {
285 285
 }
286 286
 
287 287
 func TestEventsFilters(t *testing.T) {
288
-	now := time.Now().Unix()
288
+	since := time.Now().Unix()
289 289
 	cmd(t, "run", "--rm", "busybox", "true")
290 290
 	cmd(t, "run", "--rm", "busybox", "true")
291
-	eventsCmd := exec.Command(dockerBinary, "events", fmt.Sprintf("--since=%d", now), fmt.Sprintf("--until=%d", time.Now().Unix()), "--filter", "event=die")
291
+	eventsCmd := exec.Command(dockerBinary, "events", fmt.Sprintf("--since=%d", since), fmt.Sprintf("--until=%d", time.Now().Unix()), "--filter", "event=die")
292 292
 	out, exitCode, err := runCommandWithOutput(eventsCmd)
293 293
 	if exitCode != 0 || err != nil {
294 294
 		t.Fatalf("Failed to get events with exit code %d: %s", exitCode, err)
... ...
@@ -296,8 +296,7 @@ func TestEventsFilters(t *testing.T) {
296 296
 	events := strings.Split(out, "\n")
297 297
 	events = events[:len(events)-1]
298 298
 	if len(events) != 2 {
299
-		fmt.Printf("%v\n", events)
300
-		t.Fatalf("Unexpected event")
299
+		t.Fatalf("Expected 2 events, got %d: %v", len(events), events)
301 300
 	}
302 301
 	dieEvent := strings.Fields(events[len(events)-1])
303 302
 	if dieEvent[len(dieEvent)-1] != "die" {
... ...
@@ -309,7 +308,7 @@ func TestEventsFilters(t *testing.T) {
309 309
 		t.Fatalf("event should be die, not %#v", dieEvent)
310 310
 	}
311 311
 
312
-	eventsCmd = exec.Command(dockerBinary, "events", "--since=0", fmt.Sprintf("--until=%d", time.Now().Unix()), "--filter", "event=die", "--filter", "event=start")
312
+	eventsCmd = exec.Command(dockerBinary, "events", fmt.Sprintf("--since=%d", since), fmt.Sprintf("--until=%d", time.Now().Unix()), "--filter", "event=die", "--filter", "event=start")
313 313
 	out, exitCode, err = runCommandWithOutput(eventsCmd)
314 314
 	if exitCode != 0 || err != nil {
315 315
 		t.Fatalf("Failed to get events with exit code %d: %s", exitCode, err)
... ...
@@ -317,7 +316,7 @@ func TestEventsFilters(t *testing.T) {
317 317
 	events = strings.Split(out, "\n")
318 318
 	events = events[:len(events)-1]
319 319
 	if len(events) != 4 {
320
-		t.Fatalf("Unexpected event")
320
+		t.Fatalf("Expected 4 events, got %d: %v", len(events), events)
321 321
 	}
322 322
 	startEvent := strings.Fields(events[len(events)-4])
323 323
 	if startEvent[len(startEvent)-1] != "start" {