GitList

Browse code

daemon: daemon.containerAttach: remove redundant defers

Both these defers were defined in the closure, and would be executed
at the end of the goroutine; inline them to prevent them being confused
for being executed after the function starting the goroutine.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2025/03/23 20:18:46
Showing 1 changed files

daemon/attach.go

History View file @ f785379

@@ -173,9 +173,9 @@ func (daemon *Daemon) containerAttach(ctr *container.Container, cfg *stream.Atta
                      	if cfg.Stdin != nil {
                      		r, w := io.Pipe()
                      		go func(stdin io.ReadCloser) {
                     -			defer w.Close()
                     -			defer log.G(context.TODO()).Debug("Closing buffered stdin pipe")
                      			io.Copy(w, stdin)
                     +			log.G(context.TODO()).Debug("Closing buffered stdin pipe")
                     +			w.Close()
                      		}(cfg.Stdin)
                      		cfg.Stdin = r
+                     	}