Browse code

Remove cluster storage advertise from reload.

Because libnetwork won't really send container information to the new
storage anyways.

Signed-off-by: David Calavera <david.calavera@gmail.com>

David Calavera authored on 2016/01/27 05:44:51
Showing 3 changed files
... ...
@@ -1512,13 +1512,12 @@ func (daemon *Daemon) initDiscovery(config *Config) error {
1512 1512
 // daemon according to those changes.
1513 1513
 // This are the settings that Reload changes:
1514 1514
 // - Daemon labels.
1515
-// - Cluster discovery (reconfigure and restart).
1516 1515
 func (daemon *Daemon) Reload(config *Config) error {
1517 1516
 	daemon.configStore.reloadLock.Lock()
1518
-	defer daemon.configStore.reloadLock.Unlock()
1519
-
1520 1517
 	daemon.configStore.Labels = config.Labels
1521
-	return daemon.reloadClusterDiscovery(config)
1518
+	daemon.configStore.reloadLock.Unlock()
1519
+
1520
+	return nil
1522 1521
 }
1523 1522
 
1524 1523
 func (daemon *Daemon) reloadClusterDiscovery(config *Config) error {
... ...
@@ -437,7 +437,7 @@ func TestDaemonDiscoveryReload(t *testing.T) {
437 437
 		&discovery.Entry{Host: "127.0.0.1", Port: "5555"},
438 438
 	}
439 439
 
440
-	if err := daemon.Reload(newConfig); err != nil {
440
+	if err := daemon.reloadClusterDiscovery(newConfig); err != nil {
441 441
 		t.Fatal(err)
442 442
 	}
443 443
 	ch, errCh = daemon.discoveryWatcher.Watch(stopCh)
... ...
@@ -469,7 +469,7 @@ func TestDaemonDiscoveryReloadFromEmptyDiscovery(t *testing.T) {
469 469
 		&discovery.Entry{Host: "127.0.0.1", Port: "5555"},
470 470
 	}
471 471
 
472
-	if err := daemon.Reload(newConfig); err != nil {
472
+	if err := daemon.reloadClusterDiscovery(newConfig); err != nil {
473 473
 		t.Fatal(err)
474 474
 	}
475 475
 	stopCh := make(chan struct{})
... ...
@@ -875,7 +875,4 @@ if there are conflicts, but it won't stop execution.
875 875
 The list of currently supported options that can be reconfigured is this:
876 876
 
877 877
 - `debug`: it changes the daemon to debug mode when set to true.
878
-- `label`: it replaces the daemon labels with a new set of labels.
879
-- `cluster-store`: it reloads the discovery store with the new address.
880
-- `cluster-store-opts`: it uses the new options to reload the discovery store.
881
-- `cluster-advertise`: it modifies the address advertised after reloading.
878
+- `labels`: it replaces the daemon labels with a new set of labels.