Browse code

Fix logrus formatting This fix tries to fix logrus formatting by removing `f` from `logrus.[Error|Warn|Debug|Fatal|Panic|Info]f` when formatting string is not present.

Fixed issue #23459

Signed-off-by: Daehyeok Mun <daehyeok@gmail.com>

Daehyeok Mun authored on 2016/11/01 13:05:01
Showing 9 changed files
... ...
@@ -169,7 +169,7 @@ func New(config Config) (*Cluster, error) {
169 169
 
170 170
 	select {
171 171
 	case <-time.After(swarmConnectTimeout):
172
-		logrus.Errorf("swarm component could not be started before timeout was reached")
172
+		logrus.Error("swarm component could not be started before timeout was reached")
173 173
 	case <-n.Ready():
174 174
 	case <-n.done:
175 175
 		return nil, fmt.Errorf("swarm component could not be started: %v", c.err)
... ...
@@ -190,7 +190,7 @@ func (daemon *Daemon) restore() error {
190 190
 		go func(c *container.Container) {
191 191
 			defer wg.Done()
192 192
 			if err := backportMountSpec(c); err != nil {
193
-				logrus.Errorf("Failed to migrate old mounts to use new spec format")
193
+				logrus.Error("Failed to migrate old mounts to use new spec format")
194 194
 			}
195 195
 
196 196
 			if c.IsRunning() || c.IsPaused() {
... ...
@@ -636,7 +636,7 @@ func (daemon *Daemon) initNetworkController(config *Config, activeSandboxes map[
636 636
 	}
637 637
 
638 638
 	if len(activeSandboxes) > 0 {
639
-		logrus.Infof("There are old running containers, the network config will not take affect")
639
+		logrus.Info("There are old running containers, the network config will not take affect")
640 640
 		return controller, nil
641 641
 	}
642 642
 
... ...
@@ -344,7 +344,7 @@ func (a *Driver) Remove(id string) error {
344 344
 	tmpMntPath := path.Join(a.mntPath(), fmt.Sprintf("%s-removing", id))
345 345
 	if err := os.Rename(mountpoint, tmpMntPath); err != nil && !os.IsNotExist(err) {
346 346
 		if err == syscall.EBUSY {
347
-			logrus.Warnf("os.Rename err due to EBUSY")
347
+			logrus.Warn("os.Rename err due to EBUSY")
348 348
 			out, debugErr := debugEBusy(mountpoint)
349 349
 			if debugErr == nil {
350 350
 				logrus.Warnf("debugEBusy returned %v", out)
... ...
@@ -410,8 +410,8 @@ func (devices *DeviceSet) lookupDeviceWithLock(hash string) (*devInfo, error) {
410 410
 // This function relies on that device hash map has been loaded in advance.
411 411
 // Should be called with devices.Lock() held.
412 412
 func (devices *DeviceSet) constructDeviceIDMap() {
413
-	logrus.Debugf("devmapper: constructDeviceIDMap()")
414
-	defer logrus.Debugf("devmapper: constructDeviceIDMap() END")
413
+	logrus.Debug("devmapper: constructDeviceIDMap()")
414
+	defer logrus.Debug("devmapper: constructDeviceIDMap() END")
415 415
 
416 416
 	for _, info := range devices.Devices {
417 417
 		devices.markDeviceIDUsed(info.DeviceID)
... ...
@@ -459,8 +459,8 @@ func (devices *DeviceSet) deviceFileWalkFunction(path string, finfo os.FileInfo)
459 459
 }
460 460
 
461 461
 func (devices *DeviceSet) loadDeviceFilesOnStart() error {
462
-	logrus.Debugf("devmapper: loadDeviceFilesOnStart()")
463
-	defer logrus.Debugf("devmapper: loadDeviceFilesOnStart() END")
462
+	logrus.Debug("devmapper: loadDeviceFilesOnStart()")
463
+	defer logrus.Debug("devmapper: loadDeviceFilesOnStart() END")
464 464
 
465 465
 	var scan = func(path string, info os.FileInfo, err error) error {
466 466
 		if err != nil {
... ...
@@ -1713,9 +1713,9 @@ func (devices *DeviceSet) initDevmapper(doInit bool) error {
1713 1713
 	// https://github.com/docker/docker/issues/4036
1714 1714
 	if supported := devicemapper.UdevSetSyncSupport(true); !supported {
1715 1715
 		if dockerversion.IAmStatic == "true" {
1716
-			logrus.Errorf("devmapper: Udev sync is not supported. This will lead to data loss and unexpected behavior. Install a dynamic binary to use devicemapper or select a different storage driver. For more information, see https://docs.docker.com/engine/reference/commandline/daemon/#daemon-storage-driver-option")
1716
+			logrus.Error("devmapper: Udev sync is not supported. This will lead to data loss and unexpected behavior. Install a dynamic binary to use devicemapper or select a different storage driver. For more information, see https://docs.docker.com/engine/reference/commandline/daemon/#daemon-storage-driver-option")
1717 1717
 		} else {
1718
-			logrus.Errorf("devmapper: Udev sync is not supported. This will lead to data loss and unexpected behavior. Install a more recent version of libdevmapper or select a different storage driver. For more information, see https://docs.docker.com/engine/reference/commandline/daemon/#daemon-storage-driver-option")
1718
+			logrus.Error("devmapper: Udev sync is not supported. This will lead to data loss and unexpected behavior. Install a more recent version of libdevmapper or select a different storage driver. For more information, see https://docs.docker.com/engine/reference/commandline/daemon/#daemon-storage-driver-option")
1719 1719
 		}
1720 1720
 
1721 1721
 		if !devices.overrideUdevSyncCheck {
... ...
@@ -125,7 +125,7 @@ func Init(home string, options []string, uidMaps, gidMaps []idtools.IDMap) (grap
125 125
 		if !opts.overrideKernelCheck {
126 126
 			return nil, graphdriver.ErrNotSupported
127 127
 		}
128
-		logrus.Warnf("Using pre-4.0.0 kernel for overlay2, mount failures may require kernel update")
128
+		logrus.Warn("Using pre-4.0.0 kernel for overlay2, mount failures may require kernel update")
129 129
 	}
130 130
 
131 131
 	fsMagic, err := graphdriver.GetFSMagic(home)
... ...
@@ -73,7 +73,7 @@ func (s *Discovery) Initialize(uris string, heartbeat time.Duration, ttl time.Du
73 73
 
74 74
 	var config *store.Config
75 75
 	if clusterOpts["kv.cacertfile"] != "" && clusterOpts["kv.certfile"] != "" && clusterOpts["kv.keyfile"] != "" {
76
-		logrus.Infof("Initializing discovery with TLS")
76
+		logrus.Info("Initializing discovery with TLS")
77 77
 		tlsConfig, err := tlsconfig.Client(tlsconfig.Options{
78 78
 			CAFile:   clusterOpts["kv.cacertfile"],
79 79
 			CertFile: clusterOpts["kv.certfile"],
... ...
@@ -93,7 +93,7 @@ func (s *Discovery) Initialize(uris string, heartbeat time.Duration, ttl time.Du
93 93
 			TLS: tlsConfig,
94 94
 		}
95 95
 	} else {
96
-		logrus.Infof("Initializing discovery without TLS")
96
+		logrus.Info("Initializing discovery without TLS")
97 97
 	}
98 98
 
99 99
 	// Creates a new store, will ignore options given
... ...
@@ -62,7 +62,7 @@ func (pm *Manager) Pull(name string, metaHeader http.Header, authConfig *types.A
62 62
 	name = ref.String()
63 63
 
64 64
 	if p, _ := pm.pluginStore.GetByName(name); p != nil {
65
-		logrus.Debugf("plugin already exists")
65
+		logrus.Debug("plugin already exists")
66 66
 		return nil, fmt.Errorf("%s exists", name)
67 67
 	}
68 68
 
... ...
@@ -113,7 +113,7 @@ func Pull(ref reference.Named, rs registry.Service, metaheader http.Header, auth
113 113
 			return nil, err
114 114
 		}
115 115
 		if !confirmedV2 {
116
-			logrus.Debugf("pull.go: !confirmedV2")
116
+			logrus.Debug("pull.go: !confirmedV2")
117 117
 			return nil, ErrUnsupportedRegistry
118 118
 		}
119 119
 		logrus.Debugf("Trying to pull %s from %s %s", repoInfo.Name(), endpoint.URL, endpoint.Version)