Browse code

Add a few small consistency tweaks in hack

Tianon Gravi authored on 2013/10/18 14:36:28
Showing 4 changed files
... ...
@@ -40,7 +40,6 @@ To build docker, you will need the following system dependencies
40 40
 * A clean checkout of the source must be added to a valid Go [workspace](http://golang.org/doc/code.html#Workspaces)
41 41
 under the path *src/github.com/dotcloud/docker*. See 
42 42
 
43
-
44 43
 ## Go dependencies
45 44
 
46 45
 All Go dependencies are vendored under ./vendor. They are used by the official build,
... ...
@@ -55,7 +54,6 @@ NOTE: if you''re not able to package the exact version (to the exact commit) of
55 55
 please get in touch so we can remediate! Who knows what discrepancies can be caused by even the
56 56
 slightest deviation. We promise to do our best to make everybody happy.
57 57
 
58
-
59 58
 ## Disabling CGO
60 59
 
61 60
 Make sure to disable CGO on your system, and then recompile the standard library on the build
... ...
@@ -71,7 +69,7 @@ cd /tmp && echo 'package main' > t.go && go test -a -i -v
71 71
 To build the docker binary, run the following command with the source checkout as the
72 72
 working directory:
73 73
 
74
-```
74
+```bash
75 75
 ./hack/make.sh binary
76 76
 ```
77 77
 
... ...
@@ -82,7 +80,7 @@ You are encouraged to use ./hack/make.sh without modification. If you must absol
82 82
 your own script (are you really, really sure you need to? make.sh is really not that complicated),
83 83
 then please take care the respect the following:
84 84
 
85
-* In *./hack/make.sh*: $LDFLAGS, $VERSION and $GITCOMMIT
85
+* In *./hack/make.sh*: $LDFLAGS, $BUILDFLAGS, $VERSION and $GITCOMMIT
86 86
 * In *./hack/make/binary*: the exact build command to run
87 87
 
88 88
 You may be tempted to tweak these settings. In particular, being a rigorous maintainer, you may want
... ...
@@ -106,7 +104,6 @@ dependencies to be installed (see below).
106 106
 
107 107
 The test suite will also download a small test container, so you will need internet connectivity.
108 108
 
109
-
110 109
 ## Runtime dependencies
111 110
 
112 111
 To run properly, docker needs the following software to be installed at runtime:
... ...
@@ -133,6 +130,6 @@ for your distro''s process supervisor of choice.
133 133
 
134 134
 Docker should be run as root, with the following arguments:
135 135
 
136
-```
136
+```bash
137 137
 docker -d
138 138
 ```
... ...
@@ -48,7 +48,6 @@ fi
48 48
 LDFLAGS='-X main.GITCOMMIT "'$GITCOMMIT'" -X main.VERSION "'$VERSION'" -w -linkmode external -extldflags "-lpthread -static -Wl,--unresolved-symbols=ignore-in-object-files"'
49 49
 BUILDFLAGS='-tags netgo'
50 50
 
51
-
52 51
 bundle() {
53 52
 	bundlescript=$1
54 53
 	bundle=$(basename $bundlescript)
... ...
@@ -1,3 +1,5 @@
1
+#!/bin/sh
2
+
1 3
 DEST=$1
2 4
 
3 5
 set -e
... ...
@@ -3,8 +3,7 @@
3 3
 DEST=$1
4 4
 
5 5
 PKGVERSION="$VERSION"
6
-if test -n "$(git status --porcelain)"
7
-then
6
+if [ -n "$(git status --porcelain)" ]; then
8 7
 	PKGVERSION="$PKGVERSION-$(date +%Y%m%d%H%M%S)-$GITCOMMIT"
9 8
 fi
10 9