Browse code

integration-cli: fix minimum and default api version test

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

Antonio Murdaca authored on 2016/02/04 21:47:15
Showing 1 changed files
... ...
@@ -1,6 +1,7 @@
1 1
 package main
2 2
 
3 3
 import (
4
+	"fmt"
4 5
 	"net/http"
5 6
 	"net/http/httptest"
6 7
 	"net/http/httputil"
... ...
@@ -59,7 +60,8 @@ func (s *DockerSuite) TestApiClientVersionNewerThanServer(c *check.C) {
59 59
 	status, body, err := sockRequest("GET", "/v"+version+"/version", nil)
60 60
 	c.Assert(err, checker.IsNil)
61 61
 	c.Assert(status, checker.Equals, http.StatusBadRequest)
62
-	c.Assert(len(string(body)), check.Not(checker.Equals), 0) // Expected not empty body
62
+	expected := fmt.Sprintf("client is newer than server (client API version: %s, server API version: %s)", version, api.DefaultVersion)
63
+	c.Assert(strings.TrimSpace(string(body)), checker.Equals, expected)
63 64
 }
64 65
 
65 66
 func (s *DockerSuite) TestApiClientVersionOldNotSupported(c *check.C) {
... ...
@@ -73,7 +75,8 @@ func (s *DockerSuite) TestApiClientVersionOldNotSupported(c *check.C) {
73 73
 	status, body, err := sockRequest("GET", "/v"+version+"/version", nil)
74 74
 	c.Assert(err, checker.IsNil)
75 75
 	c.Assert(status, checker.Equals, http.StatusBadRequest)
76
-	c.Assert(len(string(body)), checker.Not(check.Equals), 0) // Expected not empty body
76
+	expected := fmt.Sprintf("client version %s is too old. Minimum supported API version is %s, please upgrade your client to a newer version", version, api.MinVersion)
77
+	c.Assert(strings.TrimSpace(string(body)), checker.Equals, expected)
77 78
 }
78 79
 
79 80
 func (s *DockerSuite) TestApiDockerApiVersion(c *check.C) {