1. docker
  2. Commit ff97ff8320a8c057578b00e4a50888b2fd009201
Browse code

daemon/logger/loggerutils: remove redundant capturing of loop vars (copyloopvar)

daemon/logger/loggerutils/logfile.go:809:3: The copy of the 'for' variable "ra" can be deleted (Go 1.22+) (copyloopvar)
ra := ra
^
daemon/logger/loggerutils/sharedtemp_test.go:117:4: The copy of the 'for' variable "i" can be deleted (Go 1.22+) (copyloopvar)
i := i
^
daemon/logger/loggerutils/sharedtemp_test.go:179:4: The copy of the 'for' variable "i" can be deleted (Go 1.22+) (copyloopvar)
i := i
^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2024/11/12 21:41:21
Showing 2 changed files
daemon/logger/loggerutils/logfile.go
History View file @ ff97ff8
... ... 
@@ -806,7 +806,6 @@ func tailFiles(ctx context.Context, files []fileOpener, watcher *logger.LogWatch
806 806 
 	}()
807 807
808 808 
 	for _, ra := range readers {
809 
-		ra := ra
810 809 
 		select {
811 810 
 		case <-watcher.WatchConsumerGone():
812 811 
 			return false
daemon/logger/loggerutils/sharedtemp_test.go
History View file @ ff97ff8
... ... 
@@ -114,7 +114,6 @@ func TestSharedTempFileConverter(t *testing.T) {
114 114 
 		var wg sync.WaitGroup
115 115 
 		wg.Add(3)
116 116 
 		for i := 0; i < 3; i++ {
117 
-			i := i
118 117 
 			go func() {
119 118 
 				defer wg.Done()
120 119 
 				t.Logf("goroutine %v: enter", i)
... ... 
@@ -176,7 +175,6 @@ func TestSharedTempFileConverter(t *testing.T) {
176 176 
 		var done sync.WaitGroup
177 177 
 		done.Add(3)
178 178 
 		for i := 0; i < 3; i++ {
179 
-			i := i
180 179 
 			go func() {
181 180 
 				defer done.Done()
182 181 
 				t.Logf("goroutine %v: enter", i)