Browse code

Merge commit '9cacdabd1c8cd257a942d8289349c37d992989b7'

* commit '9cacdabd1c8cd257a942d8289349c37d992989b7':
jpegls: cosmetics: Drop some unnecessary parentheses
mpegvideo: Remove commented-out PARANOID debug cruft

Conflicts:
libavcodec/jpegls.c
libavcodec/mpegvideo.c
libavcodec/x86/mpegvideo.c

Merged-by: Michael Niedermayer <michaelni@gmx.at>

Michael Niedermayer authored on 2013/05/16 16:19:11
Showing 5 changed files
... ...
@@ -31,16 +31,16 @@ void ff_jpegls_init_state(JLSState *state){
31 31
     int i;
32 32
 
33 33
     state->twonear = state->near * 2 + 1;
34
-    state->range = ((state->maxval + state->twonear - 1) / state->twonear) + 1;
34
+    state->range   = (state->maxval + state->twonear - 1) / state->twonear + 1;
35 35
 
36 36
     // QBPP = ceil(log2(RANGE))
37 37
     for(state->qbpp = 0; (1 << state->qbpp) < state->range; state->qbpp++);
38 38
 
39
-    state->bpp = FFMAX(av_log2(state->maxval)+1, 2);
39
+    state->bpp   = FFMAX(av_log2(state->maxval) + 1, 2);
40 40
     state->limit = 2*(state->bpp + FFMAX(state->bpp, 8)) - state->qbpp;
41 41
 
42 42
     for(i = 0; i < 367; i++) {
43
-        state->A[i] = FFMAX((state->range + 32) >> 6, 2);
43
+        state->A[i] = FFMAX(state->range + 32 >> 6, 2);
44 44
         state->N[i] = 1;
45 45
     }
46 46
 
... ...
@@ -63,7 +63,7 @@ void ff_jpegls_reset_coding_parameters(JLSState *s, int reset_all){
63 63
     if(s->maxval==0 || reset_all) s->maxval= (1 << s->bpp) - 1;
64 64
 
65 65
     if(s->maxval >=128){
66
-        factor= (FFMIN(s->maxval, 4095) + 128)>>8;
66
+        factor = FFMIN(s->maxval, 4095) + 128 >> 8;
67 67
 
68 68
         if(s->T1==0     || reset_all)
69 69
             s->T1= iso_clip(factor*(basic_t1-2) + 2 + 3*s->near, s->near+1, s->maxval);
... ...
@@ -98,7 +98,7 @@ static inline int ls_get_code_regular(GetBitContext *gb, JLSState *state, int Q)
98 98
 
99 99
     /* decode mapped error */
100 100
     if(ret & 1)
101
-        ret = -((ret + 1) >> 1);
101
+        ret = -(ret + 1 >> 1);
102 102
     else
103 103
         ret >>= 1;
104 104
 
... ...
@@ -136,7 +136,7 @@ static inline int ls_get_code_runterm(GetBitContext *gb, JLSState *state, int RI
136 136
     ret += RItype + map;
137 137
 
138 138
     if(ret & 1){
139
-        ret = map - ((ret + 1) >> 1);
139
+        ret = map - (ret + 1 >> 1);
140 140
         state->B[Q]++;
141 141
     } else {
142 142
         ret = ret >> 1;
... ...
@@ -186,7 +186,7 @@ static inline void ls_decode_line(JLSState *state, MJpegDecodeContext *s, void *
186 186
                     x += stride;
187 187
                 }
188 188
                 /* if EOL reached, we stop decoding */
189
-                if(r != (1 << ff_log2_run[state->run_index[comp]]))
189
+                if (r != 1 << ff_log2_run[state->run_index[comp]])
190 190
                     return;
191 191
                 if(state->run_index[comp] < 31)
192 192
                     state->run_index[comp]++;
... ...
@@ -49,7 +49,7 @@ static inline void ls_encode_regular(JLSState *state, PutBitContext *pb, int Q,
49 49
 
50 50
     if(err < 0)
51 51
         err += state->range;
52
-    if(err >= ((state->range + 1) >> 1)) {
52
+    if (err >= (state->range + 1 >> 1)) {
53 53
         err -= state->range;
54 54
         val = 2 * FFABS(err) - 1 - map;
55 55
     } else
... ...
@@ -145,7 +145,7 @@ static inline void ls_encode_line(JLSState *state, PutBitContext *pb, void *last
145 145
             if(x >= w)
146 146
                 return;
147 147
             Rb = R(last, x);
148
-            RItype = (FFABS(Ra - Rb) <= state->near);
148
+            RItype = FFABS(Ra - Rb) <= state->near;
149 149
             pred = RItype ? Ra : Rb;
150 150
             err = R(cur, x) - pred;
151 151
 
... ...
@@ -166,7 +166,7 @@ static inline void ls_encode_line(JLSState *state, PutBitContext *pb, void *last
166 166
             }
167 167
             if(err < 0)
168 168
                 err += state->range;
169
-            if(err >= ((state->range + 1) >> 1))
169
+            if (err >= state->range + 1 >> 1)
170 170
                 err -= state->range;
171 171
 
172 172
             ls_encode_runterm(state, pb, RItype, err, ff_log2_run[state->run_index[comp]]);
... ...
@@ -60,7 +60,6 @@ static void dct_unquantize_h263_intra_c(MpegEncContext *s,
60 60
 static void dct_unquantize_h263_inter_c(MpegEncContext *s,
61 61
                                   int16_t *block, int n, int qscale);
62 62
 
63
-
64 63
 //#define DEBUG
65 64
 
66 65
 
... ...
@@ -164,28 +164,6 @@ __asm__ volatile(
164 164
         );
165 165
 }
166 166
 
167
-
168
-/*
169
-  We can suppose that result of two multiplications can't be greater than 0xFFFF
170
-  i.e. is 16-bit, so we use here only PMULLW instruction and can avoid
171
-  a complex multiplication.
172
-=====================================================
173
- Full formula for multiplication of 2 integer numbers
174
- which are represent as high:low words:
175
- input: value1 = high1:low1
176
-        value2 = high2:low2
177
- output: value3 = value1*value2
178
- value3=high3:low3 (on overflow: modulus 2^32 wrap-around)
179
- this mean that for 0x123456 * 0x123456 correct result is 0x766cb0ce4
180
- but this algorithm will compute only 0x66cb0ce4
181
- this limited by 16-bit size of operands
182
- ---------------------------------
183
- tlow1 = high1*low2
184
- tlow2 = high2*low1
185
- tlow1 = tlow1 + tlow2
186
- high3:low3 = low1*low2
187
- high3 += tlow1
188
-*/
189 167
 static void dct_unquantize_mpeg1_intra_mmx(MpegEncContext *s,
190 168
                                      int16_t *block, int n, int qscale)
191 169
 {