Browse code

ffserver: deprecate Port and BindAddress options in favor of HTTPPort and HTTPBindAddress

The new option names are more explicit.

Signed-off-by: Reynaldo H. Verdejo Pinochet <reynaldo@osg.samsung.com>

Stefano Sabatini authored on 2014/08/02 23:40:53
Showing 3 changed files
... ...
@@ -1,11 +1,11 @@
1 1
 # Port on which the server is listening. You must select a different
2 2
 # port from your standard HTTP web server if it is running on the same
3 3
 # computer.
4
-Port 8090
4
+HTTPPort 8090
5 5
 
6 6
 # Address on which the server is bound. Only useful if you have
7 7
 # several network interfaces.
8
-BindAddress 0.0.0.0
8
+HTTPBindAddress 0.0.0.0
9 9
 
10 10
 # Number of simultaneous HTTP connections that can be handled. It has
11 11
 # to be defined *before* the MaxClients parameter, since it defines the
... ...
@@ -66,7 +66,7 @@ http://@var{ffserver_ip_address}:@var{http_port}/@var{feed_name}
66 66
 
67 67
 where @var{ffserver_ip_address} is the IP address of the machine where
68 68
 @command{ffserver} is installed, @var{http_port} is the port number of
69
-the HTTP server (configured through the @option{Port} option), and
69
+the HTTP server (configured through the @option{HTTPPort} option), and
70 70
 @var{feed_name} is the name of the corresponding feed defined in the
71 71
 configuration file.
72 72
 
... ...
@@ -101,7 +101,7 @@ http://@var{ffserver_ip_address}:@var{rtsp_port}/@var{stream_name}[@var{options}
101 101
 the configuration file. @var{options} is a list of options specified
102 102
 after the URL which affects how the stream is served by
103 103
 @command{ffserver}. @var{http_port} and @var{rtsp_port} are the HTTP
104
-and RTSP ports configured with the options @var{Port} and
104
+and RTSP ports configured with the options @var{HTTPPort} and
105 105
 @var{RTSPPort} respectively.
106 106
 
107 107
 In case the stream is associated to a feed, the encoding parameters
... ...
@@ -352,20 +352,29 @@ allow everybody else.
352 352
 
353 353
 @section Global options
354 354
 @table @option
355
+@item HTTPPort @var{port_number}
355 356
 @item Port @var{port_number}
356 357
 @item RTSPPort @var{port_number}
357 358
 
358
-Set TCP port number on which the HTTP/RTSP server is listening. You
359
-must select a different port from your standard HTTP web server if it
360
-is running on the same computer.
359
+@var{HTTPPort} sets the HTTP server listening TCP port number,
360
+@var{RTSPPort} sets the RTSP server listening TCP port number.
361
+
362
+@var{Port} is the equivalent of @var{HTTPPort} and is deprecated.
363
+
364
+You must select a different port from your standard HTTP web server if
365
+it is running on the same computer.
361 366
 
362 367
 If not specified, no corresponding server will be created.
363 368
 
369
+@item HTTPBindAddress @var{ip_address}
364 370
 @item BindAddress @var{ip_address}
365 371
 @item RTSPBindAddress @var{ip_address}
366 372
 Set address on which the HTTP/RTSP server is bound. Only useful if you
367 373
 have several network interfaces.
368 374
 
375
+@var{BindAddress} is the equivalent of @var{HTTPBindAddress} and is
376
+deprecated.
377
+
369 378
 @item MaxHTTPConnections @var{n}
370 379
 Set number of simultaneous HTTP connections that can be handled. It
371 380
 has to be defined @emph{before} the @option{MaxClients} parameter,
... ...
@@ -4081,14 +4081,18 @@ static int parse_ffconfig(const char *filename)
4081 4081
 
4082 4082
         get_arg(cmd, sizeof(cmd), &p);
4083 4083
 
4084
-        if (!av_strcasecmp(cmd, "Port")) {
4084
+        if (!av_strcasecmp(cmd, "Port") || !av_strcasecmp(cmd, "HTTPPort")) {
4085
+            if (!av_strcasecmp(cmd, "Port"))
4086
+                WARNING("Port option is deprecated, use HTTPPort instead\n");
4085 4087
             get_arg(arg, sizeof(arg), &p);
4086 4088
             val = atoi(arg);
4087 4089
             if (val < 1 || val > 65536) {
4088
-                ERROR("Invalid_port: %s\n", arg);
4090
+                ERROR("Invalid port: %s\n", arg);
4089 4091
             }
4090 4092
             my_http_addr.sin_port = htons(val);
4091
-        } else if (!av_strcasecmp(cmd, "BindAddress")) {
4093
+        } else if (!av_strcasecmp(cmd, "HTTPBindAddress") || !av_strcasecmp(cmd, "BindAddress")) {
4094
+            if (!av_strcasecmp(cmd, "BindAddress"))
4095
+                WARNING("BindAddress option is deprecated, use HTTPBindAddress instead\n");
4092 4096
             get_arg(arg, sizeof(arg), &p);
4093 4097
             if (resolve_host(&my_http_addr.sin_addr, arg) != 0) {
4094 4098
                 ERROR("%s:%d: Invalid host/IP address: %s\n", arg);