1. ffmpeg
  2. Commit 17d5c21b3d1249672323bd1ab09718e29ce77e91
Browse code

avcodec/sonic: Fix integer overflow in predictor_calc_error()

Fixes: signed integer overflow: 5 * -1094995529 cannot be represented in type 'int'
Fixes: 18346/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5709623893426176

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit c8c17b8cef77dc052e8845e5fd86daf2983fd7dd)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

Michael Niedermayer authored on 2019/10/22 06:41:49
Showing 1 changed files
libavcodec/sonic.c
History View file @ 17d5c21
... ... 
@@ -473,7 +473,7 @@ static int predictor_calc_error(int *k, int *state, int order, int error)
473 473 
     {
474 474 
         int k_value = *k_ptr, state_value = *state_ptr;
475 475 
         x -= shift_down(k_value * state_value, LATTICE_SHIFT);
476 
-        state_ptr[1] = state_value + shift_down(k_value * x, LATTICE_SHIFT);
476 
+        state_ptr[1] = state_value + shift_down(k_value * (unsigned)x, LATTICE_SHIFT);
477 477 
     }
478 478 
 #else
479 479 
     for (i = order-2; i >= 0; i--)