Browse code

lavfi/drawutils: attempt to fix subsampling.

Clément Bœsch authored on 2013/05/11 07:31:09
Showing 1 changed files
... ...
@@ -93,7 +93,7 @@ int ff_fill_line_with_color(uint8_t *line[4], int pixel_step[4], int w, uint8_t
93 93
             int hsub1 = (plane == 1 || plane == 2) ? hsub : 0;
94 94
 
95 95
             pixel_step[plane] = 1;
96
-            line_size = (w >> hsub1) * pixel_step[plane];
96
+            line_size = FF_CEIL_RSHIFT(w, hsub1) * pixel_step[plane];
97 97
             line[plane] = av_malloc(line_size);
98 98
             memset(line[plane], dst_color[plane], line_size);
99 99
         }
... ...
@@ -112,11 +112,13 @@ void ff_draw_rectangle(uint8_t *dst[4], int dst_linesize[4],
112 112
     for (plane = 0; plane < 4 && dst[plane]; plane++) {
113 113
         int hsub1 = plane == 1 || plane == 2 ? hsub : 0;
114 114
         int vsub1 = plane == 1 || plane == 2 ? vsub : 0;
115
+        int width  = FF_CEIL_RSHIFT(w, hsub1);
116
+        int height = FF_CEIL_RSHIFT(h, vsub1);
115 117
 
116 118
         p = dst[plane] + (y >> vsub1) * dst_linesize[plane];
117
-        for (i = 0; i < (h >> vsub1); i++) {
119
+        for (i = 0; i < height; i++) {
118 120
             memcpy(p + (x >> hsub1) * pixelstep[plane],
119
-                   src[plane], (w >> hsub1) * pixelstep[plane]);
121
+                   src[plane], width * pixelstep[plane]);
120 122
             p += dst_linesize[plane];
121 123
         }
122 124
     }
... ...
@@ -132,11 +134,13 @@ void ff_copy_rectangle(uint8_t *dst[4], int dst_linesize[4],
132 132
     for (plane = 0; plane < 4 && dst[plane]; plane++) {
133 133
         int hsub1 = plane == 1 || plane == 2 ? hsub : 0;
134 134
         int vsub1 = plane == 1 || plane == 2 ? vsub : 0;
135
+        int width  = FF_CEIL_RSHIFT(w, hsub1);
136
+        int height = FF_CEIL_RSHIFT(h, vsub1);
135 137
 
136 138
         p = dst[plane] + (y >> vsub1) * dst_linesize[plane];
137
-        for (i = 0; i < (h >> vsub1); i++) {
139
+        for (i = 0; i < height; i++) {
138 140
             memcpy(p + (x >> hsub1) * pixelstep[plane],
139
-                   src[plane] + src_linesize[plane]*(i+(y2>>vsub1)), (w >> hsub1) * pixelstep[plane]);
141
+                   src[plane] + src_linesize[plane]*(i+(y2>>vsub1)), width * pixelstep[plane]);
140 142
             p += dst_linesize[plane];
141 143
         }
142 144
     }
... ...
@@ -233,8 +237,8 @@ void ff_copy_rectangle2(FFDrawContext *draw,
233 233
     for (plane = 0; plane < draw->nb_planes; plane++) {
234 234
         p = pointer_at(draw, src, src_linesize, plane, src_x, src_y);
235 235
         q = pointer_at(draw, dst, dst_linesize, plane, dst_x, dst_y);
236
-        wp = (w >> draw->hsub[plane]) * draw->pixelstep[plane];
237
-        hp = (h >> draw->vsub[plane]);
236
+        wp = FF_CEIL_RSHIFT(w, draw->hsub[plane]) * draw->pixelstep[plane];
237
+        hp = FF_CEIL_RSHIFT(h, draw->vsub[plane]);
238 238
         for (y = 0; y < hp; y++) {
239 239
             memcpy(q, p, wp);
240 240
             p += src_linesize[plane];
... ...
@@ -252,8 +256,8 @@ void ff_fill_rectangle(FFDrawContext *draw, FFDrawColor *color,
252 252
 
253 253
     for (plane = 0; plane < draw->nb_planes; plane++) {
254 254
         p0 = pointer_at(draw, dst, dst_linesize, plane, dst_x, dst_y);
255
-        wp = (w >> draw->hsub[plane]);
256
-        hp = (h >> draw->vsub[plane]);
255
+        wp = FF_CEIL_RSHIFT(w, draw->hsub[plane]);
256
+        hp = FF_CEIL_RSHIFT(h, draw->vsub[plane]);
257 257
         if (!hp)
258 258
             return;
259 259
         p = p0;