Browse code

ffmpeg_opt: reduce diff to libav in opt_target() by 16 lines

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit 7a67ab5cba8ed5509be5d058fe9e5612ef39d3b0)

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>

Michael Niedermayer authored on 2014/08/27 20:13:51
Showing 1 changed files
... ...
@@ -2153,19 +2153,19 @@ static int opt_target(void *optctx, const char *opt, const char *arg)
2153 2153
 
2154 2154
         parse_option(o, "s", norm == PAL ? "352x288" : "352x240", options);
2155 2155
         parse_option(o, "r", frame_rates[norm], options);
2156
-        av_dict_set(&o->g->codec_opts, "g", norm == PAL ? "15" : "18", AV_DICT_DONT_OVERWRITE);
2156
+        opt_default(NULL, "g", norm == PAL ? "15" : "18");
2157 2157
 
2158
-        av_dict_set(&o->g->codec_opts, "b:v", "1150000", AV_DICT_DONT_OVERWRITE);
2159
-        av_dict_set(&o->g->codec_opts, "maxrate", "1150000", AV_DICT_DONT_OVERWRITE);
2160
-        av_dict_set(&o->g->codec_opts, "minrate", "1150000", AV_DICT_DONT_OVERWRITE);
2161
-        av_dict_set(&o->g->codec_opts, "bufsize", "327680", AV_DICT_DONT_OVERWRITE); // 40*1024*8;
2158
+        opt_default(NULL, "b:v", "1150000");
2159
+        opt_default(NULL, "maxrate", "1150000");
2160
+        opt_default(NULL, "minrate", "1150000");
2161
+        opt_default(NULL, "bufsize", "327680"); // 40*1024*8;
2162 2162
 
2163
-        av_dict_set(&o->g->codec_opts, "b:a", "224000", AV_DICT_DONT_OVERWRITE);
2163
+        opt_default(NULL, "b:a", "224000");
2164 2164
         parse_option(o, "ar", "44100", options);
2165 2165
         parse_option(o, "ac", "2", options);
2166 2166
 
2167
-        av_dict_set(&o->g->format_opts, "packetsize", "2324", AV_DICT_DONT_OVERWRITE);
2168
-        av_dict_set(&o->g->format_opts, "muxrate", "1411200", AV_DICT_DONT_OVERWRITE); // 2352 * 75 * 8;
2167
+        opt_default(NULL, "packetsize", "2324");
2168
+        opt_default(NULL, "muxrate", "1411200"); // 2352 * 75 * 8;
2169 2169
 
2170 2170
         /* We have to offset the PTS, so that it is consistent with the SCR.
2171 2171
            SCR starts at 36000, but the first two packs contain only padding
... ...
@@ -2182,18 +2182,18 @@ static int opt_target(void *optctx, const char *opt, const char *arg)
2182 2182
         parse_option(o, "s", norm == PAL ? "480x576" : "480x480", options);
2183 2183
         parse_option(o, "r", frame_rates[norm], options);
2184 2184
         parse_option(o, "pix_fmt", "yuv420p", options);
2185
-        av_dict_set(&o->g->codec_opts, "g", norm == PAL ? "15" : "18", AV_DICT_DONT_OVERWRITE);
2185
+        opt_default(NULL, "g", norm == PAL ? "15" : "18");
2186 2186
 
2187
-        av_dict_set(&o->g->codec_opts, "b:v", "2040000", AV_DICT_DONT_OVERWRITE);
2188
-        av_dict_set(&o->g->codec_opts, "maxrate", "2516000", AV_DICT_DONT_OVERWRITE);
2189
-        av_dict_set(&o->g->codec_opts, "minrate", "0", AV_DICT_DONT_OVERWRITE); // 1145000;
2190
-        av_dict_set(&o->g->codec_opts, "bufsize", "1835008", AV_DICT_DONT_OVERWRITE); // 224*1024*8;
2191
-        av_dict_set(&o->g->codec_opts, "scan_offset", "1", AV_DICT_DONT_OVERWRITE);
2187
+        opt_default(NULL, "b:v", "2040000");
2188
+        opt_default(NULL, "maxrate", "2516000");
2189
+        opt_default(NULL, "minrate", "0"); // 1145000;
2190
+        opt_default(NULL, "bufsize", "1835008"); // 224*1024*8;
2191
+        opt_default(NULL, "scan_offset", "1");
2192 2192
 
2193
-        av_dict_set(&o->g->codec_opts, "b:a", "224000", AV_DICT_DONT_OVERWRITE);
2193
+        opt_default(NULL, "b:a", "224000");
2194 2194
         parse_option(o, "ar", "44100", options);
2195 2195
 
2196
-        av_dict_set(&o->g->format_opts, "packetsize", "2324", AV_DICT_DONT_OVERWRITE);
2196
+        opt_default(NULL, "packetsize", "2324");
2197 2197
 
2198 2198
     } else if (!strcmp(arg, "dvd")) {
2199 2199
 
... ...
@@ -2204,17 +2204,17 @@ static int opt_target(void *optctx, const char *opt, const char *arg)
2204 2204
         parse_option(o, "s", norm == PAL ? "720x576" : "720x480", options);
2205 2205
         parse_option(o, "r", frame_rates[norm], options);
2206 2206
         parse_option(o, "pix_fmt", "yuv420p", options);
2207
-        av_dict_set(&o->g->codec_opts, "g", norm == PAL ? "15" : "18", AV_DICT_DONT_OVERWRITE);
2207
+        opt_default(NULL, "g", norm == PAL ? "15" : "18");
2208 2208
 
2209
-        av_dict_set(&o->g->codec_opts, "b:v", "6000000", AV_DICT_DONT_OVERWRITE);
2210
-        av_dict_set(&o->g->codec_opts, "maxrate", "9000000", AV_DICT_DONT_OVERWRITE);
2211
-        av_dict_set(&o->g->codec_opts, "minrate", "0", AV_DICT_DONT_OVERWRITE); // 1500000;
2212
-        av_dict_set(&o->g->codec_opts, "bufsize", "1835008", AV_DICT_DONT_OVERWRITE); // 224*1024*8;
2209
+        opt_default(NULL, "b:v", "6000000");
2210
+        opt_default(NULL, "maxrate", "9000000");
2211
+        opt_default(NULL, "minrate", "0"); // 1500000;
2212
+        opt_default(NULL, "bufsize", "1835008"); // 224*1024*8;
2213 2213
 
2214
-        av_dict_set(&o->g->format_opts, "packetsize", "2048", AV_DICT_DONT_OVERWRITE);  // from www.mpucoder.com: DVD sectors contain 2048 bytes of data, this is also the size of one pack.
2215
-        av_dict_set(&o->g->format_opts, "muxrate", "10080000", AV_DICT_DONT_OVERWRITE); // from mplex project: data_rate = 1260000. mux_rate = data_rate * 8
2214
+        opt_default(NULL, "packetsize", "2048");  // from www.mpucoder.com: DVD sectors contain 2048 bytes of data, this is also the size of one pack.
2215
+        opt_default(NULL, "muxrate", "10080000"); // from mplex project: data_rate = 1260000. mux_rate = data_rate * 8
2216 2216
 
2217
-        av_dict_set(&o->g->codec_opts, "b:a", "448000", AV_DICT_DONT_OVERWRITE);
2217
+        opt_default(NULL, "b:a", "448000");
2218 2218
         parse_option(o, "ar", "48000", options);
2219 2219
 
2220 2220
     } else if (!strncmp(arg, "dv", 2)) {
... ...
@@ -2234,8 +2234,8 @@ static int opt_target(void *optctx, const char *opt, const char *arg)
2234 2234
         return AVERROR(EINVAL);
2235 2235
     }
2236 2236
 
2237
-    av_dict_copy(&o->g->codec_opts,  codec_opts, 0);
2238
-    av_dict_copy(&o->g->format_opts, format_opts, 0);
2237
+    av_dict_copy(&o->g->codec_opts,  codec_opts, AV_DICT_DONT_OVERWRITE);
2238
+    av_dict_copy(&o->g->format_opts, format_opts, AV_DICT_DONT_OVERWRITE);
2239 2239
 
2240 2240
     return 0;
2241 2241
 }