Browse code

Merge remote-tracking branch 'qatar/master'

* qatar/master:
build: clean up library installation rules
vf_drawtext: Remove some write-only variables.
libgsm: Drop const qualifier to silence compiler warning.
docs: Remove needless configure options
docs: Don't recommend adding --enable-memalign-hack
libvo-amrwbenc: Add braces to shut up gcc warning.
adts: Fix PCE copying.

Conflicts:
configure
doc/general.texi
subdir.mak

Merged-by: Michael Niedermayer <michaelni@gmx.at>

Michael Niedermayer authored on 2011/07/08 08:05:28
Showing 7 changed files
... ...
@@ -1690,6 +1690,8 @@ SLIBNAME='$(SLIBPREF)$(FULLNAME)$(SLIBSUF)'
1690 1690
 SLIBNAME_WITH_VERSION='$(SLIBNAME).$(LIBVERSION)'
1691 1691
 SLIBNAME_WITH_MAJOR='$(SLIBNAME).$(LIBMAJOR)'
1692 1692
 LIB_INSTALL_EXTRA_CMD='$$(RANLIB) "$(LIBDIR)/$(LIBNAME)"'
1693
+SLIB_INSTALL_NAME='$(SLIBNAME_WITH_VERSION)'
1694
+SLIB_INSTALL_LINKS='$(SLIBNAME_WITH_MAJOR) $(SLIBNAME)'
1693 1695
 
1694 1696
 AS_O='-o $@'
1695 1697
 CC_O='-o $@'
... ...
@@ -2455,12 +2457,11 @@ case $target_os in
2455 2455
         SLIBSUF=".dll"
2456 2456
         SLIBNAME_WITH_VERSION='$(SLIBPREF)$(FULLNAME)-$(LIBVERSION)$(SLIBSUF)'
2457 2457
         SLIBNAME_WITH_MAJOR='$(SLIBPREF)$(FULLNAME)-$(LIBMAJOR)$(SLIBSUF)'
2458
-        SLIB_EXTRA_CMD='-lib.exe /machine:$(LIBTARGET) /def:$$(@:$(SLIBSUF)=.def) /out:$(SUBDIR)$(SLIBNAME_WITH_MAJOR:$(SLIBSUF)=.lib)'
2459
-        SLIB_INSTALL_EXTRA_CMD='-install -m 644 $(SUBDIR)$(SLIBNAME_WITH_MAJOR:$(SLIBSUF)=.lib) "$(SHLIBDIR)/$(SLIBNAME:$(SLIBSUF)=.lib)"; \
2460
-            install -m 644 $(SUBDIR)$(SLIBNAME_WITH_MAJOR:$(SLIBSUF)=.lib) "$(SHLIBDIR)/$(SLIBNAME_WITH_MAJOR:$(SLIBSUF)=.lib)"; \
2461
-            install -d "$(LIBDIR)"; \
2462
-            install -m 644 $(SUBDIR)lib$(SLIBNAME:$(SLIBSUF)=.dll.a) "$(LIBDIR)/lib$(SLIBNAME:$(SLIBSUF)=.dll.a)"'
2463
-        SLIB_UNINSTALL_EXTRA_CMD='rm -f "$(SHLIBDIR)/$(SLIBNAME:$(SLIBSUF)=.lib)"'
2458
+        SLIB_EXTRA_CMD='-lib.exe /machine:$(LIBTARGET) /def:$$(@:$(SLIBSUF)=.def) /out:$(SUBDIR)$(SLIBNAME:$(SLIBSUF)=.lib)'
2459
+        SLIB_INSTALL_NAME='$(SLIBNAME_WITH_MAJOR)'
2460
+        SLIB_INSTALL_LINKS=
2461
+        SLIB_INSTALL_EXTRA_SHLIB='$(SLIBNAME:$(SLIBSUF)=.lib)'
2462
+        SLIB_INSTALL_EXTRA_LIB='lib$(SLIBNAME:$(SLIBSUF)=.dll.a) $(SLIBNAME_WITH_MAJOR:$(SLIBSUF)=.def)'
2464 2463
         SHFLAGS='-shared -Wl,--output-def,$$(@:$(SLIBSUF)=.def) -Wl,--out-implib,$(SUBDIR)lib$(SLIBNAME:$(SLIBSUF)=.dll.a) -Wl,--enable-runtime-pseudo-reloc -Wl,--enable-auto-image-base'
2465 2464
         objformat="win32"
2466 2465
         enable dos_paths
... ...
@@ -2518,8 +2519,7 @@ case $target_os in
2518 2518
           emxexp -o $(OBJS) >> $(SUBDIR)$(NAME).def'
2519 2519
         SLIB_EXTRA_CMD='emximp -o $(SUBDIR)$(LIBPREF)$(NAME)_dll.a $(SUBDIR)$(NAME).def; \
2520 2520
           emximp -o $(SUBDIR)$(LIBPREF)$(NAME)_dll.lib $(SUBDIR)$(NAME).def;'
2521
-        SLIB_INSTALL_EXTRA_CMD='install -m 644 $(SUBDIR)$(LIBPREF)$(NAME)_dll.a $(SUBDIR)$(LIBPREF)$(NAME)_dll.lib "$(LIBDIR)"'
2522
-        SLIB_UNINSTALL_EXTRA_CMD='rm -f "$(LIBDIR)"/$(LIBPREF)$(NAME)_dll.a "$(LIBDIR)"/$(LIBPREF)$(NAME)_dll.lib'
2521
+        SLIB_INSTALL_EXTRA_LIB='$(LIBPREF)$(NAME)_dll.a $(LIBPREF)$(NAME)_dll.lib'
2523 2522
         enable dos_paths
2524 2523
         ;;
2525 2524
     gnu/kfreebsd)
... ...
@@ -3324,8 +3324,10 @@ SLIBNAME_WITH_VERSION=${SLIBNAME_WITH_VERSION}
3324 3324
 SLIBNAME_WITH_MAJOR=${SLIBNAME_WITH_MAJOR}
3325 3325
 SLIB_CREATE_DEF_CMD=${SLIB_CREATE_DEF_CMD}
3326 3326
 SLIB_EXTRA_CMD=${SLIB_EXTRA_CMD}
3327
-SLIB_INSTALL_EXTRA_CMD=${SLIB_INSTALL_EXTRA_CMD}
3328
-SLIB_UNINSTALL_EXTRA_CMD=${SLIB_UNINSTALL_EXTRA_CMD}
3327
+SLIB_INSTALL_NAME=${SLIB_INSTALL_NAME}
3328
+SLIB_INSTALL_LINKS=${SLIB_INSTALL_LINKS}
3329
+SLIB_INSTALL_EXTRA_LIB=${SLIB_INSTALL_EXTRA_LIB}
3330
+SLIB_INSTALL_EXTRA_SHLIB=${SLIB_INSTALL_EXTRA_SHLIB}
3329 3331
 SAMPLES:=${samples:-\$(FATE_SAMPLES)}
3330 3332
 EOF
3331 3333
 
... ...
@@ -1037,7 +1037,7 @@ diffutils
1037 1037
 Then run
1038 1038
 
1039 1039
 @example
1040
-./configure --enable-static --disable-shared
1040
+./configure
1041 1041
 @end example
1042 1042
 
1043 1043
 to make a static build.
... ...
@@ -1084,7 +1084,7 @@ and add some special flags to your configure invocation.
1084 1084
 
1085 1085
 For a static build run
1086 1086
 @example
1087
-./configure --target-os=mingw32 --enable-static --disable-shared --extra-cflags=-mno-cygwin --extra-libs=-mno-cygwin
1087
+./configure --target-os=mingw32 --extra-cflags=-mno-cygwin --extra-libs=-mno-cygwin
1088 1088
 @end example
1089 1089
 
1090 1090
 and for a build with shared libraries
... ...
@@ -139,7 +139,7 @@ AVCodec ff_libgsm_ms_encoder = {
139 139
 static int libgsm_decode_frame(AVCodecContext *avctx,
140 140
                                void *data, int *data_size,
141 141
                                AVPacket *avpkt) {
142
-    const uint8_t *buf = avpkt->data;
142
+    uint8_t *buf = avpkt->data;
143 143
     int buf_size = avpkt->size;
144 144
     *data_size = 0; /* In case of error */
145 145
     if(buf_size < avctx->block_align) return -1;
... ...
@@ -34,7 +34,7 @@ typedef struct AMRWBContext {
34 34
 } AMRWBContext;
35 35
 
36 36
 static const AVOption options[] = {
37
-    { "dtx", "Allow DTX (generate comfort noise)", offsetof(AMRWBContext, allow_dtx), FF_OPT_TYPE_INT, 0, 0, 1, AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_ENCODING_PARAM },
37
+    { "dtx", "Allow DTX (generate comfort noise)", offsetof(AMRWBContext, allow_dtx), FF_OPT_TYPE_INT, { 0 }, 0, 1, AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_ENCODING_PARAM },
38 38
     { NULL }
39 39
 };
40 40
 
... ...
@@ -424,15 +424,10 @@ static inline int draw_glyph_yuv(AVFilterBufferRef *picref, FT_Bitmap *bitmap, u
424 424
 {
425 425
     int r, c, alpha;
426 426
     unsigned int luma_pos, chroma_pos1, chroma_pos2;
427
-    uint8_t src_val, dst_pixel[4];
427
+    uint8_t src_val;
428 428
 
429 429
     for (r = 0; r < bitmap->rows && r+y < height; r++) {
430 430
         for (c = 0; c < bitmap->width && c+x < width; c++) {
431
-            /* get pixel in the picref (destination) */
432
-            dst_pixel[0] = picref->data[0][  c+x           +  (y+r)          * picref->linesize[0]];
433
-            dst_pixel[1] = picref->data[1][((c+x) >> hsub) + ((y+r) >> vsub) * picref->linesize[1]];
434
-            dst_pixel[2] = picref->data[2][((c+x) >> hsub) + ((y+r) >> vsub) * picref->linesize[2]];
435
-
436 431
             /* get intensity value in the glyph bitmap (source) */
437 432
             src_val = GET_BITMAP_VAL(r, c);
438 433
             if (!src_val)
... ...
@@ -460,18 +455,10 @@ static inline int draw_glyph_rgb(AVFilterBufferRef *picref, FT_Bitmap *bitmap,
460 460
 {
461 461
     int r, c, alpha;
462 462
     uint8_t *p;
463
-    uint8_t src_val, dst_pixel[4];
463
+    uint8_t src_val;
464 464
 
465 465
     for (r = 0; r < bitmap->rows && r+y < height; r++) {
466 466
         for (c = 0; c < bitmap->width && c+x < width; c++) {
467
-            /* get pixel in the picref (destination) */
468
-            dst_pixel[0] = picref->data[0][(c+x + rgba_map[0]) * pixel_step +
469
-                                           (y+r) * picref->linesize[0]];
470
-            dst_pixel[1] = picref->data[0][(c+x + rgba_map[1]) * pixel_step +
471
-                                           (y+r) * picref->linesize[0]];
472
-            dst_pixel[2] = picref->data[0][(c+x + rgba_map[2]) * pixel_step +
473
-                                           (y+r) * picref->linesize[0]];
474
-
475 467
             /* get intensity value in the glyph bitmap (source) */
476 468
             src_val = GET_BITMAP_VAL(r, c);
477 469
             if (!src_val)
... ...
@@ -59,6 +59,10 @@ int ff_adts_decode_extradata(AVFormatContext *s, ADTSContext *adts, uint8_t *buf
59 59
         av_log(s, AV_LOG_ERROR, "Scalable configurations are not allowed in ADTS\n");
60 60
         return -1;
61 61
     }
62
+    if (get_bits(&gb, 1)) {
63
+        av_log(s, AV_LOG_ERROR, "Extension flag is not allowed in ADTS\n");
64
+        return -1;
65
+    }
62 66
     if (!adts->channel_conf) {
63 67
         init_put_bits(&pb, adts->pce_data, MAX_PCE_SIZE);
64 68
 
... ...
@@ -60,13 +60,12 @@ distclean:: clean
60 60
 
61 61
 install-lib$(NAME)-shared: $(SUBDIR)$(SLIBNAME)
62 62
 	$(Q)mkdir -p "$(SHLIBDIR)"
63
-	$$(INSTALL) -m 755 $$< "$(SHLIBDIR)/$(SLIBNAME_WITH_VERSION)"
64
-	$$(STRIP) "$(SHLIBDIR)/$(SLIBNAME_WITH_VERSION)"
65
-	$(Q)cd "$(SHLIBDIR)" && \
66
-		$(LN_S) $(SLIBNAME_WITH_VERSION) $(SLIBNAME_WITH_MAJOR)
67
-	$(Q)cd "$(SHLIBDIR)" && \
68
-		$(LN_S) $(SLIBNAME_WITH_VERSION) $(SLIBNAME)
69
-	$(SLIB_INSTALL_EXTRA_CMD)
63
+	$$(INSTALL) -m 755 $$< "$(SHLIBDIR)/$(SLIB_INSTALL_NAME)"
64
+	$$(STRIP) "$(SHLIBDIR)/$(SLIB_INSTALL_NAME)"
65
+	$(Q)$(foreach F,$(SLIB_INSTALL_LINKS),cd "$(SHLIBDIR)" && $(LN_S) $(SLIB_INSTALL_NAME) $(F);)
66
+	$(if $(SLIB_INSTALL_EXTRA_SHLIB),$$(INSTALL) -m 644 $(SLIB_INSTALL_EXTRA_SHLIB:%=$(SUBDIR)%) "$(SHLIBDIR)")
67
+	$(if $(SLIB_INSTALL_EXTRA_LIB),$(Q)mkdir -p "$(LIBDIR)")
68
+	$(if $(SLIB_INSTALL_EXTRA_LIB),$$(INSTALL) -m 644 $(SLIB_INSTALL_EXTRA_LIB:%=$(SUBDIR)%) "$(LIBDIR)")
70 69
 
71 70
 install-lib$(NAME)-static: $(SUBDIR)$(LIBNAME)
72 71
 	$(Q)mkdir -p "$(LIBDIR)"
... ...
@@ -85,7 +84,8 @@ uninstall-libs::
85 85
 	-$(RM) "$(SHLIBDIR)/$(SLIBNAME_WITH_MAJOR)" \
86 86
 	       "$(SHLIBDIR)/$(SLIBNAME)"            \
87 87
 	       "$(SHLIBDIR)/$(SLIBNAME_WITH_VERSION)"
88
-	-$(SLIB_UNINSTALL_EXTRA_CMD)
88
+	-$(RM) $(SLIB_INSTALL_EXTRA_SHLIB:%="$(SHLIBDIR)"%)
89
+	-$(RM) $(SLIB_INSTALL_EXTRA_LIB:%="$(LIBDIR)"%)
89 90
 	-$(RM) "$(LIBDIR)/$(LIBNAME)"
90 91
 
91 92
 uninstall-headers::