Browse code

kill duplicated get/put_be24()

Originally committed as revision 4460 to svn://svn.ffmpeg.org/ffmpeg/trunk

Michael Niedermayer authored on 2005/07/19 23:41:08
Showing 5 changed files
... ...
@@ -99,6 +99,7 @@ void put_le64(ByteIOContext *s, uint64_t val);
99 99
 void put_be64(ByteIOContext *s, uint64_t val);
100 100
 void put_le32(ByteIOContext *s, unsigned int val);
101 101
 void put_be32(ByteIOContext *s, unsigned int val);
102
+void put_be24(ByteIOContext *s, unsigned int val);
102 103
 void put_le16(ByteIOContext *s, unsigned int val);
103 104
 void put_be16(ByteIOContext *s, unsigned int val);
104 105
 void put_tag(ByteIOContext *s, const char *tag);
... ...
@@ -134,6 +135,7 @@ unsigned int get_le16(ByteIOContext *s);
134 134
 double get_be64_double(ByteIOContext *s);
135 135
 char *get_strz(ByteIOContext *s, char *buf, int maxlen);
136 136
 unsigned int get_be16(ByteIOContext *s);
137
+unsigned int get_be24(ByteIOContext *s);
137 138
 unsigned int get_be32(ByteIOContext *s);
138 139
 uint64_t get_be64(ByteIOContext *s);
139 140
 
... ...
@@ -253,6 +253,12 @@ void put_be16(ByteIOContext *s, unsigned int val)
253 253
     put_byte(s, val);
254 254
 }
255 255
 
256
+void put_be24(ByteIOContext *s, unsigned int val)
257
+{
258
+    put_be16(s, val >> 8);
259
+    put_byte(s, val);
260
+}
261
+
256 262
 void put_tag(ByteIOContext *s, const char *tag)
257 263
 {
258 264
     while (*tag) {
... ...
@@ -407,10 +413,8 @@ unsigned int get_le16(ByteIOContext *s)
407 407
 unsigned int get_le32(ByteIOContext *s)
408 408
 {
409 409
     unsigned int val;
410
-    val = get_byte(s);
411
-    val |= get_byte(s) << 8;
412
-    val |= get_byte(s) << 16;
413
-    val |= get_byte(s) << 24;
410
+    val = get_le16(s);
411
+    val |= get_le16(s) << 16;
414 412
     return val;
415 413
 }
416 414
 
... ...
@@ -430,15 +434,20 @@ unsigned int get_be16(ByteIOContext *s)
430 430
     return val;
431 431
 }
432 432
 
433
-unsigned int get_be32(ByteIOContext *s)
433
+unsigned int get_be24(ByteIOContext *s)
434 434
 {
435 435
     unsigned int val;
436
-    val = get_byte(s) << 24;
437
-    val |= get_byte(s) << 16;
438
-    val |= get_byte(s) << 8;
436
+    val = get_be16(s) << 8;
439 437
     val |= get_byte(s);
440 438
     return val;
441 439
 }
440
+unsigned int get_be32(ByteIOContext *s)
441
+{
442
+    unsigned int val;
443
+    val = get_be16(s) << 16;
444
+    val |= get_be16(s);
445
+    return val;
446
+}
442 447
 
443 448
 double get_be64_double(ByteIOContext *s)
444 449
 {
... ...
@@ -18,15 +18,6 @@
18 18
  */
19 19
 #include "avformat.h"
20 20
 
21
-unsigned int get_be24(ByteIOContext *s)
22
-{
23
-    unsigned int val;
24
-    val = get_byte(s) << 16;
25
-    val |= get_byte(s) << 8;
26
-    val |= get_byte(s);
27
-    return val;
28
-}
29
-
30 21
 static int flv_probe(AVProbeData *p)
31 22
 {
32 23
     const uint8_t *d;
... ...
@@ -27,13 +27,6 @@ typedef struct FLVContext {
27 27
     int reserved;
28 28
 } FLVContext;
29 29
 
30
-static void put_be24(ByteIOContext *pb, int value)
31
-{
32
-    put_byte(pb, (value>>16) & 0xFF );
33
-    put_byte(pb, (value>> 8) & 0xFF );
34
-    put_byte(pb, (value>> 0) & 0xFF );
35
-}
36
-
37 30
 static int get_audio_flags(AVCodecContext *enc){
38 31
     int flags = (enc->bits_per_sample == 16) ? 0x2 : 0x0;
39 32
 
... ...
@@ -52,6 +45,7 @@ static int get_audio_flags(AVCodecContext *enc){
52 52
             flags |= 0x00;
53 53
             break;
54 54
         default:
55
+            av_log(enc, AV_LOG_ERROR, "flv doesnt support that sample rate, choose from (44100, 22050, 11025)\n");
55 56
             return -1;
56 57
     }
57 58
 
... ...
@@ -75,6 +69,7 @@ static int get_audio_flags(AVCodecContext *enc){
75 75
         flags |= enc->codec_tag<<4;
76 76
         break;
77 77
     default:
78
+        av_log(enc, AV_LOG_ERROR, "codec not compatible with flv\n");
78 79
         return -1;
79 80
     }
80 81
     
... ...
@@ -550,15 +550,6 @@ static int mov_mp4_read_descr(ByteIOContext *pb, int *tag)
550 550
     return len;
551 551
 }
552 552
 
553
-static inline unsigned int get_be24(ByteIOContext *s)
554
-{
555
-    unsigned int val;
556
-    val = get_byte(s) << 16;
557
-    val |= get_byte(s) << 8;
558
-    val |= get_byte(s);
559
-    return val;
560
-}
561
-
562 553
 static int mov_read_esds(MOVContext *c, ByteIOContext *pb, MOV_atom_t atom)
563 554
 {
564 555
     AVStream *st = c->fc->streams[c->fc->nb_streams-1];