Browse code

Remove the "maxrate" and "minrate" OptionDef options from ffmpeg.c. This requires some modifications to the manpage, as now the unit of -b is bits/sec not kbits/sec.

Originally committed as revision 6261 to svn://svn.ffmpeg.org/ffmpeg/trunk

Panagiotis Issaris authored on 2006/09/16 02:38:43
Showing 2 changed files
... ...
@@ -271,9 +271,9 @@ Disable video recording.
271 271
 @item -bt tolerance
272 272
 Set video bitrate tolerance (in kbit/s).
273 273
 @item -maxrate bitrate
274
-Set max video bitrate tolerance (in kbit/s).
274
+Set max video bitrate tolerance (in bit/s).
275 275
 @item -minrate bitrate
276
-Set min video bitrate tolerance (in kbit/s).
276
+Set min video bitrate tolerance (in bit/s).
277 277
 @item -bufsize size
278 278
 Set rate control buffer size (in kbit).
279 279
 @item -vcodec codec
... ...
@@ -128,8 +128,6 @@ static char *video_rc_override_string=NULL;
128 128
 static char *video_rc_eq="tex^qComp";
129 129
 static int video_rc_buffer_size=0;
130 130
 static float video_rc_buffer_aggressivity=1.0;
131
-static int video_rc_max_rate=0;
132
-static int video_rc_min_rate=0;
133 131
 static float video_rc_initial_cplx=0;
134 132
 static float video_b_qfactor = 1.25;
135 133
 static float video_b_qoffset = 1.25;
... ...
@@ -2120,16 +2118,6 @@ static void opt_video_bitrate_tolerance(const char *arg)
2120 2120
     video_bit_rate_tolerance = atoi(arg) * 1000;
2121 2121
 }
2122 2122
 
2123
-static void opt_video_bitrate_max(const char *arg)
2124
-{
2125
-    video_rc_max_rate = atoi(arg) * 1000;
2126
-}
2127
-
2128
-static void opt_video_bitrate_min(const char *arg)
2129
-{
2130
-    video_rc_min_rate = atoi(arg) * 1000;
2131
-}
2132
-
2133 2123
 static void opt_video_buffer_size(const char *arg)
2134 2124
 {
2135 2125
     video_rc_buffer_size = atoi(arg) * 8*1024;
... ...
@@ -3109,8 +3097,6 @@ static void new_video_stream(AVFormatContext *oc)
3109 3109
         }
3110 3110
         video_enc->rc_override_count=i;
3111 3111
 
3112
-        video_enc->rc_max_rate = video_rc_max_rate;
3113
-        video_enc->rc_min_rate = video_rc_min_rate;
3114 3112
         video_enc->rc_buffer_size = video_rc_buffer_size;
3115 3113
         video_enc->rc_initial_buffer_occupancy = video_rc_buffer_size*3/4;
3116 3114
         video_enc->rc_buffer_aggressivity= video_rc_buffer_aggressivity;
... ...
@@ -3814,8 +3800,8 @@ static void opt_target(const char *arg)
3814 3814
         opt_gop_size(norm ? "18" : "15");
3815 3815
 
3816 3816
         opt_default("b", "1150000");
3817
-        video_rc_max_rate = 1150000;
3818
-        video_rc_min_rate = 1150000;
3817
+        opt_default("maxrate", "1150000");
3818
+        opt_default("minrate", "1150000");
3819 3819
         video_rc_buffer_size = 40*1024*8;
3820 3820
 
3821 3821
         audio_bit_rate = 224000;
... ...
@@ -3841,8 +3827,8 @@ static void opt_target(const char *arg)
3841 3841
         opt_gop_size(norm ? "18" : "15");
3842 3842
 
3843 3843
         opt_default("b", "2040000");
3844
-        video_rc_max_rate = 2516000;
3845
-        video_rc_min_rate = 0; //1145000;
3844
+        opt_default("maxrate", "2516000");
3845
+        opt_default("minrate", "0"); //1145000;
3846 3846
         video_rc_buffer_size = 224*1024*8;
3847 3847
         opt_default("flags", "+SCAN_OFFSET");
3848 3848
 
... ...
@@ -3863,8 +3849,8 @@ static void opt_target(const char *arg)
3863 3863
         opt_gop_size(norm ? "18" : "15");
3864 3864
 
3865 3865
         opt_default("b", "6000000");
3866
-        video_rc_max_rate = 9000000;
3867
-        video_rc_min_rate = 0; //1500000;
3866
+        opt_default("maxrate", "9000000");
3867
+        opt_default("minrate", "0"); //1500000;
3868 3868
         video_rc_buffer_size = 224*1024*8;
3869 3869
 
3870 3870
         mux_packet_size= 2048;  // from www.mpucoder.com: DVD sectors contain 2048 bytes of data, this is also the size of one pack.
... ...
@@ -4044,8 +4030,6 @@ const OptionDef options[] = {
4044 4044
     { "rc_eq", HAS_ARG | OPT_EXPERT | OPT_VIDEO, {(void*)opt_video_rc_eq}, "set rate control equation", "equation" },
4045 4045
     { "rc_override", HAS_ARG | OPT_EXPERT | OPT_VIDEO, {(void*)opt_video_rc_override_string}, "rate control override for specific intervals", "override" },
4046 4046
     { "bt", HAS_ARG | OPT_VIDEO, {(void*)opt_video_bitrate_tolerance}, "set video bitrate tolerance (in kbit/s)", "tolerance" },
4047
-    { "maxrate", HAS_ARG | OPT_VIDEO, {(void*)opt_video_bitrate_max}, "set max video bitrate tolerance (in kbit/s)", "bitrate" },
4048
-    { "minrate", HAS_ARG | OPT_VIDEO, {(void*)opt_video_bitrate_min}, "set min video bitrate tolerance (in kbit/s)", "bitrate" },
4049 4047
     { "bufsize", HAS_ARG | OPT_VIDEO, {(void*)opt_video_buffer_size}, "set ratecontrol buffer size (in kByte)", "size" },
4050 4048
     { "vcodec", HAS_ARG | OPT_VIDEO, {(void*)opt_video_codec}, "force video codec ('copy' to copy stream)", "codec" },
4051 4049
     { "me", HAS_ARG | OPT_EXPERT | OPT_VIDEO, {(void*)opt_motion_estimation}, "set motion estimation method",