Browse code

avserver: Remove unused loadable module support

There is no record of this ever being used at all, anywhere,
since the feature was added in 2effd274466.

This gets rid of extra linker tricks just to support a feature
that isn't used, simplifying portability to other platforms.

Signed-off-by: Martin Storsjö <martin@martin.st>

Martin Storsjö authored on 2013/07/18 00:24:23
Showing 2 changed files
... ...
@@ -58,9 +58,6 @@
58 58
 #include <time.h>
59 59
 #include <sys/wait.h>
60 60
 #include <signal.h>
61
-#if HAVE_DLFCN_H
62
-#include <dlfcn.h>
63
-#endif
64 61
 
65 62
 #include "cmdutils.h"
66 63
 
... ...
@@ -3914,32 +3911,6 @@ static enum AVCodecID opt_video_codec(const char *arg)
3914 3914
     return p->id;
3915 3915
 }
3916 3916
 
3917
-/* simplistic plugin support */
3918
-
3919
-#if HAVE_DLOPEN
3920
-static void load_module(const char *filename)
3921
-{
3922
-    void *dll;
3923
-    void (*init_func)(void);
3924
-    dll = dlopen(filename, RTLD_NOW);
3925
-    if (!dll) {
3926
-        fprintf(stderr, "Could not load module '%s' - %s\n",
3927
-                filename, dlerror());
3928
-        return;
3929
-    }
3930
-
3931
-    init_func = dlsym(dll, "avserver_module_init");
3932
-    if (!init_func) {
3933
-        fprintf(stderr,
3934
-                "%s: init function 'avserver_module_init()' not found\n",
3935
-                filename);
3936
-        dlclose(dll);
3937
-    }
3938
-
3939
-    init_func();
3940
-}
3941
-#endif
3942
-
3943 3917
 static int avserver_opt_default(const char *opt, const char *arg,
3944 3918
                        AVCodecContext *avctx, int type)
3945 3919
 {
... ...
@@ -4596,12 +4567,7 @@ static int parse_ffconfig(const char *filename)
4596 4596
                 redirect = NULL;
4597 4597
             }
4598 4598
         } else if (!av_strcasecmp(cmd, "LoadModule")) {
4599
-            get_arg(arg, sizeof(arg), &p);
4600
-#if HAVE_DLOPEN
4601
-            load_module(arg);
4602
-#else
4603
-            ERROR("Module support not compiled into this version: '%s'\n", arg);
4604
-#endif
4599
+            ERROR("Loadable modules no longer supported\n");
4605 4600
         } else {
4606 4601
             ERROR("Incorrect keyword: '%s'\n", cmd);
4607 4602
         }
... ...
@@ -1974,7 +1974,6 @@ enable dxva2 vdpau
1974 1974
 
1975 1975
 # build settings
1976 1976
 SHFLAGS='-shared -Wl,-soname,$$(@F)'
1977
-AVSERVERLDFLAGS=-Wl,-E
1978 1977
 LIBPREF="lib"
1979 1978
 LIBSUF=".a"
1980 1979
 FULLNAME='$(NAME)$(BUILDSUF)'
... ...
@@ -3059,7 +3058,6 @@ case $target_os in
3059 3059
         host_libs=
3060 3060
         ;;
3061 3061
     sunos)
3062
-        AVSERVERLDFLAGS=""
3063 3062
         SHFLAGS='-shared -Wl,-h,$$(@F)'
3064 3063
         enabled x86 && SHFLAGS="-mimpure-text $SHFLAGS"
3065 3064
         network_extralibs="-lsocket -lnsl"
... ...
@@ -3104,7 +3102,6 @@ case $target_os in
3104 3104
         SLIBSUF=".dylib"
3105 3105
         SLIBNAME_WITH_VERSION='$(SLIBPREF)$(FULLNAME).$(LIBVERSION)$(SLIBSUF)'
3106 3106
         SLIBNAME_WITH_MAJOR='$(SLIBPREF)$(FULLNAME).$(LIBMAJOR)$(SLIBSUF)'
3107
-        AVSERVERLDFLAGS=-Wl,-bind_at_load
3108 3107
         objformat="macho"
3109 3108
         enabled x86_64 && objformat="macho64"
3110 3109
         enabled_any pic shared ||
... ...
@@ -3196,7 +3193,6 @@ case $target_os in
3196 3196
         add_cppflags -D_GNU_SOURCE
3197 3197
         add_ldflags -Zomf -Zbin-files -Zargs-wild -Zmap
3198 3198
         SHFLAGS='$(SUBDIR)$(NAME).def -Zdll -Zomf'
3199
-        AVSERVERLDFLAGS=""
3200 3199
         LIBSUF="_s.a"
3201 3200
         SLIBPREF=""
3202 3201
         SLIBSUF=".dll"
... ...
@@ -3236,7 +3232,6 @@ case $target_os in
3236 3236
         ;;
3237 3237
     osf1)
3238 3238
         add_cppflags -D_OSF_SOURCE -D_POSIX_PII -D_REENTRANT
3239
-        AVSERVERLDFLAGS=
3240 3239
         ;;
3241 3240
     minix)
3242 3241
         ;;
... ...
@@ -4120,7 +4115,6 @@ LD_LIB=$LD_LIB
4120 4120
 LD_PATH=$LD_PATH
4121 4121
 DLLTOOL=$dlltool
4122 4122
 LDFLAGS=$LDFLAGS
4123
-LDFLAGS-avserver=$AVSERVERLDFLAGS
4124 4123
 SHFLAGS=$(echo $($ldflags_filter $SHFLAGS))
4125 4124
 YASMFLAGS=$YASMFLAGS
4126 4125
 BUILDSUF=$build_suffix