1. ffmpeg
  2. Commit ec573bd2eb085b40e65dd8e1cf3c488631f62ccb
Browse code

avcodec/shorten: Fix integer overflow in residual/LPC combination

Fixes: signed integer overflow: -540538872 + -2012739576 cannot be represented in type 'int'
Fixes: 9255/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SHORTEN_fuzzer-5758630052757504

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit db7e9082e1a1479c6a8844f7adf77eae03cc2aa7)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

Michael Niedermayer authored on 2018/08/13 05:55:59
Showing 1 changed files
libavcodec/shorten.c
History View file @ ec573bd
... ... 
@@ -391,7 +391,7 @@ static int decode_subframe_lpc(ShortenContext *s, int command, int channel,
391 391 
         for (j = 0; j < pred_order; j++)
392 392 
             sum += coeffs[j] * (unsigned)s->decoded[channel][i - j - 1];
393 393 
         s->decoded[channel][i] = get_sr_golomb_shorten(&s->gb, residual_size) +
394 
-                                 (sum >> qshift);
394 
+                                 (unsigned)(sum >> qshift);
395 395 
     }
396 396
397 397 
     /* add offset to current samples */