1. openvpn
  2. Commit 0533bd715bc3865019a718fbe512f86e0a907103
Browse code

Management: warn about password only when the option is in use

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1520263680-1260-1-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg16631.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 5961250e776194a411a8dfc1670c5c0c73107bf8)

Selva Nair authored on 2018/03/06 00:28:00
Showing 1 changed files
src/openvpn/options.c
History View file @ 0533bd7
... ... 
@@ -2190,7 +2190,8 @@ options_postprocess_verify_ce(const struct options *options, const struct connec
2190 2190 
         msg(M_USAGE, "--management-client-(user|group) can only be used on unix domain sockets");
2191 2191 
     }
2192 2192
2193 
-    if (!(options->management_flags & MF_UNIX_SOCK)
2193 
+    if (options->management_addr
2194 
+        && !(options->management_flags & MF_UNIX_SOCK)
2194 2195 
         && (!options->management_user_pass))
2195 2196 
     {
2196 2197 
         msg(M_WARN, "WARNING: Using --management on a TCP port WITHOUT "