On 3/20/2013 11:42, Arne Schwabe wrote:
> ACK. But I would change "debug verb" to "debug verbosity" and I think
> there should be no comma before "but"
This text change makes sense: I've adjusted it to read "NOTE: debug
verbosity..." and saved another byte removing the comma.
Updated patch attached.
--
Josh
>From d41a0237220f2fea6647a508a2ab07263e0f160b Mon Sep 17 00:00:00 2001
From: Josh Cepek <josh.cepek@usa.net>
Date: Tue, 19 Mar 2013 22:52:12 -0500
Subject: [PATCH] Warn when using verb levels >=7 without debug
This patch adds a log warning when using --verb levels at 7 or higher
when running on builds lacking debug support. Since official builds are
now built with enable_debug=no, this warning will help developers
identify why expected debug messages may not be present in log output.
The test and message output code is omitted when built with
enable_debug=yes or enable_small=yes.
Signed-off-by: Josh Cepek <josh.cepek@usa.net>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <kicup2$gfv$1@ger.gmane.org>
URL: http://article.gmane.org/gmane.network.openvpn.devel/7425
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 58fbb8046b203ca23708c1765ee84330d8809266)
... | ... |
@@ -4672,6 +4672,12 @@ add_option (struct options *options, |
4672 | 4672 |
{ |
4673 | 4673 |
VERIFY_PERMISSION (OPT_P_MESSAGES); |
4674 | 4674 |
options->verbosity = positive_atoi (p[1]); |
4675 |
+#if !defined(ENABLE_DEBUG) && !defined(ENABLE_SMALL) |
|
4676 |
+ /* Warn when a debug verbosity is supplied when built without debug support */ |
|
4677 |
+ if (options->verbosity >= 7) |
|
4678 |
+ msg (M_WARN, "NOTE: debug verbosity (--verb %d) is enabled but this build lacks debug support.", |
|
4679 |
+ options->verbosity); |
|
4680 |
+#endif |
|
4675 | 4681 |
} |
4676 | 4682 |
else if (streq (p[0], "mute") && p[1]) |
4677 | 4683 |
{ |