GitList

Browse code

route: improve error message

- fix typ0 in message: NLSMG -> NLMSG
- use strerror() to print a human readable message
- don't print error message if error is ENETUNREACH: it means no route
found

Signed-off-by: Antonio Quartulli <a@unstable.cc>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20170720082338.1302-1-a@unstable.cc>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15101.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>

Antonio Quartulli authored on 2017/07/20 17:23:38
Showing 1 changed files

src/openvpn/route.c

History View file @ 20d9842

@@ -3441,7 +3441,14 @@ get_default_gateway_ipv6(struct route_ipv6_gateway_info *rgi6,
                              if (nh->nlmsg_type == NLMSG_ERROR)
+                             {
                                  struct nlmsgerr *ne = (struct nlmsgerr *)NLMSG_DATA(nh);
                     -            msg(M_WARN, "GDG6: NLSMG_ERROR: error %d\n", ne->error);
+                    +
                     +            /* since linux-4.11 -ENETUNREACH is returned when no route can be
                     +             * found. Don't print any error message in this case */
                     +            if (ne->error != -ENETUNREACH)
                     +            {
                     +                msg(M_WARN, "GDG6: NLMSG_ERROR: error %s\n",
                     +                    strerror(-ne->error));
                     +            }
                                  break;
+                             }