1. openvpn
  2. Commit 2c7c760dfbddbc9cf348bce06fa922c1217a2039
Browse code

Fix memory leak in buffer unit tests

buffer_list_push_data does not take ownership of the memory, so just feed
it stack data to plug the leak.

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Antonio Quartulli <antonio@openvpn.net>
Message-Id: <1512724338-22197-1-git-send-email-steffan@karger.me>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg16055.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>

Steffan Karger authored on 2017/12/08 18:12:18
Showing 1 changed files
tests/unit_tests/openvpn/test_buffer.c
History View file @ 2c7c760
... ... 
@@ -77,10 +77,9 @@ static int test_buffer_list_setup(void **state)
77 77 
     buffer_list_push(ctx->zero_length_strings, "");
78 78
79 79 
     ctx->empty_buffers = buffer_list_new(2);
80 
-    uint8_t *data1 = malloc(1);
81 
-    uint8_t *data2 = malloc(1);
82 
-    buffer_list_push_data(ctx->empty_buffers, data1, 0);
83 
-    buffer_list_push_data(ctx->empty_buffers, data2, 0);
80 
+    uint8_t data = 0;
81 
+    buffer_list_push_data(ctx->empty_buffers, &data, 0);
82 
+    buffer_list_push_data(ctx->empty_buffers, &data, 0);
84 83
85 84 
     *state = ctx;
86 85 
     return 0;