Browse code

Completely remove ancient IANA port warning.

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: 1340044749-10694-3-git-send-email-arne@rfc2549.org
URL: http://article.gmane.org/gmane.network.openvpn.devel/6742
Signed-off-by: David Sommerseth <davids@redhat.com>

Arne Schwabe authored on 2012/06/19 03:39:05
Showing 3 changed files
... ...
@@ -2462,12 +2462,6 @@ do_option_warnings (struct context *c)
2462 2462
 {
2463 2463
   const struct options *o = &c->options;
2464 2464
 
2465
-#if 1 /* JYFIXME -- port warning */
2466
-  if (!o->ce.port_option_used && (o->ce.local_port == OPENVPN_PORT && o->ce.remote_port == OPENVPN_PORT))
2467
-    msg (M_WARN, "IMPORTANT: OpenVPN's default port number is now %d, based on an official port number assignment by IANA.  OpenVPN 2.0-beta16 and earlier used 5000 as the default port.",
2468
-	 OPENVPN_PORT);
2469
-#endif
2470
-
2471 2465
   if (o->ping_send_timeout && !o->ping_rec_timeout)
2472 2466
     msg (M_WARN, "WARNING: --ping should normally be used with --ping-restart or --ping-exit");
2473 2467
 
... ...
@@ -4921,7 +4921,6 @@ add_option (struct options *options,
4921 4921
 	  msg (msglevel, "Bad port number: %s", p[1]);
4922 4922
 	  goto err;
4923 4923
 	}
4924
-      options->ce.port_option_used = true;
4925 4924
       options->ce.local_port = options->ce.remote_port = port;
4926 4925
     }
4927 4926
   else if (streq (p[0], "lport") && p[1])
... ...
@@ -4936,7 +4935,6 @@ add_option (struct options *options,
4936 4936
 	  goto err;
4937 4937
 	}
4938 4938
       options->ce.local_port_defined = true;
4939
-      options->ce.port_option_used = true;
4940 4939
       options->ce.local_port = port;
4941 4940
     }
4942 4941
   else if (streq (p[0], "rport") && p[1])
... ...
@@ -4950,7 +4948,6 @@ add_option (struct options *options,
4950 4950
 	  msg (msglevel, "Bad remote port number: %s", p[1]);
4951 4951
 	  goto err;
4952 4952
 	}
4953
-      options->ce.port_option_used = true;
4954 4953
       options->ce.remote_port = port;
4955 4954
     }
4956 4955
   else if (streq (p[0], "bind"))
... ...
@@ -90,7 +90,6 @@ struct connection_entry
90 90
   int local_port;
91 91
   bool local_port_defined;
92 92
   int remote_port;
93
-  bool port_option_used;
94 93
   const char *local;
95 94
   const char *remote;
96 95
   bool remote_float;