Browse code

Simplify and inline clear_buf()

Such a simple operation should not need a full function call.

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20171110110858.11482-1-steffan@karger.me>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15796.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>

Steffan Karger authored on 2017/11/10 20:08:58
Showing 2 changed files
... ...
@@ -179,14 +179,6 @@ buf_assign(struct buffer *dest, const struct buffer *src)
179 179
     return buf_write(dest, BPTR(src), BLEN(src));
180 180
 }
181 181
 
182
-struct buffer
183
-clear_buf(void)
184
-{
185
-    struct buffer buf;
186
-    CLEAR(buf);
187
-    return buf;
188
-}
189
-
190 182
 void
191 183
 free_buf(struct buffer *buf)
192 184
 {
... ...
@@ -131,8 +131,6 @@ struct gc_arena
131 131
 
132 132
 void buf_clear(struct buffer *buf);
133 133
 
134
-struct buffer clear_buf(void);
135
-
136 134
 void free_buf(struct buffer *buf);
137 135
 
138 136
 bool buf_assign(struct buffer *dest, const struct buffer *src);
... ...
@@ -206,6 +204,13 @@ gc_freeaddrinfo_callback(void *addr)
206 206
     freeaddrinfo((struct addrinfo *) addr);
207 207
 }
208 208
 
209
+/** Return an empty struct buffer */
210
+static inline struct buffer
211
+clear_buf(void)
212
+{
213
+    return (struct buffer) { 0 };
214
+}
215
+
209 216
 static inline bool
210 217
 buf_defined(const struct buffer *buf)
211 218
 {