addr_copy_sa is just a single line and putting that simple assignment
into an extra function does not really improve clarity.
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20221109110749.1245175-1-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25493.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
| ... | ... |
@@ -863,20 +863,6 @@ addr_zero_host(struct openvpn_sockaddr *addr) |
| 863 | 863 |
} |
| 864 | 864 |
} |
| 865 | 865 |
|
| 866 |
-static inline void |
|
| 867 |
-addr_copy_sa(struct openvpn_sockaddr *dst, const struct openvpn_sockaddr *src) |
|
| 868 |
-{
|
|
| 869 |
- dst->addr = src->addr; |
|
| 870 |
-} |
|
| 871 |
- |
|
| 872 |
-static inline bool |
|
| 873 |
-addr_inet4or6(struct sockaddr *addr) |
|
| 874 |
-{
|
|
| 875 |
- return addr->sa_family == AF_INET || addr->sa_family == AF_INET6; |
|
| 876 |
-} |
|
| 877 |
- |
|
| 878 |
-int addr_guess_family(sa_family_t af, const char *name); |
|
| 879 |
- |
|
| 880 | 866 |
static inline int |
| 881 | 867 |
af_addr_size(sa_family_t af) |
| 882 | 868 |
{
|
| ... | ... |
@@ -1052,7 +1038,7 @@ link_socket_read_udp_win32(struct link_socket *sock, |
| 1052 | 1052 |
sockethandle_t sh = { .s = sock->sd };
|
| 1053 | 1053 |
if (sock->info.dco_installed) |
| 1054 | 1054 |
{
|
| 1055 |
- addr_copy_sa(&from->dest, &sock->info.lsa->actual.dest); |
|
| 1055 |
+ from->dest = sock->info.lsa->actual.dest; |
|
| 1056 | 1056 |
sh.is_handle = true; |
| 1057 | 1057 |
} |
| 1058 | 1058 |
return sockethandle_finalize(sh, &sock->reads, buf, from); |
| ... | ... |
@@ -1089,7 +1075,7 @@ link_socket_read(struct link_socket *sock, |
| 1089 | 1089 |
else if (proto_is_tcp(sock->info.proto)) /* unified TCPv4 and TCPv6 */ |
| 1090 | 1090 |
{
|
| 1091 | 1091 |
/* from address was returned by accept */ |
| 1092 |
- addr_copy_sa(&from->dest, &sock->info.lsa->actual.dest); |
|
| 1092 |
+ from->dest = sock->info.lsa->actual.dest; |
|
| 1093 | 1093 |
return link_socket_read_tcp(sock, buf); |
| 1094 | 1094 |
} |
| 1095 | 1095 |
else |