GitList

Browse code

Do not randomize resolving of IP addresses in getaddr()

Based on a discussion on the mailing list and in the IRC meeting Feb 18,
it was decided to remove get_random() from the getaddr() function as that
can conflict with round-robin/randomization done by DNS servers.

This change must be documented in the release notes.

Signed-off-by: David Sommerseth <dazo@users.sourceforge.net>

David Sommerseth authored on 2010/02/19 05:20:14
Showing 1 changed files

socket.c

History View file @ 4880739

@@ -212,12 +212,11 @@ getaddr (unsigned int flags,
                      		++n;
                      	      ASSERT (n >= 2);
                     -	      msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to %d addresses, choosing one by random",
                     +	      msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to %d addresses, choosing the first resolved IP address",
                      		   hostname,
                      		   n);
                     -	      /* choose address randomly, for basic load-balancing capability */
                     -	      ia.s_addr = *(in_addr_t *) (h->h_addr_list[get_random () % n]);
                     +	      ia.s_addr = *(in_addr_t *) (h->h_addr_list[0]);
+                     	    }
+                     	}