GitList

Browse code

improve float collision logging

Extend the log message printed when an instance floats to an address
already taken by another instance with the same certificate. The updated
message now includes the instance being closed, the reason it's being
closed, and the new instance taking over that address.

Change-Id: I217cfb319b85fd75a88f7d4d50c374d28771df28
Signed-off-by: Ralf Lici <ralf@mandelbit.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20250718191702.9451-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32226.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>

Ralf Lici authored on 2025/07/19 04:16:56
Showing 1 changed files

src/openvpn/multi.c

History View file @ 495e02e

@@ -3263,7 +3263,11 @@ multi_process_float(struct multi_context *m, struct multi_instance *mi,
                                      mroute_addr_print(&mi->real, &gc));
                                  goto done;
+                             }
                     -        msg(D_MULTI_MEDIUM, "closing instance %s", multi_instance_string(ex_mi, false, &gc));
+                    +
                     +        msg(D_MULTI_LOW, "closing instance %s due to float collision with %s "
                     +            "using the same certificate",
                     +            multi_instance_string(ex_mi, false, &gc),
                     +            multi_instance_string(mi, false, &gc));
                              multi_close_instance(m, ex_mi, false);
+                         }