dco_linux: avoid bogus text when netlink message is not parsed
We may bail out parsing an incoming DCO message because it may
concern a different interface.
In that case we print the following debug messages:
dco_do_read
ovpn-dco: ignoring message (type=5) for foreign ifindex 313
process_incoming_dco: received message of type 0 - ignoring
However, the last message is confusing, because there is no message
of type 0 being received, but the message_type was simply not
initialized.
Bail out parsing earlier and avoid printing any bogus text.
Change-Id: I568faa12a5960e8b69de23c2df413b70b231592c
Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20250523073848.20848-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31763.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Antonio Quartulli authored on 2025/05/23 16:38:41Showing 1 changed files
| ... | ... |
@@ -1251,6 +1251,12 @@ process_incoming_dco(struct context *c) |
| 1251 | 1251 |
|
| 1252 | 1252 |
dco_do_read(dco); |
| 1253 | 1253 |
|
| 1254 |
+ /* no message for us to handle - platform specific code has logged details */ |
|
| 1255 |
+ if (dco->dco_message_type == 0) |
|
| 1256 |
+ {
|
|
| 1257 |
+ return; |
|
| 1258 |
+ } |
|
| 1259 |
+ |
|
| 1254 | 1260 |
/* FreeBSD currently sends us removal notifcation with the old peer-id in |
| 1255 | 1261 |
* p2p mode with the ping timeout reason, so ignore that one to not shoot |
| 1256 | 1262 |
* ourselves in the foot and removing the just established session */ |