Browse code

Reduce log verbosity at level 3, with a focus on removing excessive log verbosity generated by port-share activity.

Version 2.1.3k

git-svn-id: http://svn.openvpn.net/projects/branches/BETA21@7033 e7ae566f-a301-0410-adde-c780ea21d3b5

James Yonan authored on 2011/03/15 14:06:23
Showing 6 changed files
... ...
@@ -71,9 +71,7 @@
71 71
 #define D_ALIGN_ERRORS       LOGLEV(1, 14, M_NONFATAL)   /* show bad struct alignments */
72 72
 
73 73
 #define D_HANDSHAKE          LOGLEV(2, 20, 0)        /* show data & control channel handshakes */
74
-#define D_MTU_INFO           LOGLEV(2, 21, 0)        /* show terse MTU info */
75 74
 #define D_CLOSE              LOGLEV(2, 22, 0)        /* show socket and TUN/TAP close */
76
-#define D_SHOW_OCC_HASH      LOGLEV(2, 23, 0)        /* show MD5 hash of option compatibility string */
77 75
 #define D_PROXY              LOGLEV(2, 24, 0)        /* show http proxy control packets */
78 76
 #define D_ARGV               LOGLEV(2, 25, 0)        /* show struct argv errors */
79 77
 
... ...
@@ -104,14 +102,18 @@
104 104
 #define D_PACKET_TRUNC_ERR   LOGLEV(4, 55, 0)        /* PACKET_TRUNCATION_CHECK */
105 105
 #define D_PF_DROPPED         LOGLEV(4, 56, 0)        /* packet filter dropped a packet */
106 106
 #define D_MULTI_DROPPED      LOGLEV(4, 57, 0)        /* show point-to-multipoint packet drops */
107
-#define D_X509_ATTR          LOGLEV(4, 58, 0)        /* show x509-track attributes on connection */
107
+#define D_MULTI_MEDIUM       LOGLEV(4, 58, 0)        /* show medium frequency multi messages */
108
+#define D_X509_ATTR          LOGLEV(4, 59, 0)        /* show x509-track attributes on connection */
109
+#define D_INIT_MEDIUM        LOGLEV(4, 60, 0)        /* show medium frequency init messages */
110
+#define D_MTU_INFO           LOGLEV(4, 61, 0)        /* show terse MTU info */
111
+#define D_SHOW_OCC_HASH      LOGLEV(4, 62, 0)        /* show MD5 hash of option compatibility string */
108 112
 
109 113
 #define D_LOG_RW             LOGLEV(5, 0,  0)        /* Print 'R' or 'W' to stdout for read/write */
110 114
 
111
-#define D_LINK_RW            LOGLEV(6, 60, M_DEBUG)  /* show TCP/UDP reads/writes (terse) */
112
-#define D_TUN_RW             LOGLEV(6, 60, M_DEBUG)  /* show TUN/TAP reads/writes */
113
-#define D_TAP_WIN32_DEBUG    LOGLEV(6, 60, M_DEBUG)  /* show TAP-Win32 driver debug info */
114
-#define D_CLIENT_NAT         LOGLEV(6, 60, M_DEBUG)  /* show client NAT debug info */
115
+#define D_LINK_RW            LOGLEV(6, 69, M_DEBUG)  /* show TCP/UDP reads/writes (terse) */
116
+#define D_TUN_RW             LOGLEV(6, 69, M_DEBUG)  /* show TUN/TAP reads/writes */
117
+#define D_TAP_WIN32_DEBUG    LOGLEV(6, 69, M_DEBUG)  /* show TAP-Win32 driver debug info */
118
+#define D_CLIENT_NAT         LOGLEV(6, 69, M_DEBUG)  /* show client NAT debug info */
115 119
 
116 120
 #define D_SHOW_KEYS          LOGLEV(7, 70, M_DEBUG)  /* show data channel encryption keys */
117 121
 #define D_SHOW_KEY_SOURCE    LOGLEV(7, 70, M_DEBUG)  /* show data channel key source entropy */
... ...
@@ -1981,7 +1981,7 @@ do_init_crypto_tls_c1 (struct context *c)
1981 1981
     }
1982 1982
   else
1983 1983
     {
1984
-      msg (M_INFO, "Re-using SSL/TLS context");
1984
+      msg (D_INIT_MEDIUM, "Re-using SSL/TLS context");
1985 1985
     }
1986 1986
 }
1987 1987
 
... ...
@@ -106,9 +106,9 @@ lzo_compress_init (struct lzo_compress_workspace *lzowork, unsigned int flags)
106 106
     msg (M_FATAL, "Cannot initialize LZO compression library");
107 107
   lzowork->wmem = (lzo_voidp) lzo_malloc (lzowork->wmem_size);
108 108
   check_malloc_return (lzowork->wmem);
109
-  msg (M_INFO, "LZO compression initialized");
109
+  msg (D_INIT_MEDIUM, "LZO compression initialized");
110 110
 #else
111
-  msg (M_INFO, "LZO stub compression initialized");
111
+  msg (D_INIT_MEDIUM, "LZO stub compression initialized");
112 112
 #endif
113 113
   lzowork->defined = true;
114 114
 }
... ...
@@ -629,7 +629,7 @@ multi_create_instance (struct multi_context *m, const struct mroute_addr *real)
629 629
 
630 630
   perf_push (PERF_MULTI_CREATE_INSTANCE);
631 631
 
632
-  msg (D_MULTI_LOW, "MULTI: multi_create_instance called");
632
+  msg (D_MULTI_MEDIUM, "MULTI: multi_create_instance called");
633 633
 
634 634
   ALLOC_OBJ_CLEAR (mi, struct multi_instance);
635 635
 
... ...
@@ -1551,21 +1551,25 @@ link_socket_init_phase2 (struct link_socket *sock,
1551 1551
 #endif
1552 1552
 
1553 1553
   /* print local address */
1554
-  if (sock->inetd)
1555
-    msg (M_INFO, "%s link local: [inetd]", proto2ascii (sock->info.proto, true));
1556
-  else
1557
-    msg (M_INFO, "%s link local%s: %s",
1554
+  {
1555
+    const int msglevel = (sock->mode == LS_MODE_TCP_ACCEPT_FROM) ? D_INIT_MEDIUM : M_INFO;
1556
+
1557
+    if (sock->inetd)
1558
+      msg (msglevel, "%s link local: [inetd]", proto2ascii (sock->info.proto, true));
1559
+    else
1560
+      msg (msglevel, "%s link local%s: %s",
1561
+	   proto2ascii (sock->info.proto, true),
1562
+	   (sock->bind_local ? " (bound)" : ""),
1563
+	   print_sockaddr_ex (&sock->info.lsa->local, ":", sock->bind_local ? PS_SHOW_PORT : 0, &gc));
1564
+
1565
+    /* print active remote address */
1566
+    msg (msglevel, "%s link remote: %s",
1558 1567
 	 proto2ascii (sock->info.proto, true),
1559
-	 (sock->bind_local ? " (bound)" : ""),
1560
-	 print_sockaddr_ex (&sock->info.lsa->local, ":", sock->bind_local ? PS_SHOW_PORT : 0, &gc));
1561
-
1562
-  /* print active remote address */
1563
-  msg (M_INFO, "%s link remote: %s",
1564
-       proto2ascii (sock->info.proto, true),
1565
-       print_link_socket_actual_ex (&sock->info.lsa->actual,
1566
-				    ":",
1567
-				    PS_SHOW_PORT_IF_DEFINED,
1568
-				    &gc));
1568
+	 print_link_socket_actual_ex (&sock->info.lsa->actual,
1569
+				      ":",
1570
+				      PS_SHOW_PORT_IF_DEFINED,
1571
+				      &gc));
1572
+  }
1569 1573
 
1570 1574
  done:
1571 1575
   if (sig_save && signal_received)
... ...
@@ -1594,7 +1598,7 @@ link_socket_close (struct link_socket *sock)
1594 1594
 #endif
1595 1595
 	  if (!gremlin)
1596 1596
 	    {
1597
-	      msg (D_CLOSE, "TCP/UDP: Closing socket");
1597
+	      msg (D_LOW, "TCP/UDP: Closing socket");
1598 1598
 	      if (openvpn_close_socket (sock->sd))
1599 1599
 		msg (M_WARN | M_ERRNO_SOCK, "TCP/UDP: Close Socket failed");
1600 1600
 	    }
... ...
@@ -1,5 +1,5 @@
1 1
 dnl define the OpenVPN version
2
-define(PRODUCT_VERSION,[2.1.3j])
2
+define(PRODUCT_VERSION,[2.1.3k])
3 3
 dnl define the TAP version
4 4
 define(PRODUCT_TAP_ID,[tap0901])
5 5
 define(PRODUCT_TAP_WIN32_MIN_MAJOR,[9])