1. openvpn
  2. Commit a2f43c2d6f086e7aa8b6160793f0c462ee9d6aa7
Browse code

Correct the declaration of handle in 'struct openvpn_plugin_args_open_return'

- This is an opaque pointer so the change should not affect
existing plugins. But it makes the code consistent and clears up
the documentation as the handle pointer is treated as of type
"openvpn_plugin_handle_t" in the rest of the code.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Antonio Quartulli <antonio@openvpn.net>
Message-Id: <1511228605-23207-1-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15908.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>

Selva Nair authored on 2017/11/21 10:43:25
Showing 1 changed files
include/openvpn-plugin.h.in
History View file @ a2f43c2
... ... 
@@ -353,7 +353,7 @@ struct openvpn_plugin_args_open_in
353 353 
  *              type_mask = OPENVPN_PLUGIN_MASK(OPENVPN_PLUGIN_CLIENT_CONNECT)
354 354 
  *                         | OPENVPN_PLUGIN_MASK(OPENVPN_PLUGIN_CLIENT_DISCONNECT)
355 355 
  *
356 
- * *handle :    Pointer to a global plug-in context, created by the plug-in.  This pointer
356 
+ * handle :     Pointer to a global plug-in context, created by the plug-in.  This pointer
357 357 
  *              is passed on to the other plug-in calls.
358 358 
  *
359 359 
  * return_list : used to return data back to OpenVPN.
... ... 
@@ -362,7 +362,7 @@ struct openvpn_plugin_args_open_in
362 362 
 struct openvpn_plugin_args_open_return
363 363 
 {
364 364 
     int type_mask;
365 
-    openvpn_plugin_handle_t *handle;
365 
+    openvpn_plugin_handle_t handle;
366 366 
     struct openvpn_plugin_string_list **return_list;
367 367 
 };
368 368
... ... 
@@ -384,9 +384,9 @@ struct openvpn_plugin_args_open_return
384 384 
  *        these variables are not actually written to the "official"
385 385 
  *        environmental variable store of the process.
386 386 
  *
387 
- * *handle : Pointer to a global plug-in context, created by the plug-in's openvpn_plugin_open_v3().
387 
+ * handle : Pointer to a global plug-in context, created by the plug-in's openvpn_plugin_open_v3().
388 388 
  *
389 
- * *per_client_context : the per-client context pointer which was returned by
389 
+ * per_client_context : the per-client context pointer which was returned by
390 390 
  *        openvpn_plugin_client_constructor_v1, if defined.
391 391 
  *
392 392 
  * current_cert_depth : Certificate depth of the certificate being passed over