Browse code

t_server_null: persist test log files

The goal is to help debug issues with t_server_null. The immediate goal
is to be able to debug server startup issues encountered on some of the
*BSD platforms.

Change-Id: I49f1e7d25edb62bf202ffceb45dedc213f2eafdd
Signed-off-by: Samuli Seppänen <samuli.seppanen@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20241024133220.4864-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/search?l=mid&q=20241024133220.4864-1-gert@greenie.muc.de
URL: https://gerrit.openvpn.net/c/openvpn/+/776
Signed-off-by: Gert Doering <gert@greenie.muc.de>

Samuli Seppänen authored on 2024/10/24 22:32:17
Showing 3 changed files
... ...
@@ -56,6 +56,10 @@ else
56 56
 fi
57 57
 
58 58
 srcdir="${srcdir:-.}"
59
+export t_server_null_logdir=t_server_null-`hostname`-`date +%Y%m%d-%H%M%S`
60
+
61
+# Create directory for server and client logs
62
+mkdir $t_server_null_logdir
59 63
 
60 64
 "${srcdir}/t_server_null_server.sh" &
61 65
 "${srcdir}/t_server_null_client.sh"
... ...
@@ -14,7 +14,7 @@ launch_client() {
14 14
         $client_conf \
15 15
         --writepid "${pid}" \
16 16
         --setenv pid $pid \
17
-        --log "${log}" &
17
+        --log "${t_server_null_logdir}/${log}" &
18 18
 }
19 19
 
20 20
 wait_for_results() {
... ...
@@ -44,7 +44,7 @@ get_client_test_result() {
44 44
     should_pass=$2
45 45
     log="${test_name}.log"
46 46
 
47
-    grep "Initialization Sequence Completed" "${log}" > /dev/null
47
+    grep "Initialization Sequence Completed" "${t_server_null_logdir}/${log}" > /dev/null
48 48
     exit_code=$?
49 49
 
50 50
     if [ $exit_code -eq 0 ] && [ "${should_pass}" = "yes" ]; then
... ...
@@ -4,12 +4,11 @@ launch_server() {
4 4
     server_name=$1
5 5
     server_exec=$2
6 6
     server_conf=$3
7
-    log="${server_name}.log"
7
+    log="${t_server_null_logdir}/${server_name}.log"
8 8
     status="${server_name}.status"
9 9
     pid="${server_name}.pid"
10 10
 
11 11
     if [ -z "${RUN_SUDO}" ]; then
12
-        rm -f "${status}" "${log}" "${pid}"
13 12
         "${server_exec}" \
14 13
          $server_conf \
15 14
          --status "${status}" 1 \
... ...
@@ -17,7 +16,6 @@ launch_server() {
17 17
          --writepid "${pid}" \
18 18
          --explicit-exit-notify 3
19 19
     else
20
-        $RUN_SUDO rm -f "${status}" "${log}" "${pid}"
21 20
         $RUN_SUDO "${server_exec}" \
22 21
                    $server_conf \
23 22
                    --status "${status}" 1 \