GitList

Browse code

Fix socks_proxy_port pointing to invalid data

When setting the SOCKS proxy through the management interface, the
socks_proxy_port pointer would be set to a value that's no longer valid
by the time it's used by do_preresolve_host.

Signed-off-by: Thomas Veerman <thomas.veerman@wanwire.net>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <20170707195941.61773-1-thomas.veerman@wanwire.net>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15018.html
Signed-off-by: David Sommerseth <davids@openvpn.net>

Thomas Veerman via Openvpn-devel authored on 2017/07/08 04:59:41
Showing 1 changed files

src/openvpn/init.c index f0fc241..c61b06d 100644

src/openvpn/init.c

History View file @ aa9d3a5

@@ -150,7 +150,7 @@ management_callback_proxy_cmd(void *arg, const char **p)
         else if (streq(p[1], "SOCKS"))
         {
             ce->socks_proxy_server = string_alloc(p[2], gc);
-            ce->socks_proxy_port = p[3];
+            ce->socks_proxy_port = string_alloc(p[3], gc);
             ret = true;
         }
     }

...	...	@@ -150,7 +150,7 @@ management_callback_proxy_cmd(void arg, const char *p)
150	150	else if (streq(p[1], "SOCKS"))
151	151	{
152	152	ce->socks_proxy_server = string_alloc(p[2], gc);
153		- ce->socks_proxy_port = p[3];
	153	+ ce->socks_proxy_port = string_alloc(p[3], gc);
154	154	ret = true;
155	155	}
156	156	}