Browse code

configure: Review use of standard AC macros

- Increase required version to 2.60 since that is documented
minimum version for AC_USE_SYSTEM_EXTENSIONS
- Remove obsolete macros AC_C_CONST and AC_C_VOLATILE. They
are noops on every compiler we support.
- Add explicit call to AC_PROG_CC. We get this implictly as
dependency of other macros, but it is nicer to have it
explicitely as well.
- A few typo and whitespace fixes.

Change-Id: I7927a572611b7c1dc0b522fd6cdf05fd222a852d
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20240918204551.2530-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29321.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>

Frank Lichtenheld authored on 2024/09/19 05:45:50
Showing 1 changed files
... ...
@@ -23,7 +23,7 @@ dnl  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
23 23
 
24 24
 dnl Process this file with autoconf to produce a configure script.
25 25
 
26
-AC_PREREQ(2.59)
26
+AC_PREREQ(2.60)
27 27
 
28 28
 m4_include(version.m4)
29 29
 AC_INIT([PRODUCT_NAME], [PRODUCT_VERSION], [PRODUCT_BUGREPORT], [PRODUCT_TARNAME])
... ...
@@ -387,6 +387,7 @@ else
387 387
 	pkg_config_found="(${PKG_CONFIG})"
388 388
 fi
389 389
 
390
+AC_PROG_CC
390 391
 AC_PROG_CPP
391 392
 AC_PROG_INSTALL
392 393
 AC_PROG_LN_S
... ...
@@ -443,9 +444,7 @@ ifdef(
443 443
 	]
444 444
 )
445 445
 
446
-AC_C_CONST
447 446
 AC_C_INLINE
448
-AC_C_VOLATILE
449 447
 AC_TYPE_OFF_T
450 448
 AC_TYPE_PID_T
451 449
 AC_TYPE_SIZE_T
... ...
@@ -958,7 +957,7 @@ if test "${with_crypto_library}" = "openssl"; then
958 958
 		[AC_MSG_ERROR([OpenSSL check for AES-256-GCM support failed])]
959 959
 	)
960 960
 
961
-	# All supported OpenSSL version (>= 1.1.0)
961
+	# All supported OpenSSL versions (>= 1.1.0)
962 962
 	# have this feature
963 963
 	have_export_keying_material="yes"
964 964
 
... ...
@@ -1065,9 +1064,8 @@ elif test "${with_crypto_library}" = "mbedtls"; then
1065 1065
 
1066 1066
 elif test "${with_crypto_library}" = "wolfssl"; then
1067 1067
 	AC_ARG_VAR([WOLFSSL_CFLAGS], [C compiler flags for wolfssl. The include directory should
1068
-								  contain the regular wolfSSL header files but also the
1069
-								  wolfSSL OpenSSL header files. Ex: -I/usr/local/include
1070
-								  -I/usr/local/include/wolfssl])
1068
+ contain the regular wolfSSL header files but also the wolfSSL OpenSSL header files.
1069
+ Ex: -I/usr/local/include -I/usr/local/include/wolfssl])
1071 1070
 	AC_ARG_VAR([WOLFSSL_LIBS], [linker flags for wolfssl])
1072 1071
 
1073 1072
 	saved_CFLAGS="${CFLAGS}"
... ...
@@ -1258,7 +1256,7 @@ if test "$enable_systemd" = "yes" ; then
1258 1258
                       [PKG_CHECK_MODULES([libsystemd], [libsystemd-daemon])]
1259 1259
                       )
1260 1260
 
1261
-    PKG_CHECK_EXISTS( [libsystemd > 216],
1261
+    PKG_CHECK_EXISTS([libsystemd > 216],
1262 1262
                      [AC_DEFINE([SYSTEMD_NEWER_THAN_216], [1],
1263 1263
                            [systemd is newer than v216])]
1264 1264
                     )