Browse code

Fix undefined signed shift overflow

Originally discussed here:

https://github.com/OpenVPN/openvpn/pull/42

Thanks for your time,
Michael

Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20160202191122.GE1675@thinkpad.swarthmore.edu>
URL: http://article.gmane.org/gmane.network.openvpn.devel/11050

Signed-off-by: Gert Doering <gert@greenie.muc.de>

Michael McConville authored on 2016/02/03 04:11:22
Showing 1 changed files
... ...
@@ -3128,7 +3128,8 @@ get_default_gateway (struct route_gateway_info *rgi)
3128 3128
   struct gc_arena gc = gc_new ();
3129 3129
   struct rtmsg m_rtmsg;
3130 3130
   int sockfd = -1;
3131
-  int seq, l, pid, rtm_addrs, i;
3131
+  int seq, l, pid, rtm_addrs;
3132
+  unsigned int i;
3132 3133
   struct sockaddr so_dst, so_mask;
3133 3134
   char *cp = m_rtmsg.m_space; 
3134 3135
   struct sockaddr *gate = NULL, *ifp = NULL, *sa;
... ...
@@ -3330,7 +3331,8 @@ get_default_gateway_ipv6(struct route_ipv6_gateway_info *rgi6,
3330 3330
 
3331 3331
     struct rtmsg m_rtmsg;
3332 3332
     int sockfd = -1;
3333
-    int seq, l, pid, rtm_addrs, i;
3333
+    int seq, l, pid, rtm_addrs;
3334
+    unsigned int i;
3334 3335
     struct sockaddr_in6 so_dst, so_mask;
3335 3336
     char *cp = m_rtmsg.m_space;
3336 3337
     struct sockaddr *gate = NULL, *ifp = NULL, *sa;