Browse code
Fix possible access of uninitialized pipe handles
Compile time warning for openvpnserv.exe
interactive.c: In function ‘RunOpenvpn’:
interactive.c:160:27: warning: ‘svc_pipe’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
When RunOpenvpn exits early due to errors, uninitialized svc_pipe and
ovpn_pipe vars could get passed to CloseHandleEx(). Fix by initializing
to NULL.
Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Lev Stipakov <lstipakov@gmail.com>
Message-Id: <1582163803-3342-1-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19480.html
Signed-off-by: David Sommerseth <davids@openvpn.net>
(cherry picked from commit 32723d29b2775d63d3fe329d017e7a08e0cdcb72)
Selva Nair authored on 2020/02/20 10:56:43Showing 1 changed files
| ... | ... |
@@ -1349,7 +1349,7 @@ static DWORD WINAPI |
| 1349 | 1349 |
RunOpenvpn(LPVOID p) |
| 1350 | 1350 |
{
|
| 1351 | 1351 |
HANDLE pipe = p; |
| 1352 |
- HANDLE ovpn_pipe, svc_pipe; |
|
| 1352 |
+ HANDLE ovpn_pipe = NULL, svc_pipe = NULL; |
|
| 1353 | 1353 |
PTOKEN_USER svc_user = NULL, ovpn_user = NULL; |
| 1354 | 1354 |
HANDLE svc_token = NULL, imp_token = NULL, pri_token = NULL; |
| 1355 | 1355 |
HANDLE stdin_read = NULL, stdin_write = NULL; |