GitList

Browse code

Improve documentation on user/password requirement and unicodize function

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20221215190143.2107896-5-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25733.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 4b6854881c36e16054878e0467ef87d925e20cae)

Arne Schwabe authored on 2022/12/16 04:01:39
Showing 2 changed files

src/openvpn/misc.h

History View file @ fad810f

@@ -74,6 +74,7 @@ struct user_pass
                      #else
                      #define USER_PASS_LEN 128
                      #endif
                     +    /* Note that username and password are expected to be null-terminated */
                          char username[USER_PASS_LEN];
                          char password[USER_PASS_LEN];
                      };

src/openvpn/ntlm.c

History View file @ fad810f

@@ -143,6 +143,19 @@ my_strupr(char *str)
+                         }
+                     }
                     +/**
                     + * This function expects a null-terminated string in src and will
                     + * copy it (including the terminating NUL byte),
                     + * alternating it with 0 to dst.
                     + *
                     + * This basically will transform a ASCII string into valid UTF-16.
                     + * Characters that are 8bit in src, will get the same treatment, resulting in
                     + * invalid or wrong unicode code points.
                     + *
                     + * @note the function will blindly assume that dst has double
                     + * the space of src.
                     + * @return  the length of the number of bytes written to dst
                     + */
                      static int
                      unicodize(char *dst, const char *src)
+                     {