Browse code

dev-tools: Remove uncrustify -p

The -p option to uncrustify was providing debug information about
decisions done by uncrustify. This was useful when debugging why
certain formatting choices.

With newer versions of uncrustify the -p option can only be used on
individual files and not a list of files. Since still supporting this
would require a bigger rewrite of reformat-all.sh, it was chosen to
instead remove the usage of this option. If certain behaviours needs to
be debugged, running uncrustify on individual files directly will work
fine anyhow.

Signed-off-by: David Sommerseth <davids@openvpn.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20220420121322.42732-2-openvpn@sf.lists.topphemmelig.net>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24120.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>

David Sommerseth authored on 2022/04/20 21:13:21
Showing 1 changed files
... ...
@@ -80,8 +80,8 @@ cd "$srcroot"
80 80
 
81 81
     # Kick off uncrustify
82 82
     echo
83
-    echo "** INFO ** Running: uncrustify -c $cfg --no-backup -l C -p debug.uncr -F $files"
84
-    uncrustify -c "$cfg" --no-backup -l C -p debug.uncr -F "$files" 2>&1
83
+    echo "** INFO ** Running: uncrustify -c $cfg --no-backup -l C -F $files"
84
+    uncrustify -c "$cfg" --no-backup -l C -F "$files" 2>&1
85 85
     res=$?
86 86
     echo "** INFO ** Uncrustify completed (exit code $res)"
87 87
 } | tee "${log}-1"  # Log needs to be closed here, to be processed in next block