@@ -8,12 +8,16 @@ import (

 	osgraph "github.com/openshift/origin/pkg/api/graph"

 	buildedges "github.com/openshift/origin/pkg/build/graph"

 	buildgraph "github.com/openshift/origin/pkg/build/graph/nodes"

+	imageedges "github.com/openshift/origin/pkg/image/graph"

+	imagegraph "github.com/openshift/origin/pkg/image/graph/nodes"

 )

 // ImagePipeline represents a build, its output, and any inputs. The input

 // to a build may be another ImagePipeline.

 type ImagePipeline struct {

-	Image ImageTagLocation

+	Image               ImageTagLocation

+	DestinationResolved bool

+

 	Build *buildgraph.BuildConfigNode

 	// If set, the base image used by the build

 	BaseImage ImageTagLocation

@@ -95,6 +99,13 @@ func NewImagePipelineFromImageTagLocation(g osgraph.Graph, node graph.Node, imag

 		flow.Source = src

 	}

+	for _, input := range g.SuccessorNodesByEdgeKind(node, imageedges.ReferencedImageStreamGraphEdgeKind) {

+		covered.Insert(input.ID())

+		imageStreamNode := input.(*imagegraph.ImageStreamNode)

+

+		flow.DestinationResolved = (len(imageStreamNode.Status.DockerImageRepository) != 0)

+	}

+

 	return flow, covered

 }

new file mode 100644

@@ -0,0 +1,161 @@

+apiVersion: v1

+items:

+- apiVersion: v1

+  kind: BuildConfig

+  metadata:

+    creationTimestamp: null

+    labels:

+      app: ruby

+    name: ruby-hello-world

+  spec:

+    output:

+      to:

+        kind: ImageStreamTag

+        name: ruby-hello-world:latest

+    resources: {}

+    source:

+      git:

+        uri: https://github.com/openshift/ruby-hello-world

+      type: Git

+    strategy:

+      dockerStrategy:

+        from:

+          kind: ImageStreamTag

+          name: ruby-20-centos7:latest

+      type: Docker

+    triggers:

+    - github:

+        secret: LyddbeCAaw1a0x08xz9n

+      type: GitHub

+    - generic:

+        secret: ZnYJJeEvo1ri0Gk0f6YY

+      type: Generic

+    - imageChange: {}

+      type: ImageChange

+  status:

+    lastVersion: 0

+- apiVersion: v1

+  kind: Build

+  metadata:

+    creationTimestamp: null

+    labels:

+      app: ruby

+      buildconfig: ruby-hello-world

+    name: ruby-hello-world-1

+  spec:

+    output:

+      to:

+        kind: ImageStreamTag

+        name: ruby-hello-world:latest

+    resources: {}

+    serviceAccount: builder

+    source:

+      git:

+        uri: https://github.com/openshift/ruby-hello-world

+      type: Git

+    strategy:

+      dockerStrategy:

+        from:

+          kind: DockerImage

+          name: openshift/ruby-20-centos7:latest

+      type: Docker

+  status:

+    config:

+      name: ruby-hello-world

+    phase: New

+- apiVersion: v1

+  kind: ImageStream

+  metadata:

+    annotations:

+      openshift.io/image.dockerRepositoryCheck: 2015-07-06T19:05:12Z

+    creationTimestamp: null

+    labels:

+      app: ruby

+    name: ruby-20-centos7

+  spec:

+    dockerImageRepository: openshift/ruby-20-centos7

+  status:

+    dockerImageRepository: openshift/ruby-20-centos7

+- apiVersion: v1

+  kind: ImageStream

+  metadata:

+    creationTimestamp: null

+    labels:

+      app: ruby

+    name: ruby-hello-world

+  spec: {}

+  status:

+    dockerImageRepository: 172.30.222.57:5000/foo/ruby-hello-world

+- apiVersion: v1

+  kind: DeploymentConfig

+  metadata:

+    creationTimestamp: null

+    labels:

+      app: ruby

+    name: ruby-hello-world

+  spec:

+    replicas: 1

+    selector:

+      deploymentconfig: ruby-hello-world

+    strategy:

+      resources: {}

+      rollingParams:

+        intervalSeconds: 1

+        timeoutSeconds: 600

+        updatePeriodSeconds: 1

+      type: Rolling

+    template:

+      metadata:

+        creationTimestamp: null

+        labels:

+          deploymentconfig: ruby-hello-world

+      spec:

+        containers:

+        - image: library/ruby-hello-world:latest

+          imagePullPolicy: Always

+          name: ruby-hello-world

+          ports:

+          - containerPort: 8080

+            name: ruby-hello-world-tcp-8080

+            protocol: TCP

+          resources: {}

+          securityContext:

+            capabilities: {}

+            privileged: false

+          terminationMessagePath: /dev/termination-log

+        dnsPolicy: ClusterFirst

+        restartPolicy: Always

+    triggers:

+    - type: ConfigChange

+    - imageChangeParams:

+        automatic: true

+        containerNames:

+        - ruby-hello-world

+        from:

+          kind: ImageStreamTag

+          name: ruby-hello-world:latest

+      type: ImageChange

+  status: {}

+- apiVersion: v1

+  kind: Service

+  metadata:

+    creationTimestamp: null

+    labels:

+      app: ruby

+    name: ruby-hello-world

+  spec:

+    portalIP: ""

+    ports:

+    - name: ruby-hello-world-tcp-8080

+      nodePort: 0

+      port: 8080

+      protocol: TCP

+      targetPort: 8080

+    selector:

+      deploymentconfig: ruby-hello-world

+    sessionAffinity: None

+    type: ClusterIP

+  status:

+    loadBalancer: {}

+kind: List

+metadata: {}

new file mode 100644

@@ -0,0 +1,161 @@

+apiVersion: v1

+items:

+- apiVersion: v1

+  kind: BuildConfig

+  metadata:

+    creationTimestamp: null

+    labels:

+      app: ruby

+    name: ruby-hello-world

+  spec:

+    output:

+      to:

+        kind: ImageStreamTag

+        name: ruby-hello-world:latest

+    resources: {}

+    source:

+      git:

+        uri: https://github.com/openshift/ruby-hello-world

+      type: Git

+    strategy:

+      dockerStrategy:

+        from:

+          kind: ImageStreamTag

+          name: ruby-20-centos7:latest

+      type: Docker

+    triggers:

+    - github:

+        secret: LyddbeCAaw1a0x08xz9n

+      type: GitHub

+    - generic:

+        secret: ZnYJJeEvo1ri0Gk0f6YY

+      type: Generic

+    - imageChange: {}

+      type: ImageChange

+  status:

+    lastVersion: 0

+- apiVersion: v1

+  kind: Build

+  metadata:

+    creationTimestamp: null

+    labels:

+      app: ruby

+      buildconfig: ruby-hello-world

+    name: ruby-hello-world-1

+  spec:

+    output:

+      to:

+        kind: ImageStreamTag

+        name: ruby-hello-world:latest

+    resources: {}

+    serviceAccount: builder

+    source:

+      git:

+        uri: https://github.com/openshift/ruby-hello-world

+      type: Git

+    strategy:

+      dockerStrategy:

+        from:

+          kind: DockerImage

+          name: openshift/ruby-20-centos7:latest

+      type: Docker

+  status:

+    config:

+      name: ruby-hello-world

+    phase: New

+- apiVersion: v1

+  kind: ImageStream

+  metadata:

+    annotations:

+      openshift.io/image.dockerRepositoryCheck: 2015-07-06T19:05:12Z

+    creationTimestamp: null

+    labels:

+      app: ruby

+    name: ruby-20-centos7

+  spec:

+    dockerImageRepository: openshift/ruby-20-centos7

+  status:

+    dockerImageRepository: openshift/ruby-20-centos7

+- apiVersion: v1

+  kind: ImageStream

+  metadata:

+    creationTimestamp: null

+    labels:

+      app: ruby

+    name: ruby-hello-world

+  spec: {}

+  status:

+    dockerImageRepository: ""

+- apiVersion: v1

+  kind: DeploymentConfig

+  metadata:

+    creationTimestamp: null

+    labels:

+      app: ruby

+    name: ruby-hello-world

+  spec:

+    replicas: 1

+    selector:

+      deploymentconfig: ruby-hello-world

+    strategy:

+      resources: {}

+      rollingParams:

+        intervalSeconds: 1

+        timeoutSeconds: 600

+        updatePeriodSeconds: 1

+      type: Rolling

+    template:

+      metadata:

+        creationTimestamp: null

+        labels:

+          deploymentconfig: ruby-hello-world

+      spec:

+        containers:

+        - image: library/ruby-hello-world:latest

+          imagePullPolicy: Always

+          name: ruby-hello-world

+          ports:

+          - containerPort: 8080

+            name: ruby-hello-world-tcp-8080

+            protocol: TCP

+          resources: {}

+          securityContext:

+            capabilities: {}

+            privileged: false

+          terminationMessagePath: /dev/termination-log

+        dnsPolicy: ClusterFirst

+        restartPolicy: Always

+    triggers:

+    - type: ConfigChange

+    - imageChangeParams:

+        automatic: true

+        containerNames:

+        - ruby-hello-world

+        from:

+          kind: ImageStreamTag

+          name: ruby-hello-world:latest

+      type: ImageChange

+  status: {}

+- apiVersion: v1

+  kind: Service

+  metadata:

+    creationTimestamp: null

+    labels:

+      app: ruby

+    name: ruby-hello-world

+  spec:

+    portalIP: ""

+    ports:

+    - name: ruby-hello-world-tcp-8080

+      nodePort: 0

+      port: 8080

+      protocol: TCP

+      targetPort: 8080

+    selector:

+      deploymentconfig: ruby-hello-world

+    sessionAffinity: None

+    type: ClusterIP

+  status:

+    loadBalancer: {}

+kind: List

+metadata: {}

@@ -24,6 +24,7 @@ import (

 	deployedges "github.com/openshift/origin/pkg/deploy/graph"

 	deploygraph "github.com/openshift/origin/pkg/deploy/graph/nodes"

 	deployutil "github.com/openshift/origin/pkg/deploy/util"

+	imageedges "github.com/openshift/origin/pkg/image/graph"

 	imagegraph "github.com/openshift/origin/pkg/image/graph/nodes"

 	projectapi "github.com/openshift/origin/pkg/project/api"

 )

@@ -88,6 +89,8 @@ func (d *ProjectStatusDescriber) MakeGraph(namespace string) (osgraph.Graph, err

 		kubeedges.AddExposedPodTemplateSpecEdges(g, service)

 	}

+	imageedges.AddAllImageStreamRefEdges(g)

+

 	return g, nil

 }

@@ -135,7 +138,7 @@ func (d *ProjectStatusDescriber) Describe(namespace, name string) (string, error

 		for _, standaloneBC := range standaloneBCs {

 			fmt.Fprintln(out)

 			printLines(out, indent, 0, describeStandaloneBuildGroup(standaloneBC, namespace)...)

-			printLines(out, indent, 1, describeAdditionalBuildDetail(standaloneBC.Build, true)...)

+			printLines(out, indent, 1, describeAdditionalBuildDetail(standaloneBC.Build, standaloneBC.DestinationResolved, true)...)

 		}

 		if (len(services) == 0) && (len(standaloneDCs) == 0) && (len(standaloneBCs) == 0) {

@@ -145,6 +148,11 @@ func (d *ProjectStatusDescriber) Describe(namespace, name string) (string, error

 		} else {

 			fmt.Fprintln(out)

+

+			if hasUnresolvedImageStreamTag(g) {

+				fmt.Fprintln(out, "Warning: Some of your builds are pointing to image streams, but the administrator has not configured the integrated Docker registry (oadm registry).")

+

+			}

 			fmt.Fprintln(out, "To see more, use 'oc describe service <name>' or 'oc describe dc <name>'.")

 			fmt.Fprintln(out, "You can use 'oc get all' to see a list of other objects.")

 		}

@@ -153,6 +161,22 @@ func (d *ProjectStatusDescriber) Describe(namespace, name string) (string, error

 	})

 }

+// hasUnresolvedImageStreamTag checks all build configs that will output to an IST backed by an ImageStream and checks to make sure their builds can push.

+func hasUnresolvedImageStreamTag(g osgraph.Graph) bool {

+	for _, bcNode := range g.NodesByKind(buildgraph.BuildConfigNodeKind) {

+		for _, istNode := range g.SuccessorNodesByEdgeKind(bcNode, buildedges.BuildOutputEdgeKind) {

+			for _, uncastImageStreamNode := range g.SuccessorNodesByEdgeKind(istNode, imageedges.ReferencedImageStreamGraphEdgeKind) {

+				imageStreamNode := uncastImageStreamNode.(*imagegraph.ImageStreamNode)

+				if len(imageStreamNode.Status.DockerImageRepository) == 0 {

+					return true

+				}

+			}

+		}

+	}

+

+	return false

+}

+

 func printLines(out io.Writer, indent string, depth int, lines ...string) {

 	for i, s := range lines {

 		fmt.Fprintf(out, strings.Repeat(indent, depth))

@@ -172,7 +196,7 @@ func describeDeploymentInServiceGroup(deploy graphview.DeploymentConfigPipeline)

 			lines[0] = segments[0] + " <-"

 			lines = append(lines, segments[1])

 		}

-		lines = append(lines, describeAdditionalBuildDetail(deploy.Images[0].Build, includeLastPass)...)

+		lines = append(lines, describeAdditionalBuildDetail(deploy.Images[0].Build, deploy.Images[0].DestinationResolved, includeLastPass)...)

 		lines = append(lines, describeDeployments(deploy.Deployment, 3)...)

 		return lines

 	}

@@ -180,7 +204,7 @@ func describeDeploymentInServiceGroup(deploy graphview.DeploymentConfigPipeline)

 	lines := []string{fmt.Sprintf("%s deploys: %s", deploy.Deployment.Name, describeDeploymentConfigTrigger(deploy.Deployment.DeploymentConfig))}

 	for _, image := range deploy.Images {

 		lines = append(lines, describeImageInPipeline(image, deploy.Deployment.Namespace))

-		lines = append(lines, describeAdditionalBuildDetail(image.Build, includeLastPass)...)

+		lines = append(lines, describeAdditionalBuildDetail(image.Build, image.DestinationResolved, includeLastPass)...)

 		lines = append(lines, describeDeployments(deploy.Deployment, 3)...)

 	}

 	return lines

@@ -263,7 +287,7 @@ func describeBuildInPipeline(build *buildapi.BuildConfig, baseImage graphview.Im

 	}

 }

-func describeAdditionalBuildDetail(build *buildgraph.BuildConfigNode, includeSuccess bool) []string {

+func describeAdditionalBuildDetail(build *buildgraph.BuildConfigNode, pushTargetResolved bool, includeSuccess bool) []string {

 	if build == nil {

 		return nil

 	}

@@ -281,17 +305,17 @@ func describeAdditionalBuildDetail(build *buildgraph.BuildConfigNode, includeSuc

 	}

 	if pass != nil && includeSuccess {

-		out = append(out, describeBuildStatus(pass, &passTime, build.BuildConfig.Name))

+		out = append(out, describeBuildStatus(pass, &passTime, build.BuildConfig.Name, pushTargetResolved))

 	}

 	if fail != nil {

-		out = append(out, describeBuildStatus(fail, &failTime, build.BuildConfig.Name))

+		out = append(out, describeBuildStatus(fail, &failTime, build.BuildConfig.Name, pushTargetResolved))

 	}

 	active := build.ActiveBuilds

 	if len(active) > 0 {

 		activeOut := []string{}

 		for i := range active {

-			activeOut = append(activeOut, describeBuildStatus(&active[i], nil, build.BuildConfig.Name))

+			activeOut = append(activeOut, describeBuildStatus(&active[i], nil, build.BuildConfig.Name, pushTargetResolved))

 		}

 		if buildTimestamp(&active[0]).Before(last) {

@@ -306,7 +330,13 @@ func describeAdditionalBuildDetail(build *buildgraph.BuildConfigNode, includeSuc

 	return out

 }

-func describeBuildStatus(build *buildapi.Build, t *util.Time, parentName string) string {

+func describeBuildStatus(build *buildapi.Build, t *util.Time, parentName string, pushTargetResolved bool) string {

+	imageStreamFailure := ""

+	// if we're using an image stream and that image stream is the internal registry and that registry doesn't exist

+	if (build.Parameters.Output.To != nil) && !pushTargetResolved {

+		imageStreamFailure = " (can't push to image)"

+	}

+

 	if t == nil {

 		ts := buildTimestamp(build)

 		t = &ts

@@ -328,14 +358,14 @@ func describeBuildStatus(build *buildapi.Build, t *util.Time, parentName string)

 	}

 	switch build.Status {

 	case buildapi.BuildStatusComplete:

-		return fmt.Sprintf("build %s succeeded %s ago%s", name, time, revision)

+		return fmt.Sprintf("build %s succeeded %s ago%s%s", name, time, revision, imageStreamFailure)

 	case buildapi.BuildStatusError:

-		return fmt.Sprintf("build %s stopped with an error %s ago%s", name, time, revision)

+		return fmt.Sprintf("build %s stopped with an error %s ago%s%s", name, time, revision, imageStreamFailure)

 	case buildapi.BuildStatusFailed:

-		return fmt.Sprintf("build %s failed %s ago%s", name, time, revision)

+		return fmt.Sprintf("build %s failed %s ago%s%s", name, time, revision, imageStreamFailure)

 	default:

 		status := strings.ToLower(string(build.Status))

-		return fmt.Sprintf("build %s %s for %s%s", name, status, time, revision)

+		return fmt.Sprintf("build %s %s for %s%s%s", name, status, time, revision, imageStreamFailure)

 	}

 }

@@ -10,7 +10,10 @@ import (

 	ktestclient "github.com/GoogleCloudPlatform/kubernetes/pkg/client/testclient"

 	"github.com/GoogleCloudPlatform/kubernetes/pkg/runtime"

+	osgraphtest "github.com/openshift/origin/pkg/api/graph/test"

+	buildedges "github.com/openshift/origin/pkg/build/graph"

 	"github.com/openshift/origin/pkg/client/testclient"

+	imageedges "github.com/openshift/origin/pkg/image/graph"

 	projectapi "github.com/openshift/origin/pkg/project/api"

 )

@@ -22,6 +25,34 @@ func mustParseTime(t string) time.Time {

 	return out

 }

+func TestUnpushableBuild(t *testing.T) {

+	g, _, err := osgraphtest.BuildGraph("../../../api/graph/test/unpushable-build.yaml")

+	if err != nil {

+		t.Fatalf("unexpected error: %v", err)

+	}

+

+	buildedges.AddAllInputOutputEdges(g)

+	imageedges.AddAllImageStreamRefEdges(g)

+

+	if e, a := true, hasUnresolvedImageStreamTag(g); e != a {

+		t.Errorf("expected %v, got %v", e, a)

+	}

+}

+

+func TestPushableBuild(t *testing.T) {

+	g, _, err := osgraphtest.BuildGraph("../../../api/graph/test/pushable-build.yaml")

+	if err != nil {

+		t.Fatalf("unexpected error: %v", err)

+	}

+

+	buildedges.AddAllInputOutputEdges(g)

+	imageedges.AddAllImageStreamRefEdges(g)

+

+	if e, a := false, hasUnresolvedImageStreamTag(g); e != a {

+		t.Errorf("expected %v, got %v", e, a)

+	}

+}

+

 func TestProjectStatus(t *testing.T) {

 	testCases := map[string]struct {

 		Path     string

new file mode 100644

@@ -0,0 +1,34 @@

+package graph

+

+import (

+	"github.com/gonum/graph"

+

+	osgraph "github.com/openshift/origin/pkg/api/graph"

+	imageapi "github.com/openshift/origin/pkg/image/api"

+	imagegraph "github.com/openshift/origin/pkg/image/graph/nodes"

+)

+

+const (

+	// ReferencedImageStreamGraphEdgeKind is an edge that goes from an ImageStreamTag node back to an ImageStream

+	ReferencedImageStreamGraphEdgeKind = "ReferencedImageStreamGraphEdge"

+)

+

+// AddImageStreamRefEdge ensures that a directed edge exists between an IST Node and the IS it references

+func AddImageStreamRefEdge(g osgraph.MutableUniqueGraph, node *imagegraph.ImageStreamTagNode) {

+	isName, _, _ := imageapi.SplitImageStreamTag(node.Name)

+	imageStream := &imageapi.ImageStream{}

+	imageStream.Namespace = node.Namespace

+	imageStream.Name = isName

+

+	imageStreamNode := imagegraph.FindOrCreateSyntheticImageStreamNode(g, imageStream)

+	g.AddEdge(node, imageStreamNode, ReferencedImageStreamGraphEdgeKind)

+}

+

+// AddAllImageStreamRefEdges calls AddImageStreamRefEdge for every ImageStreamTagNode in the graph

+func AddAllImageStreamRefEdges(g osgraph.MutableUniqueGraph) {

+	for _, node := range g.(graph.Graph).NodeList() {

+		if istNode, ok := node.(*imagegraph.ImageStreamTagNode); ok {

+			AddImageStreamRefEdge(g, istNode)

+		}

+	}

+}

@@ -85,7 +85,7 @@ func EnsureImageStreamTagNode(g osgraph.MutableUniqueGraph, ist *imageapi.ImageS

 	return osgraph.EnsureUnique(g,

 		ImageStreamTagNodeName(ist),

 		func(node osgraph.Node) graph.Node {

-			return &ImageStreamTagNode{node, ist, false}

+			return &ImageStreamTagNode{node, ist, true}

 		},

 	).(*ImageStreamTagNode)

 }

@@ -95,21 +95,31 @@ func FindOrCreateSyntheticImageStreamTagNode(g osgraph.MutableUniqueGraph, ist *

 	return osgraph.EnsureUnique(g,

 		ImageStreamTagNodeName(ist),

 		func(node osgraph.Node) graph.Node {

-			return &ImageStreamTagNode{node, ist, true}

+			return &ImageStreamTagNode{node, ist, false}

 		},

 	).(*ImageStreamTagNode)

 }

 // EnsureImageStreamNode adds a graph node for the Image Stream if it does not already exist.

-func EnsureImageStreamNode(g osgraph.MutableUniqueGraph, stream *imageapi.ImageStream) graph.Node {

+func EnsureImageStreamNode(g osgraph.MutableUniqueGraph, is *imageapi.ImageStream) graph.Node {

 	return osgraph.EnsureUnique(g,

-		ImageStreamNodeName(stream),

+		ImageStreamNodeName(is),

 		func(node osgraph.Node) graph.Node {

-			return &ImageStreamNode{node, stream}

+			return &ImageStreamNode{node, is, true}

 		},

 	)

 }

+// FindOrCreateSyntheticImageStreamNode returns the existing ISNode or creates a synthetic node in its place

+func FindOrCreateSyntheticImageStreamNode(g osgraph.MutableUniqueGraph, is *imageapi.ImageStream) *ImageStreamNode {

+	return osgraph.EnsureUnique(g,

+		ImageStreamNodeName(is),

+		func(node osgraph.Node) graph.Node {

+			return &ImageStreamNode{node, is, false}

+		},

+	).(*ImageStreamNode)

+}

+

 // EnsureImageLayerNode adds a graph node for the layer if it does not already exist.

 func EnsureImageLayerNode(g osgraph.MutableUniqueGraph, layer string) graph.Node {

 	return osgraph.EnsureUnique(g,

@@ -25,6 +25,12 @@ func ImageStreamNodeName(o *imageapi.ImageStream) osgraph.UniqueName {

 type ImageStreamNode struct {

 	osgraph.Node

 	*imageapi.ImageStream

+

+	IsFound bool

+}

+

+func (n ImageStreamNode) Found() bool {

+	return n.IsFound

 }

 func (n ImageStreamNode) Object() interface{} {

@@ -47,11 +53,11 @@ type ImageStreamTagNode struct {

 	osgraph.Node

 	*imageapi.ImageStreamTag

-	Synthetic bool

+	IsFound bool

 }

-func (n ImageStreamTagNode) IsSynthetic() bool {

-	return n.Synthetic

+func (n ImageStreamTagNode) Found() bool {

+	return n.IsFound

 }

 func (n ImageStreamTagNode) ImageSpec() string {