Browse code

Rename STIStrategy to SourceStrategy in v1beta3

Clayton Coleman authored on 2015/05/16 02:26:15
Showing 32 changed files
... ...
@@ -54,8 +54,8 @@ func TestGraph(t *testing.T) {
54 54
 		},
55 55
 		Parameters: build.BuildParameters{
56 56
 			Strategy: build.BuildStrategy{
57
-				Type: build.STIBuildStrategyType,
58
-				STIStrategy: &build.STIBuildStrategy{
57
+				Type: build.SourceBuildStrategyType,
58
+				SourceStrategy: &build.SourceBuildStrategy{
59 59
 					From: &kapi.ObjectReference{Kind: "ImageStreamTag", Name: "test:base-image"},
60 60
 				},
61 61
 			},
... ...
@@ -71,7 +71,7 @@ func fuzzInternalObject(t *testing.T, forVersion string, item runtime.Object, se
71 71
 				j.From.Kind = specs[c.Intn(len(specs))]
72 72
 			}
73 73
 		},
74
-		func(j *build.STIBuildStrategy, c fuzz.Continue) {
74
+		func(j *build.SourceBuildStrategy, c fuzz.Continue) {
75 75
 			c.FuzzNoCustom(j)
76 76
 			j.From.Kind = "ImageStreamTag"
77 77
 			j.From.Name = "image:tag"
... ...
@@ -169,8 +169,8 @@ type BuildStrategy struct {
169 169
 	// DockerStrategy holds the parameters to the Docker build strategy.
170 170
 	DockerStrategy *DockerBuildStrategy `json:"dockerStrategy,omitempty"`
171 171
 
172
-	// STIStrategy holds the parameters to the STI build strategy.
173
-	STIStrategy *STIBuildStrategy `json:"stiStrategy,omitempty"`
172
+	// SourceStrategy holds the parameters to the STI build strategy.
173
+	SourceStrategy *SourceBuildStrategy `json:"stiStrategy,omitempty"`
174 174
 
175 175
 	// CustomStrategy holds the parameters to the Custom build strategy.
176 176
 	CustomStrategy *CustomBuildStrategy `json:"customStrategy,omitempty"`
... ...
@@ -184,9 +184,9 @@ const (
184 184
 	// DockerBuildStrategyType performs builds using a Dockerfile.
185 185
 	DockerBuildStrategyType BuildStrategyType = "Docker"
186 186
 
187
-	// STIBuildStrategyType performs builds build using Source To Images with a Git repository
187
+	// SourceBuildStrategyType performs builds build using Source To Images with a Git repository
188 188
 	// and a builder image.
189
-	STIBuildStrategyType BuildStrategyType = "STI"
189
+	SourceBuildStrategyType BuildStrategyType = "STI"
190 190
 
191 191
 	// CustomBuildStrategyType performs builds using the custom builder Docker image.
192 192
 	CustomBuildStrategyType BuildStrategyType = "Custom"
... ...
@@ -235,8 +235,8 @@ type DockerBuildStrategy struct {
235 235
 	PullSecretName string `json:"pullSecretName,omitempty"`
236 236
 }
237 237
 
238
-// STIBuildStrategy defines input parameters specific to an STI build.
239
-type STIBuildStrategy struct {
238
+// SourceBuildStrategy defines input parameters specific to an STI build.
239
+type SourceBuildStrategy struct {
240 240
 	// From is reference to an ImageStream, ImageStreamTag, or ImageStreamImage from which
241 241
 	// the docker image should be pulled
242 242
 	From *kapi.ObjectReference `json:"from,omitempty"`
... ...
@@ -58,7 +58,7 @@ func init() {
58 58
 			}
59 59
 			return nil
60 60
 		},
61
-		func(in *newer.STIBuildStrategy, out *STIBuildStrategy, s conversion.Scope) error {
61
+		func(in *newer.SourceBuildStrategy, out *SourceBuildStrategy, s conversion.Scope) error {
62 62
 			if in.From != nil {
63 63
 				switch in.From.Kind {
64 64
 				case "ImageStreamImage":
... ...
@@ -96,7 +96,7 @@ func init() {
96 96
 			out.Clean = !in.Incremental
97 97
 			return s.Convert(&in.Env, &out.Env, 0)
98 98
 		},
99
-		func(in *STIBuildStrategy, out *newer.STIBuildStrategy, s conversion.Scope) error {
99
+		func(in *SourceBuildStrategy, out *newer.SourceBuildStrategy, s conversion.Scope) error {
100 100
 			out.Scripts = in.Scripts
101 101
 			out.Incremental = !in.Clean
102 102
 			out.PullSecretName = in.PullSecretName
... ...
@@ -12,13 +12,13 @@ import (
12 12
 
13 13
 var Convert = knewer.Scheme.Convert
14 14
 
15
-func TestSTIBuildStrategyOldToNewConversion(t *testing.T) {
16
-	var actual newer.STIBuildStrategy
15
+func TestSourceBuildStrategyOldToNewConversion(t *testing.T) {
16
+	var actual newer.SourceBuildStrategy
17 17
 
18
-	oldVersion := older.STIBuildStrategy{
18
+	oldVersion := older.SourceBuildStrategy{
19 19
 		BuilderImage: "testimage",
20 20
 	}
21
-	actual = newer.STIBuildStrategy{}
21
+	actual = newer.SourceBuildStrategy{}
22 22
 	err := Convert(&oldVersion, &actual)
23 23
 	if err != nil {
24 24
 		t.Fatalf("unexpected error: %v", err)
... ...
@@ -31,7 +31,7 @@ func TestSTIBuildStrategyOldToNewConversion(t *testing.T) {
31 31
 	}
32 32
 
33 33
 	// default (ImageStream/ImageRepository) Kind
34
-	oldVersion = older.STIBuildStrategy{
34
+	oldVersion = older.SourceBuildStrategy{
35 35
 		Clean: true,
36 36
 		From: &kolder.ObjectReference{
37 37
 			Name:      "name",
... ...
@@ -39,7 +39,7 @@ func TestSTIBuildStrategyOldToNewConversion(t *testing.T) {
39 39
 		},
40 40
 		Tag: "tag",
41 41
 	}
42
-	actual = newer.STIBuildStrategy{}
42
+	actual = newer.SourceBuildStrategy{}
43 43
 	err = Convert(&oldVersion, &actual)
44 44
 	if err != nil {
45 45
 		t.Fatalf("unexpected error: %v", err)
... ...
@@ -58,7 +58,7 @@ func TestSTIBuildStrategyOldToNewConversion(t *testing.T) {
58 58
 	}
59 59
 
60 60
 	// check Kind==ImageStream
61
-	oldVersion = older.STIBuildStrategy{
61
+	oldVersion = older.SourceBuildStrategy{
62 62
 		From: &kolder.ObjectReference{
63 63
 			Kind:      "ImageStream",
64 64
 			Name:      "name",
... ...
@@ -66,7 +66,7 @@ func TestSTIBuildStrategyOldToNewConversion(t *testing.T) {
66 66
 		},
67 67
 		Tag: "tag",
68 68
 	}
69
-	actual = newer.STIBuildStrategy{}
69
+	actual = newer.SourceBuildStrategy{}
70 70
 	err = Convert(&oldVersion, &actual)
71 71
 	if err != nil {
72 72
 		t.Fatalf("unexpected error: %v", err)
... ...
@@ -82,7 +82,7 @@ func TestSTIBuildStrategyOldToNewConversion(t *testing.T) {
82 82
 	}
83 83
 
84 84
 	// check Kind==ImageRepository
85
-	oldVersion = older.STIBuildStrategy{
85
+	oldVersion = older.SourceBuildStrategy{
86 86
 		From: &kolder.ObjectReference{
87 87
 			Kind:      "ImageRepository",
88 88
 			Name:      "name",
... ...
@@ -90,7 +90,7 @@ func TestSTIBuildStrategyOldToNewConversion(t *testing.T) {
90 90
 		},
91 91
 		Tag: "tag",
92 92
 	}
93
-	actual = newer.STIBuildStrategy{}
93
+	actual = newer.SourceBuildStrategy{}
94 94
 	err = Convert(&oldVersion, &actual)
95 95
 	if err != nil {
96 96
 		t.Fatalf("unexpected error: %v", err)
... ...
@@ -106,30 +106,30 @@ func TestSTIBuildStrategyOldToNewConversion(t *testing.T) {
106 106
 	}
107 107
 
108 108
 	// check default to tag to latest
109
-	oldVersion = older.STIBuildStrategy{
109
+	oldVersion = older.SourceBuildStrategy{
110 110
 		From: &kolder.ObjectReference{
111 111
 			Name:      "name",
112 112
 			Namespace: "namespace",
113 113
 		},
114 114
 	}
115
-	actual = newer.STIBuildStrategy{}
115
+	actual = newer.SourceBuildStrategy{}
116 116
 	err = Convert(&oldVersion, &actual)
117 117
 	if actual.From.Name != "name:latest" {
118 118
 		t.Errorf("expected %v, actual %v", "name:latest", actual.From.Name)
119 119
 	}
120 120
 }
121 121
 
122
-func TestSTIBuildStrategyNewToOldConversion(t *testing.T) {
123
-	var actual older.STIBuildStrategy
122
+func TestSourceBuildStrategyNewToOldConversion(t *testing.T) {
123
+	var actual older.SourceBuildStrategy
124 124
 
125
-	newVersion := newer.STIBuildStrategy{
125
+	newVersion := newer.SourceBuildStrategy{
126 126
 		From: &knewer.ObjectReference{
127 127
 			Kind:      "DockerImage",
128 128
 			Name:      "name",
129 129
 			Namespace: "namespace",
130 130
 		},
131 131
 	}
132
-	actual = older.STIBuildStrategy{}
132
+	actual = older.SourceBuildStrategy{}
133 133
 	err := Convert(&newVersion, &actual)
134 134
 	if err != nil {
135 135
 		t.Fatalf("unexpected error: %v", err)
... ...
@@ -145,14 +145,14 @@ func TestSTIBuildStrategyNewToOldConversion(t *testing.T) {
145 145
 	}
146 146
 
147 147
 	// ImageStreamTag, convert to ImageStream+tag
148
-	newVersion = newer.STIBuildStrategy{
148
+	newVersion = newer.SourceBuildStrategy{
149 149
 		From: &knewer.ObjectReference{
150 150
 			Kind:      "ImageStreamTag",
151 151
 			Name:      "name:tag",
152 152
 			Namespace: "namespace",
153 153
 		},
154 154
 	}
155
-	actual = older.STIBuildStrategy{}
155
+	actual = older.SourceBuildStrategy{}
156 156
 	err = Convert(&newVersion, &actual)
157 157
 	if err != nil {
158 158
 		t.Fatalf("unexpected error: %v", err)
... ...
@@ -171,7 +171,7 @@ func TestSTIBuildStrategyNewToOldConversion(t *testing.T) {
171 171
 	}
172 172
 
173 173
 	// ImageStreamImage, convert to ImageStream+tag
174
-	newVersion = newer.STIBuildStrategy{
174
+	newVersion = newer.SourceBuildStrategy{
175 175
 		From: &knewer.ObjectReference{
176 176
 			Kind:      "ImageStreamImage",
177 177
 			Name:      "name@id",
... ...
@@ -179,7 +179,7 @@ func TestSTIBuildStrategyNewToOldConversion(t *testing.T) {
179 179
 		},
180 180
 	}
181 181
 
182
-	actual = older.STIBuildStrategy{}
182
+	actual = older.SourceBuildStrategy{}
183 183
 	err = Convert(&newVersion, &actual)
184 184
 	if err != nil {
185 185
 		t.Fatalf("unexpected error: %v", err)
... ...
@@ -198,14 +198,14 @@ func TestSTIBuildStrategyNewToOldConversion(t *testing.T) {
198 198
 	}
199 199
 
200 200
 	// ImageStream, unchanged
201
-	newVersion = newer.STIBuildStrategy{
201
+	newVersion = newer.SourceBuildStrategy{
202 202
 		From: &knewer.ObjectReference{
203 203
 			Kind:      "ImageStream",
204 204
 			Name:      "name",
205 205
 			Namespace: "namespace",
206 206
 		},
207 207
 	}
208
-	actual = older.STIBuildStrategy{}
208
+	actual = older.SourceBuildStrategy{}
209 209
 	err = Convert(&newVersion, &actual)
210 210
 	if err != nil {
211 211
 		t.Fatalf("unexpected error: %v", err)
... ...
@@ -224,13 +224,13 @@ func TestSTIBuildStrategyNewToOldConversion(t *testing.T) {
224 224
 	}
225 225
 
226 226
 	// ImageStream(default), unchanged
227
-	newVersion = newer.STIBuildStrategy{
227
+	newVersion = newer.SourceBuildStrategy{
228 228
 		From: &knewer.ObjectReference{
229 229
 			Name:      "name",
230 230
 			Namespace: "namespace",
231 231
 		},
232 232
 	}
233
-	actual = older.STIBuildStrategy{}
233
+	actual = older.SourceBuildStrategy{}
234 234
 	err = Convert(&newVersion, &actual)
235 235
 	if err != nil {
236 236
 		t.Fatalf("unexpected error: %v", err)
... ...
@@ -165,8 +165,8 @@ type BuildStrategy struct {
165 165
 	// DockerStrategy holds the parameters to the Docker build strategy.
166 166
 	DockerStrategy *DockerBuildStrategy `json:"dockerStrategy,omitempty"`
167 167
 
168
-	// STIStrategy holds the parameters to the STI build strategy.
169
-	STIStrategy *STIBuildStrategy `json:"stiStrategy,omitempty"`
168
+	// SourceStrategy holds the parameters to the STI build strategy.
169
+	SourceStrategy *SourceBuildStrategy `json:"stiStrategy,omitempty"`
170 170
 
171 171
 	// CustomStrategy holds the parameters to the Custom build strategy
172 172
 	CustomStrategy *CustomBuildStrategy `json:"customStrategy,omitempty"`
... ...
@@ -180,9 +180,9 @@ const (
180 180
 	// DockerBuildStrategyType performs builds using a Dockerfile.
181 181
 	DockerBuildStrategyType BuildStrategyType = "Docker"
182 182
 
183
-	// STIBuildStrategyType performs builds build using Source To Images with a Git repository
183
+	// SourceBuildStrategyType performs builds build using Source To Images with a Git repository
184 184
 	// and a builder image.
185
-	STIBuildStrategyType BuildStrategyType = "STI"
185
+	SourceBuildStrategyType BuildStrategyType = "STI"
186 186
 
187 187
 	// CustomBuildStrategyType performs builds using custom builder Docker image.
188 188
 	CustomBuildStrategyType BuildStrategyType = "Custom"
... ...
@@ -255,8 +255,8 @@ type DockerBuildStrategy struct {
255 255
 	PullSecretName string `json:"pullSecretName,omitempty"`
256 256
 }
257 257
 
258
-// STIBuildStrategy defines input parameters specific to an STI build.
259
-type STIBuildStrategy struct {
258
+// SourceBuildStrategy defines input parameters specific to an STI build.
259
+type SourceBuildStrategy struct {
260 260
 	// BuilderImage is the image used to execute the build.
261 261
 	// Deprecated: will be removed in v1beta3, use Image.
262 262
 	BuilderImage string `json:"builderImage,omitempty"`
... ...
@@ -13,7 +13,7 @@ import (
13 13
 
14 14
 func init() {
15 15
 	err := kapi.Scheme.AddDefaultingFuncs(
16
-		func(obj *STIBuildStrategy) {
16
+		func(obj *SourceBuildStrategy) {
17 17
 			if obj.From != nil && len(obj.From.Kind) == 0 {
18 18
 				obj.From.Kind = "ImageStreamTag"
19 19
 			}
... ...
@@ -121,10 +121,12 @@ func init() {
121 121
 		},
122 122
 
123 123
 		func(in *newer.BuildParameters, out *BuildSpec, s conversion.Scope) error {
124
-			err := s.DefaultConvert(&in.Strategy, &out.Strategy, conversion.IgnoreMissingFields)
125
-			if err != nil {
124
+			if err := s.Convert(&in.Strategy, &out.Strategy, 0); err != nil {
126 125
 				return err
127 126
 			}
127
+			if in.Strategy.Type == newer.SourceBuildStrategyType {
128
+				out.Strategy.Type = SourceBuildStrategyType
129
+			}
128 130
 			if err := s.Convert(&in.Source, &out.Source, 0); err != nil {
129 131
 				return err
130 132
 			}
... ...
@@ -140,10 +142,12 @@ func init() {
140 140
 			return nil
141 141
 		},
142 142
 		func(in *BuildSpec, out *newer.BuildParameters, s conversion.Scope) error {
143
-			err := s.DefaultConvert(&in.Strategy, &out.Strategy, conversion.IgnoreMissingFields)
144
-			if err != nil {
143
+			if err := s.Convert(&in.Strategy, &out.Strategy, 0); err != nil {
145 144
 				return err
146 145
 			}
146
+			if in.Strategy.Type == SourceBuildStrategyType {
147
+				out.Strategy.Type = newer.SourceBuildStrategyType
148
+			}
147 149
 			if err := s.Convert(&in.Source, &out.Source, 0); err != nil {
148 150
 				return err
149 151
 			}
... ...
@@ -160,10 +164,12 @@ func init() {
160 160
 		},
161 161
 
162 162
 		func(in *newer.BuildParameters, out *BuildConfigSpec, s conversion.Scope) error {
163
-			err := s.DefaultConvert(&in.Strategy, &out.Strategy, conversion.IgnoreMissingFields)
164
-			if err != nil {
163
+			if err := s.Convert(&in.Strategy, &out.Strategy, 0); err != nil {
165 164
 				return err
166 165
 			}
166
+			if in.Strategy.Type == newer.SourceBuildStrategyType {
167
+				out.Strategy.Type = SourceBuildStrategyType
168
+			}
167 169
 			if err := s.Convert(&in.Source, &out.Source, 0); err != nil {
168 170
 				return err
169 171
 			}
... ...
@@ -179,10 +185,12 @@ func init() {
179 179
 			return nil
180 180
 		},
181 181
 		func(in *BuildConfigSpec, out *newer.BuildParameters, s conversion.Scope) error {
182
-			err := s.DefaultConvert(&in.Strategy, &out.Strategy, conversion.IgnoreMissingFields)
183
-			if err != nil {
182
+			if err := s.Convert(&in.Strategy, &out.Strategy, 0); err != nil {
184 183
 				return err
185 184
 			}
185
+			if in.Strategy.Type == SourceBuildStrategyType {
186
+				out.Strategy.Type = newer.SourceBuildStrategyType
187
+			}
186 188
 			if err := s.Convert(&in.Source, &out.Source, 0); err != nil {
187 189
 				return err
188 190
 			}
... ...
@@ -198,7 +206,7 @@ func init() {
198 198
 			return nil
199 199
 		},
200 200
 
201
-		func(in *newer.STIBuildStrategy, out *STIBuildStrategy, s conversion.Scope) error {
201
+		func(in *newer.SourceBuildStrategy, out *SourceBuildStrategy, s conversion.Scope) error {
202 202
 			if err := s.DefaultConvert(in, out, conversion.IgnoreMissingFields); err != nil {
203 203
 				return err
204 204
 			}
... ...
@@ -208,7 +216,7 @@ func init() {
208 208
 			}
209 209
 			return nil
210 210
 		},
211
-		func(in *STIBuildStrategy, out *newer.STIBuildStrategy, s conversion.Scope) error {
211
+		func(in *SourceBuildStrategy, out *newer.SourceBuildStrategy, s conversion.Scope) error {
212 212
 			if err := s.DefaultConvert(in, out, conversion.IgnoreMissingFields); err != nil {
213 213
 				return err
214 214
 			}
... ...
@@ -171,8 +171,8 @@ type BuildStrategy struct {
171 171
 	// DockerStrategy holds the parameters to the Docker build strategy.
172 172
 	DockerStrategy *DockerBuildStrategy `json:"dockerStrategy,omitempty"`
173 173
 
174
-	// STIStrategy holds the parameters to the STI build strategy.
175
-	STIStrategy *STIBuildStrategy `json:"stiStrategy,omitempty"`
174
+	// SourceStrategy holds the parameters to the Source build strategy.
175
+	SourceStrategy *SourceBuildStrategy `json:"sourceStrategy,omitempty"`
176 176
 
177 177
 	// CustomStrategy holds the parameters to the Custom build strategy
178 178
 	CustomStrategy *CustomBuildStrategy `json:"customStrategy,omitempty"`
... ...
@@ -186,9 +186,9 @@ const (
186 186
 	// DockerBuildStrategyType performs builds using a Dockerfile.
187 187
 	DockerBuildStrategyType BuildStrategyType = "Docker"
188 188
 
189
-	// STIBuildStrategyType performs builds build using Source To Images with a Git repository
189
+	// SourceBuildStrategyType performs builds build using Source To Images with a Git repository
190 190
 	// and a builder image.
191
-	STIBuildStrategyType BuildStrategyType = "STI"
191
+	SourceBuildStrategyType BuildStrategyType = "Source"
192 192
 
193 193
 	// CustomBuildStrategyType performs builds using custom builder Docker image.
194 194
 	CustomBuildStrategyType BuildStrategyType = "Custom"
... ...
@@ -231,8 +231,8 @@ type DockerBuildStrategy struct {
231 231
 	NoCache bool `json:"noCache,omitempty"`
232 232
 }
233 233
 
234
-// STIBuildStrategy defines input parameters specific to an STI build.
235
-type STIBuildStrategy struct {
234
+// SourceBuildStrategy defines input parameters specific to an Source build.
235
+type SourceBuildStrategy struct {
236 236
 	// From is reference to an ImageStream, ImageStreamTag, or ImageStreamImage from which
237 237
 	// the docker image should be pulled
238 238
 	From *kapi.ObjectReference `json:"from,omitempty"`
... ...
@@ -245,10 +245,10 @@ type STIBuildStrategy struct {
245 245
 	// Additional environment variables you want to pass into a builder container
246 246
 	Env []kapi.EnvVar `json:"env,omitempty"`
247 247
 
248
-	// Scripts is the location of STI scripts
248
+	// Scripts is the location of Source scripts
249 249
 	Scripts string `json:"scripts,omitempty"`
250 250
 
251
-	// Incremental flag forces the STI build to do incremental builds if true.
251
+	// Incremental flag forces the Source build to do incremental builds if true.
252 252
 	Incremental bool `json:"incremental,omitempty"`
253 253
 }
254 254
 
... ...
@@ -161,11 +161,11 @@ func validateStrategy(strategy *buildapi.BuildStrategy) fielderrors.ValidationEr
161 161
 	case len(strategy.Type) == 0:
162 162
 		allErrs = append(allErrs, fielderrors.NewFieldRequired("type"))
163 163
 
164
-	case strategy.Type == buildapi.STIBuildStrategyType:
165
-		if strategy.STIStrategy == nil {
164
+	case strategy.Type == buildapi.SourceBuildStrategyType:
165
+		if strategy.SourceStrategy == nil {
166 166
 			allErrs = append(allErrs, fielderrors.NewFieldRequired("stiStrategy"))
167 167
 		} else {
168
-			allErrs = append(allErrs, validateSTIStrategy(strategy.STIStrategy).Prefix("stiStrategy")...)
168
+			allErrs = append(allErrs, validateSourceStrategy(strategy.SourceStrategy).Prefix("stiStrategy")...)
169 169
 		}
170 170
 	case strategy.Type == buildapi.DockerBuildStrategyType:
171 171
 		// DockerStrategy is currently optional, initialize it to a default state if it's not set.
... ...
@@ -185,7 +185,7 @@ func validateStrategy(strategy *buildapi.BuildStrategy) fielderrors.ValidationEr
185 185
 	return allErrs
186 186
 }
187 187
 
188
-func validateSTIStrategy(strategy *buildapi.STIBuildStrategy) fielderrors.ValidationErrorList {
188
+func validateSourceStrategy(strategy *buildapi.SourceBuildStrategy) fielderrors.ValidationErrorList {
189 189
 	allErrs := fielderrors.ValidationErrorList{}
190 190
 	if strategy.From == nil || len(strategy.From.Name) == 0 {
191 191
 		allErrs = append(allErrs, fielderrors.NewFieldRequired("from"))
... ...
@@ -342,8 +342,8 @@ func TestValidateBuildParameters(t *testing.T) {
342 342
 					},
343 343
 				},
344 344
 				Strategy: buildapi.BuildStrategy{
345
-					Type:        buildapi.STIBuildStrategyType,
346
-					STIStrategy: &buildapi.STIBuildStrategy{},
345
+					Type:           buildapi.SourceBuildStrategyType,
346
+					SourceStrategy: &buildapi.SourceBuildStrategy{},
347 347
 				},
348 348
 				Output: buildapi.BuildOutput{
349 349
 					DockerImageReference: "repository/data",
... ...
@@ -398,8 +398,8 @@ func TestValidateBuildParametersSuccess(t *testing.T) {
398 398
 					},
399 399
 				},
400 400
 				Strategy: buildapi.BuildStrategy{
401
-					Type: buildapi.STIBuildStrategyType,
402
-					STIStrategy: &buildapi.STIBuildStrategy{
401
+					Type: buildapi.SourceBuildStrategyType,
402
+					SourceStrategy: &buildapi.SourceBuildStrategy{
403 403
 						From: &kapi.ObjectReference{
404 404
 							Name: "reponame",
405 405
 						},
... ...
@@ -39,15 +39,15 @@ func NewSTIBuilder(client DockerClient, dockerSocket string, authCfg docker.Auth
39 39
 func (s *STIBuilder) Build() error {
40 40
 	tag := s.build.Parameters.Output.DockerImageReference
41 41
 	request := &stiapi.Request{
42
-		BaseImage:     s.build.Parameters.Strategy.STIStrategy.From.Name,
42
+		BaseImage:     s.build.Parameters.Strategy.SourceStrategy.From.Name,
43 43
 		DockerConfig:  &stiapi.DockerConfig{Endpoint: s.dockerSocket},
44 44
 		Source:        s.build.Parameters.Source.Git.URI,
45 45
 		ContextDir:    s.build.Parameters.Source.ContextDir,
46 46
 		DockerCfgPath: os.Getenv(dockercfg.PullAuthType),
47 47
 		Tag:           tag,
48
-		ScriptsURL:    s.build.Parameters.Strategy.STIStrategy.Scripts,
48
+		ScriptsURL:    s.build.Parameters.Strategy.SourceStrategy.Scripts,
49 49
 		Environment:   getBuildEnvVars(s.build),
50
-		Incremental:   s.build.Parameters.Strategy.STIStrategy.Incremental,
50
+		Incremental:   s.build.Parameters.Strategy.SourceStrategy.Incremental,
51 51
 	}
52 52
 
53 53
 	if s.build.Parameters.Revision != nil && s.build.Parameters.Revision.Git != nil &&
... ...
@@ -20,8 +20,8 @@ func getBuildEnvVars(build *buildapi.Build) map[string]string {
20 20
 		build.Parameters.Revision.Git.Commit != "" {
21 21
 		envVars["OPENSHIFT_BUILD_COMMIT"] = build.Parameters.Revision.Git.Commit
22 22
 	}
23
-	if build.Parameters.Strategy.Type == buildapi.STIBuildStrategyType {
24
-		userEnv := build.Parameters.Strategy.STIStrategy.Env
23
+	if build.Parameters.Strategy.Type == buildapi.SourceBuildStrategyType {
24
+		userEnv := build.Parameters.Strategy.SourceStrategy.Env
25 25
 		for _, v := range userEnv {
26 26
 			envVars[v.Name] = v.Value
27 27
 		}
... ...
@@ -39,7 +39,7 @@ type BuildControllerFactory struct {
39 39
 	KubeClient          kclient.Interface
40 40
 	BuildUpdater        buildclient.BuildUpdater
41 41
 	DockerBuildStrategy *strategy.DockerBuildStrategy
42
-	STIBuildStrategy    *strategy.STIBuildStrategy
42
+	SourceBuildStrategy    *strategy.SourceBuildStrategy
43 43
 	CustomBuildStrategy *strategy.CustomBuildStrategy
44 44
 	// Stop may be set to allow controllers created by this factory to be terminated.
45 45
 	Stop <-chan struct{}
... ...
@@ -60,7 +60,7 @@ func (factory *BuildControllerFactory) Create() controller.RunnableController {
60 60
 		PodManager:        client,
61 61
 		BuildStrategy: &typeBasedFactoryStrategy{
62 62
 			DockerBuildStrategy: factory.DockerBuildStrategy,
63
-			STIBuildStrategy:    factory.STIBuildStrategy,
63
+			SourceBuildStrategy:    factory.SourceBuildStrategy,
64 64
 			CustomBuildStrategy: factory.CustomBuildStrategy,
65 65
 		},
66 66
 		Recorder: eventBroadcaster.NewRecorder(kapi.EventSource{Component: "build-controller"}),
... ...
@@ -213,7 +213,7 @@ func (pe *podEnumerator) Get(index int) interface{} {
213 213
 
214 214
 type typeBasedFactoryStrategy struct {
215 215
 	DockerBuildStrategy *strategy.DockerBuildStrategy
216
-	STIBuildStrategy    *strategy.STIBuildStrategy
216
+	SourceBuildStrategy    *strategy.SourceBuildStrategy
217 217
 	CustomBuildStrategy *strategy.CustomBuildStrategy
218 218
 }
219 219
 
... ...
@@ -223,8 +223,8 @@ func (f *typeBasedFactoryStrategy) CreateBuildPod(build *buildapi.Build) (*kapi.
223 223
 	switch build.Parameters.Strategy.Type {
224 224
 	case buildapi.DockerBuildStrategyType:
225 225
 		pod, err = f.DockerBuildStrategy.CreateBuildPod(build)
226
-	case buildapi.STIBuildStrategyType:
227
-		pod, err = f.STIBuildStrategy.CreateBuildPod(build)
226
+	case buildapi.SourceBuildStrategyType:
227
+		pod, err = f.SourceBuildStrategy.CreateBuildPod(build)
228 228
 	case buildapi.CustomBuildStrategyType:
229 229
 		pod, err = f.CustomBuildStrategy.CreateBuildPod(build)
230 230
 	default:
... ...
@@ -12,8 +12,8 @@ import (
12 12
 	cmdutil "github.com/openshift/origin/pkg/cmd/util"
13 13
 )
14 14
 
15
-// STIBuildStrategy creates STI(source to image) builds
16
-type STIBuildStrategy struct {
15
+// SourceBuildStrategy creates STI(source to image) builds
16
+type SourceBuildStrategy struct {
17 17
 	Image                string
18 18
 	TempDirectoryCreator TempDirectoryCreator
19 19
 	// Codec is the codec to use for encoding the output pod.
... ...
@@ -36,7 +36,7 @@ var STITempDirectoryCreator = &tempDirectoryCreator{}
36 36
 
37 37
 // CreateBuildPod creates a pod that will execute the STI build
38 38
 // TODO: Make the Pod definition configurable
39
-func (bs *STIBuildStrategy) CreateBuildPod(build *buildapi.Build) (*kapi.Pod, error) {
39
+func (bs *SourceBuildStrategy) CreateBuildPod(build *buildapi.Build) (*kapi.Pod, error) {
40 40
 	data, err := bs.Codec.Encode(build)
41 41
 	if err != nil {
42 42
 		return nil, err
... ...
@@ -48,7 +48,7 @@ func (bs *STIBuildStrategy) CreateBuildPod(build *buildapi.Build) (*kapi.Pod, er
48 48
 		{Name: "BUILD_LOGLEVEL", Value: fmt.Sprintf("%d", cmdutil.GetLogLevel())},
49 49
 	}
50 50
 
51
-	strategy := build.Parameters.Strategy.STIStrategy
51
+	strategy := build.Parameters.Strategy.SourceStrategy
52 52
 	if len(strategy.Env) > 0 {
53 53
 		mergeTrustedEnvWithoutDuplicates(strategy.Env, &containerEnv)
54 54
 	}
... ...
@@ -19,7 +19,7 @@ func (t *FakeTempDirCreator) CreateTempDirectory() (string, error) {
19 19
 }
20 20
 
21 21
 func TestSTICreateBuildPod(t *testing.T) {
22
-	strategy := &STIBuildStrategy{
22
+	strategy := &SourceBuildStrategy{
23 23
 		Image:                "sti-test-image",
24 24
 		TempDirectoryCreator: &FakeTempDirCreator{},
25 25
 		Codec:                v1beta1.Codec,
... ...
@@ -113,8 +113,8 @@ func mockSTIBuild() *buildapi.Build {
113 113
 				SourceSecretName: "fooSecret",
114 114
 			},
115 115
 			Strategy: buildapi.BuildStrategy{
116
-				Type: buildapi.STIBuildStrategyType,
117
-				STIStrategy: &buildapi.STIBuildStrategy{
116
+				Type: buildapi.SourceBuildStrategyType,
117
+				SourceStrategy: &buildapi.SourceBuildStrategy{
118 118
 					From: &kapi.ObjectReference{
119 119
 						Kind: "DockerImage",
120 120
 						Name: "repository/sti-builder",
... ...
@@ -162,13 +162,13 @@ func (g *BuildGenerator) generateBuildFromConfig(ctx kapi.Context, bc *buildapi.
162 162
 	// reference to a valid image so we can run the build.  Builds do not consume ImageStream references,
163 163
 	// only image specs.
164 164
 	switch {
165
-	case build.Parameters.Strategy.Type == buildapi.STIBuildStrategyType &&
166
-		build.Parameters.Strategy.STIStrategy.From != nil:
167
-		image, err := g.resolveImageStreamReference(ctx, build.Parameters.Strategy.STIStrategy.From, build.Config.Namespace)
165
+	case build.Parameters.Strategy.Type == buildapi.SourceBuildStrategyType &&
166
+		build.Parameters.Strategy.SourceStrategy.From != nil:
167
+		image, err := g.resolveImageStreamReference(ctx, build.Parameters.Strategy.SourceStrategy.From, build.Config.Namespace)
168 168
 		if err != nil {
169 169
 			return nil, err
170 170
 		}
171
-		build.Parameters.Strategy.STIStrategy.From = &kapi.ObjectReference{
171
+		build.Parameters.Strategy.SourceStrategy.From = &kapi.ObjectReference{
172 172
 			Kind: "DockerImage",
173 173
 			Name: image,
174 174
 		}
... ...
@@ -35,7 +35,7 @@ func TestInstantiate(t *testing.T) {
35 35
 	/*
36 36
 		generator := BuildGenerator{Client: Client{
37 37
 			GetBuildConfigFunc: func(ctx kapi.Context, name string) (*buildapi.BuildConfig, error) {
38
-				return mockBuildConfig(mockSource(), mockSTIStrategyForImageRepository(), mockOutput()), nil
38
+				return mockBuildConfig(mockSource(), mockSourceStrategyForImageRepository(), mockOutput()), nil
39 39
 			},
40 40
 			UpdateBuildConfigFunc: func(ctx kapi.Context, buildConfig *buildapi.BuildConfig) error {
41 41
 				return nil
... ...
@@ -58,7 +58,7 @@ func TestInstantiateRetry(t *testing.T) {
58 58
 	instantiationCalls := 0
59 59
 	generator := BuildGenerator{Client: Client{
60 60
 		GetBuildConfigFunc: func(ctx kapi.Context, name string) (*buildapi.BuildConfig, error) {
61
-			return mockBuildConfig(mockSource(), mockSTIStrategyForImageRepository(), mockOutput()), nil
61
+			return mockBuildConfig(mockSource(), mockSourceStrategyForImageRepository(), mockOutput()), nil
62 62
 		},
63 63
 		UpdateBuildConfigFunc: func(ctx kapi.Context, buildConfig *buildapi.BuildConfig) error {
64 64
 			instantiationCalls++
... ...
@@ -257,9 +257,9 @@ func TestGenerateBuildFromConfig(t *testing.T) {
257 257
 	}
258 258
 }
259 259
 
260
-func TestGenerateBuildWithImageTagForSTIStrategyImageRepository(t *testing.T) {
260
+func TestGenerateBuildWithImageTagForSourceStrategyImageRepository(t *testing.T) {
261 261
 	source := mockSource()
262
-	strategy := mockSTIStrategyForImageRepository()
262
+	strategy := mockSourceStrategyForImageRepository()
263 263
 	output := mockOutput()
264 264
 	bc := &buildapi.BuildConfig{
265 265
 		ObjectMeta: kapi.ObjectMeta{
... ...
@@ -323,8 +323,8 @@ func TestGenerateBuildWithImageTagForSTIStrategyImageRepository(t *testing.T) {
323 323
 	if err != nil {
324 324
 		t.Fatalf("Unexpected error %v", err)
325 325
 	}
326
-	if build.Parameters.Strategy.STIStrategy.From.Name != newImage {
327
-		t.Errorf("STI base image value %s does not match expected value %s", build.Parameters.Strategy.STIStrategy.From.Name, newImage)
326
+	if build.Parameters.Strategy.SourceStrategy.From.Name != newImage {
327
+		t.Errorf("STI base image value %s does not match expected value %s", build.Parameters.Strategy.SourceStrategy.From.Name, newImage)
328 328
 	}
329 329
 }
330 330
 
... ...
@@ -630,7 +630,7 @@ func TestSubstituteImageCustomBaseMatchEnvNil(t *testing.T) {
630 630
 }
631 631
 
632 632
 func TestGetNextBuildName(t *testing.T) {
633
-	bc := mockBuildConfig(mockSource(), mockSTIStrategyForImageRepository(), mockOutput())
633
+	bc := mockBuildConfig(mockSource(), mockSourceStrategyForImageRepository(), mockOutput())
634 634
 	if expected, actual := bc.Name+"-1", getNextBuildName(bc); expected != actual {
635 635
 		t.Errorf("Wrong buildName, expected %s, got %s", expected, actual)
636 636
 	}
... ...
@@ -773,10 +773,10 @@ func mockCustomStrategyForDockerImage() buildapi.BuildStrategy {
773 773
 	}
774 774
 }
775 775
 
776
-func mockSTIStrategyForImageRepository() buildapi.BuildStrategy {
776
+func mockSourceStrategyForImageRepository() buildapi.BuildStrategy {
777 777
 	return buildapi.BuildStrategy{
778
-		Type: buildapi.STIBuildStrategyType,
779
-		STIStrategy: &buildapi.STIBuildStrategy{
778
+		Type: buildapi.SourceBuildStrategyType,
779
+		SourceStrategy: &buildapi.SourceBuildStrategy{
780 780
 			From: &kapi.ObjectReference{
781 781
 				Kind:      "ImageStreamTag",
782 782
 				Name:      imageRepoName + ":" + tagName,
... ...
@@ -846,7 +846,7 @@ func mockBuild(source buildapi.BuildSource, strategy buildapi.BuildStrategy, out
846 846
 func mockBuildGenerator() *BuildGenerator {
847 847
 	return &BuildGenerator{Client: Client{
848 848
 		GetBuildConfigFunc: func(ctx kapi.Context, name string) (*buildapi.BuildConfig, error) {
849
-			return mockBuildConfig(mockSource(), mockSTIStrategyForImageRepository(), mockOutput()), nil
849
+			return mockBuildConfig(mockSource(), mockSourceStrategyForImageRepository(), mockOutput()), nil
850 850
 		},
851 851
 		UpdateBuildConfigFunc: func(ctx kapi.Context, buildConfig *buildapi.BuildConfig) error {
852 852
 			return nil
... ...
@@ -80,7 +80,7 @@ func TestCreateInstantiate(t *testing.T) {
80 80
 
81 81
 	rest := InstantiateREST{&BuildGenerator{Client: Client{
82 82
 		GetBuildConfigFunc: func(ctx kapi.Context, name string) (*buildapi.BuildConfig, error) {
83
-			return mockBuildConfig(mockSource(), mockSTIStrategyForImageRepository(), mockOutput()), nil
83
+			return mockBuildConfig(mockSource(), mockSourceStrategyForImageRepository(), mockOutput()), nil
84 84
 		},
85 85
 		UpdateBuildConfigFunc: func(ctx kapi.Context, buildConfig *buildapi.BuildConfig) error {
86 86
 			return nil
... ...
@@ -129,8 +129,8 @@ func TestEtcdCreateBuild(t *testing.T) {
129 129
 				},
130 130
 			},
131 131
 			Strategy: api.BuildStrategy{
132
-				Type: api.STIBuildStrategyType,
133
-				STIStrategy: &api.STIBuildStrategy{
132
+				Type: api.SourceBuildStrategyType,
133
+				SourceStrategy: &api.SourceBuildStrategy{
134 134
 					From: &kapi.ObjectReference{
135 135
 						Name: "builder/image",
136 136
 					},
... ...
@@ -185,8 +185,8 @@ func TestEtcdCreateBuildUsingImage(t *testing.T) {
185 185
 				},
186 186
 			},
187 187
 			Strategy: api.BuildStrategy{
188
-				Type: api.STIBuildStrategyType,
189
-				STIStrategy: &api.STIBuildStrategy{
188
+				Type: api.SourceBuildStrategyType,
189
+				SourceStrategy: &api.SourceBuildStrategy{
190 190
 					From: &kapi.ObjectReference{
191 191
 						Kind: "DockerImage",
192 192
 						Name: "builder/image",
... ...
@@ -417,8 +417,8 @@ func TestEtcdCreateBuildConfig(t *testing.T) {
417 417
 				},
418 418
 			},
419 419
 			Strategy: api.BuildStrategy{
420
-				Type: api.STIBuildStrategyType,
421
-				STIStrategy: &api.STIBuildStrategy{
420
+				Type: api.SourceBuildStrategyType,
421
+				SourceStrategy: &api.SourceBuildStrategy{
422 422
 					From: &kapi.ObjectReference{
423 423
 						Name: "builder/image",
424 424
 					},
... ...
@@ -472,8 +472,8 @@ func TestEtcdCreateBuildConfigUsingImage(t *testing.T) {
472 472
 				},
473 473
 			},
474 474
 			Strategy: api.BuildStrategy{
475
-				Type: api.STIBuildStrategyType,
476
-				STIStrategy: &api.STIBuildStrategy{
475
+				Type: api.SourceBuildStrategyType,
476
+				SourceStrategy: &api.SourceBuildStrategy{
477 477
 					From: &kapi.ObjectReference{
478 478
 						Kind: "DockerImage",
479 479
 						Name: "builder/image",
... ...
@@ -16,8 +16,8 @@ func GetBuildPodName(build *buildapi.Build) string {
16 16
 // with the BuildStrategy of a BuildConfig.
17 17
 func GetImageStreamForStrategy(config *buildapi.BuildConfig) *kapi.ObjectReference {
18 18
 	switch config.Parameters.Strategy.Type {
19
-	case buildapi.STIBuildStrategyType:
20
-		return config.Parameters.Strategy.STIStrategy.From
19
+	case buildapi.SourceBuildStrategyType:
20
+		return config.Parameters.Strategy.SourceStrategy.From
21 21
 	case buildapi.DockerBuildStrategyType:
22 22
 		return config.Parameters.Strategy.DockerStrategy.From
23 23
 	case buildapi.CustomBuildStrategyType:
... ...
@@ -20,7 +20,7 @@ func (*okBuildConfigGetter) Get(namespace, name string) (*api.BuildConfig, error
20 20
 		Parameters: api.BuildParameters{
21 21
 			Strategy: api.BuildStrategy{
22 22
 				Type: "STI",
23
-				STIStrategy: &api.STIBuildStrategy{
23
+				SourceStrategy: &api.SourceBuildStrategy{
24 24
 					From: &kapi.ObjectReference{
25 25
 						Kind: "DockerImage",
26 26
 						Name: "repository/builder-image",
... ...
@@ -257,7 +257,7 @@ func TestInvokeWebhookOK(t *testing.T) {
257 257
 		Parameters: api.BuildParameters{
258 258
 			Strategy: api.BuildStrategy{
259 259
 				Type: "STI",
260
-				STIStrategy: &api.STIBuildStrategy{
260
+				SourceStrategy: &api.SourceBuildStrategy{
261 261
 					From: &kapi.ObjectReference{
262 262
 						Kind: "DockerImage",
263 263
 						Name: "repository/builder-image",
... ...
@@ -15,7 +15,7 @@ import (
15 15
 
16 16
 var mockBuildStrategy = api.BuildStrategy{
17 17
 	Type: "STI",
18
-	STIStrategy: &api.STIBuildStrategy{
18
+	SourceStrategy: &api.SourceBuildStrategy{
19 19
 		From: &kapi.ObjectReference{
20 20
 			Name: "repository/image",
21 21
 		},
... ...
@@ -40,7 +40,7 @@ func (c *okBuildConfigGetter) Get(namespace, name string) (*api.BuildConfig, err
40 40
 
41 41
 var mockBuildStrategy = api.BuildStrategy{
42 42
 	Type: "STI",
43
-	STIStrategy: &api.STIBuildStrategy{
43
+	SourceStrategy: &api.SourceBuildStrategy{
44 44
 		From: &kapi.ObjectReference{
45 45
 			Kind: "DockerImage",
46 46
 			Name: "repository/image",
... ...
@@ -150,13 +150,21 @@ type BuildConfigDescriber struct {
150 150
 	host string
151 151
 }
152 152
 
153
+// TODO: remove when internal SourceBuildStrategyType is refactored to "Source"
154
+func describeStrategy(strategyType buildapi.BuildStrategyType) buildapi.BuildStrategyType {
155
+	if strategyType == buildapi.SourceBuildStrategyType {
156
+		strategyType = buildapi.BuildStrategyType("Source")
157
+	}
158
+	return strategyType
159
+}
160
+
153 161
 func describeBuildParameters(p buildapi.BuildParameters, out *tabwriter.Writer) {
154
-	formatString(out, "Strategy", p.Strategy.Type)
162
+	formatString(out, "Strategy", describeStrategy(p.Strategy.Type))
155 163
 	switch p.Strategy.Type {
156 164
 	case buildapi.DockerBuildStrategyType:
157 165
 		describeDockerStrategy(p.Strategy.DockerStrategy, out)
158
-	case buildapi.STIBuildStrategyType:
159
-		describeSTIStrategy(p.Strategy.STIStrategy, out)
166
+	case buildapi.SourceBuildStrategyType:
167
+		describeSourceStrategy(p.Strategy.SourceStrategy, out)
160 168
 	case buildapi.CustomBuildStrategyType:
161 169
 		describeCustomStrategy(p.Strategy.CustomStrategy, out)
162 170
 	}
... ...
@@ -202,7 +210,7 @@ func describeBuildParameters(p buildapi.BuildParameters, out *tabwriter.Writer)
202 202
 	}
203 203
 }
204 204
 
205
-func describeSTIStrategy(s *buildapi.STIBuildStrategy, out *tabwriter.Writer) {
205
+func describeSourceStrategy(s *buildapi.SourceBuildStrategy, out *tabwriter.Writer) {
206 206
 	if s.From != nil && len(s.From.Name) != 0 {
207 207
 		if len(s.From.Namespace) != 0 {
208 208
 			formatString(out, "Image Reference", fmt.Sprintf("%s %s/%s", s.From.Kind, s.From.Namespace, s.From.Name))
... ...
@@ -189,7 +189,7 @@ func printTemplateList(list *templateapi.TemplateList, w io.Writer) error {
189 189
 }
190 190
 
191 191
 func printBuild(build *buildapi.Build, w io.Writer) error {
192
-	_, err := fmt.Fprintf(w, "%s\t%s\t%s\t%s\n", build.Name, build.Parameters.Strategy.Type, build.Status, buildutil.GetBuildPodName(build))
192
+	_, err := fmt.Fprintf(w, "%s\t%s\t%s\t%s\n", build.Name, describeStrategy(build.Parameters.Strategy.Type), build.Status, buildutil.GetBuildPodName(build))
193 193
 	return err
194 194
 }
195 195
 
... ...
@@ -204,10 +204,10 @@ func printBuildList(buildList *buildapi.BuildList, w io.Writer) error {
204 204
 
205 205
 func printBuildConfig(bc *buildapi.BuildConfig, w io.Writer) error {
206 206
 	if bc.Parameters.Strategy.Type == buildapi.CustomBuildStrategyType {
207
-		_, err := fmt.Fprintf(w, "%s\t%v\t%s\n", bc.Name, bc.Parameters.Strategy.Type, bc.Parameters.Strategy.CustomStrategy.From.Name)
207
+		_, err := fmt.Fprintf(w, "%s\t%v\t%s\n", bc.Name, describeStrategy(bc.Parameters.Strategy.Type), bc.Parameters.Strategy.CustomStrategy.From.Name)
208 208
 		return err
209 209
 	}
210
-	_, err := fmt.Fprintf(w, "%s\t%v\t%s\n", bc.Name, bc.Parameters.Strategy.Type, bc.Parameters.Source.Git.URI)
210
+	_, err := fmt.Fprintf(w, "%s\t%v\t%s\n", bc.Name, describeStrategy(bc.Parameters.Strategy.Type), bc.Parameters.Source.Git.URI)
211 211
 	return err
212 212
 }
213 213
 
... ...
@@ -198,7 +198,7 @@ func describeBuildInPipeline(build *buildapi.BuildConfig, baseImage graph.ImageT
198 198
 			return "docker build; no source set"
199 199
 		}
200 200
 		return fmt.Sprintf("docker build of %s", source)
201
-	case buildapi.STIBuildStrategyType:
201
+	case buildapi.SourceBuildStrategyType:
202 202
 		source, ok := describeSourceInPipeline(&build.Parameters.Source)
203 203
 		if !ok {
204 204
 			return fmt.Sprintf("unconfigured source build %s", build.Name)
... ...
@@ -804,7 +804,7 @@ func (c *MasterConfig) RunBuildController() {
804 804
 			// TODO: this will be set to --storage-version (the internal schema we use)
805 805
 			Codec: v1beta1.Codec,
806 806
 		},
807
-		STIBuildStrategy: &buildstrategy.STIBuildStrategy{
807
+		SourceBuildStrategy: &buildstrategy.SourceBuildStrategy{
808 808
 			Image:                stiImage,
809 809
 			TempDirectoryCreator: buildstrategy.STITempDirectoryCreator,
810 810
 			// TODO: this will be set to --storage-version (the internal schema we use)
... ...
@@ -150,8 +150,8 @@ func (s *BuildStrategyRef) BuildStrategy() (*buildapi.BuildStrategy, []buildapi.
150 150
 	}
151 151
 
152 152
 	return &buildapi.BuildStrategy{
153
-		Type: buildapi.STIBuildStrategyType,
154
-		STIStrategy: &buildapi.STIBuildStrategy{
153
+		Type: buildapi.SourceBuildStrategyType,
154
+		SourceStrategy: &buildapi.SourceBuildStrategy{
155 155
 			From: s.Base.ObjectReference(),
156 156
 		},
157 157
 	}, s.Base.BuildTriggers()
... ...
@@ -309,7 +309,7 @@ func NewTestBuildOpenshift(t *testing.T) *testBuildOpenshift {
309 309
 			Image: "test-docker-builder",
310 310
 			Codec: latest.Codec,
311 311
 		},
312
-		STIBuildStrategy: &buildstrategy.STIBuildStrategy{
312
+		SourceBuildStrategy: &buildstrategy.SourceBuildStrategy{
313 313
 			Image:                "test-sti-builder",
314 314
 			TempDirectoryCreator: buildstrategy.STITempDirectoryCreator,
315 315
 			Codec:                latest.Codec,
... ...
@@ -342,8 +342,8 @@ func runImageChangeTriggerTest(t *testing.T, testname string, clusterAdminClient
342 342
 	}
343 343
 	newBuild := event.Object.(*buildapi.Build)
344 344
 	switch newBuild.Parameters.Strategy.Type {
345
-	case buildapi.STIBuildStrategyType:
346
-		if newBuild.Parameters.Strategy.STIStrategy.From.Name != "registry:8080/openshift/test-image-trigger:"+tag {
345
+	case buildapi.SourceBuildStrategyType:
346
+		if newBuild.Parameters.Strategy.SourceStrategy.From.Name != "registry:8080/openshift/test-image-trigger:"+tag {
347 347
 			i, _ := clusterAdminClient.ImageStreams(testutil.Namespace()).Get(imageStream.Name)
348 348
 			bc, _ := clusterAdminClient.BuildConfigs(testutil.Namespace()).Get(config.Name)
349 349
 			t.Fatalf("Expected build with base image %s, got %s\n, imagerepo is %v\ntrigger is %s\n", "registry:8080/openshift/test-image-trigger:"+tag, newBuild.Parameters.Strategy.DockerStrategy.From.Name, i, bc.Triggers[0].ImageChange)
... ...
@@ -434,8 +434,8 @@ WaitLoop2:
434 434
 	}
435 435
 	newBuild = event.Object.(*buildapi.Build)
436 436
 	switch newBuild.Parameters.Strategy.Type {
437
-	case buildapi.STIBuildStrategyType:
438
-		if newBuild.Parameters.Strategy.STIStrategy.From.Name != "registry:8080/openshift/test-image-trigger:ref-2-random" {
437
+	case buildapi.SourceBuildStrategyType:
438
+		if newBuild.Parameters.Strategy.SourceStrategy.From.Name != "registry:8080/openshift/test-image-trigger:ref-2-random" {
439 439
 			i, _ := clusterAdminClient.ImageStreams(testutil.Namespace()).Get(imageStream.Name)
440 440
 			bc, _ := clusterAdminClient.BuildConfigs(testutil.Namespace()).Get(config.Name)
441 441
 			t.Fatalf("Expected build with base image %s, got %s\n, imagerepo is %v\trigger is %s\n", "registry:8080/openshift/test-image-trigger:ref-2-random", newBuild.Parameters.Strategy.DockerStrategy.From.Name, i, bc.Triggers[3].ImageChange)
... ...
@@ -65,8 +65,8 @@ func dockerStrategy(kind, name string) buildapi.BuildStrategy {
65 65
 }
66 66
 func stiStrategy(kind, name string) buildapi.BuildStrategy {
67 67
 	return buildapi.BuildStrategy{
68
-		Type: buildapi.STIBuildStrategyType,
69
-		STIStrategy: &buildapi.STIBuildStrategy{
68
+		Type: buildapi.SourceBuildStrategyType,
69
+		SourceStrategy: &buildapi.SourceBuildStrategy{
70 70
 			From: &kapi.ObjectReference{
71 71
 				Kind: kind,
72 72
 				Name: name,
... ...
@@ -203,8 +203,8 @@ func runTest(t *testing.T, testname string, clusterAdminClient *client.Client, i
203 203
 	}
204 204
 	newBuild := event.Object.(*buildapi.Build)
205 205
 	switch newBuild.Parameters.Strategy.Type {
206
-	case buildapi.STIBuildStrategyType:
207
-		if newBuild.Parameters.Strategy.STIStrategy.From.Name != "registry:8080/openshift/test-image-trigger:"+tag {
206
+	case buildapi.SourceBuildStrategyType:
207
+		if newBuild.Parameters.Strategy.SourceStrategy.From.Name != "registry:8080/openshift/test-image-trigger:"+tag {
208 208
 			i, _ := clusterAdminClient.ImageStreams(testutil.Namespace()).Get(imageStream.Name)
209 209
 			bc, _ := clusterAdminClient.BuildConfigs(testutil.Namespace()).Get(config.Name)
210 210
 			t.Fatalf("Expected build with base image %s, got %s\n, imagerepo is %v\ntrigger is %s\n", "registry:8080/openshift/test-image-trigger:"+tag, newBuild.Parameters.Strategy.DockerStrategy.From.Name, i, bc.Triggers[0].ImageChange)
... ...
@@ -268,8 +268,8 @@ func runTest(t *testing.T, testname string, clusterAdminClient *client.Client, i
268 268
 	}
269 269
 	newBuild = event.Object.(*buildapi.Build)
270 270
 	switch newBuild.Parameters.Strategy.Type {
271
-	case buildapi.STIBuildStrategyType:
272
-		if newBuild.Parameters.Strategy.STIStrategy.From.Name != "registry:8080/openshift/test-image-trigger:ref-2-random" {
271
+	case buildapi.SourceBuildStrategyType:
272
+		if newBuild.Parameters.Strategy.SourceStrategy.From.Name != "registry:8080/openshift/test-image-trigger:ref-2-random" {
273 273
 			i, _ := clusterAdminClient.ImageStreams(testutil.Namespace()).Get(imageStream.Name)
274 274
 			bc, _ := clusterAdminClient.BuildConfigs(testutil.Namespace()).Get(config.Name)
275 275
 			t.Fatalf("Expected build with base image %s, got %s\n, imagerepo is %v\trigger is %s\n", "registry:8080/openshift/test-image-trigger:ref-2-random", newBuild.Parameters.Strategy.DockerStrategy.From.Name, i, bc.Triggers[3].ImageChange)
... ...
@@ -189,8 +189,8 @@ func TestWebhookGithubPushWithImageStream(t *testing.T) {
189 189
 			t.Errorf("Expected %s, got %s", buildapi.BuildStatusNew, actual.Status)
190 190
 		}
191 191
 
192
-		if actual.Parameters.Strategy.STIStrategy.From.Name != "registry:3000/integration/imageStream:success" {
193
-			t.Errorf("Expected %s, got %s", "registry:3000/integration-test/imageStream:success", actual.Parameters.Strategy.STIStrategy.From.Name)
192
+		if actual.Parameters.Strategy.SourceStrategy.From.Name != "registry:3000/integration/imageStream:success" {
193
+			t.Errorf("Expected %s, got %s", "registry:3000/integration-test/imageStream:success", actual.Parameters.Strategy.SourceStrategy.From.Name)
194 194
 		}
195 195
 	}
196 196
 }
... ...
@@ -324,8 +324,8 @@ func mockBuildConfigImageStreamParms(imageName, imageStream, imageTag string) *b
324 324
 				ContextDir: "context",
325 325
 			},
326 326
 			Strategy: buildapi.BuildStrategy{
327
-				Type: buildapi.STIBuildStrategyType,
328
-				STIStrategy: &buildapi.STIBuildStrategy{
327
+				Type: buildapi.SourceBuildStrategyType,
328
+				SourceStrategy: &buildapi.SourceBuildStrategy{
329 329
 					From: &kapi.ObjectReference{
330 330
 						Kind: "ImageStreamTag",
331 331
 						Name: imageStream + ":" + imageTag,