Browse code

Fix asset config warning

Jordan Liggitt authored on 2015/10/16 04:14:37
Showing 1 changed files
... ...
@@ -79,8 +79,11 @@ func ValidateMasterConfig(config *api.MasterConfig) ValidationResults {
79 79
 			if publicURL.Path == "/" {
80 80
 				validationResults.AddErrors(fielderrors.NewFieldInvalid("assetConfig.publicURL", config.AssetConfig.PublicURL, "path can not be / when colocated with master API"))
81 81
 			}
82
-			if !reflect.DeepEqual(config.AssetConfig.ServingInfo, config.ServingInfo) {
83
-				validationResults.AddWarnings(fielderrors.NewFieldInvalid("assetConfig.servingInfo", "<not displayed>", "assetConfig.servingInfo is ignored when colocated with master API"))
82
+
83
+			// Warn if they have customized the asset certificates in ways that will be ignored
84
+			if !reflect.DeepEqual(config.AssetConfig.ServingInfo.ServerCert, config.ServingInfo.ServerCert) ||
85
+				!reflect.DeepEqual(config.AssetConfig.ServingInfo.NamedCertificates, config.ServingInfo.NamedCertificates) {
86
+				validationResults.AddWarnings(fielderrors.NewFieldInvalid("assetConfig.servingInfo", "<not displayed>", "changes to assetConfig certificate configuration are not used when colocated with master API"))
84 87
 			}
85 88
 		}
86 89