Browse code

diagnostics: systemd unit name changes

Luke Meyer authored on 2015/10/23 08:21:26
Showing 3 changed files
... ...
@@ -30,7 +30,7 @@ func GetSystemdUnits(logger *log.Logger) map[string]types.SystemdUnit {
30 30
 	}
31 31
 
32 32
 	logger.Notice("DS1001", "Performing systemd discovery")
33
-	for _, name := range []string{"openshift", "openshift-master", "openshift-node", "openshift-sdn-master", "openshift-sdn-node", "docker", "openvswitch", "iptables", "etcd", "kubernetes"} {
33
+	for _, name := range []string{"openshift", "atomic-openshift-master", "atomic-openshift-node", "docker", "openvswitch", "iptables", "etcd", "kubernetes"} {
34 34
 		systemdUnits[name] = discoverSystemdUnit(logger, name)
35 35
 
36 36
 		if systemdUnits[name].Exists {
... ...
@@ -60,7 +60,7 @@ var tlsClientErrorSeen map[string]bool
60 60
 // Specify what units we can check and what to look for and say about it
61 61
 var unitLogSpecs = []*unitSpec{
62 62
 	{
63
-		Name:       "openshift-master",
63
+		Name:       "atomic-openshift-master",
64 64
 		StartMatch: regexp.MustCompile("Starting \\w+ Master"),
65 65
 		LogMatchers: []logMatcher{
66 66
 			badImageTemplate,
... ...
@@ -76,7 +76,7 @@ var unitLogSpecs = []*unitSpec{
76 76
 				Level:  log.WarnLevel,
77 77
 				Interpret: func(entry *logEntry, matches []string, r types.DiagnosticResult) bool {
78 78
 					client := matches[1]
79
-					prelude := fmt.Sprintf("Found 'openshift-master' journald log message:\n  %s\n", entry.Message)
79
+					prelude := fmt.Sprintf("Found 'atomic-openshift-master' journald log message:\n  %s\n", entry.Message)
80 80
 					if tlsClientErrorSeen == nil { // first time this message was seen
81 81
 						tlsClientErrorSeen = map[string]bool{client: true}
82 82
 						// TODO: too generic, adjust message depending on subnet of the "from" address
... ...
@@ -108,7 +108,7 @@ log message:
108 108
   component. Check pod logs and recreate it with the correct CA cert.
109 109
   Routers and registries won't work properly with the wrong CA.
110 110
 * If it is from a node IP, the client is likely a node. Check the
111
-  openshift-node logs and reconfigure with the correct CA cert.
111
+  atomic-openshift-node logs and reconfigure with the correct CA cert.
112 112
   Nodes will be unable to create pods until this is corrected.
113 113
 * If it is from an external IP, it is likely from a user (CLI, browser,
114 114
   etc.). Command line clients should be configured with the correct
... ...
@@ -129,7 +129,7 @@ log message:
129 129
 		},
130 130
 	},
131 131
 	{
132
-		Name:       "openshift-node",
132
+		Name:       "atomic-openshift-node",
133 133
 		StartMatch: regexp.MustCompile("Starting \\w+ Node"), //systemd puts this out; could change
134 134
 		LogMatchers: []logMatcher{
135 135
 			badImageTemplate,
... ...
@@ -138,7 +138,7 @@ log message:
138 138
 				Level:  log.ErrorLevel,
139 139
 				Id:     "DS2004",
140 140
 				Interpretation: `
141
-openshift-node could not register with the master API because it lacks
141
+atomic-openshift-node could not register with the master API because it lacks
142 142
 the proper credentials. Nodes should specify a client certificate in
143 143
 order to identify themselves to the master. This message typically means
144 144
 that either no client key/cert was supplied, or it is not validated
... ...
@@ -154,12 +154,12 @@ scheduled for this node will remain in pending or unknown state forever.`,
154 154
 				Level:  log.WarnLevel,
155 155
 				Id:     "DS2005",
156 156
 				Interpretation: `
157
-This warning occurs when openshift-node is trying to request the
157
+This warning occurs when the node is trying to request the
158 158
 SDN subnet it should be configured with according to the master,
159 159
 but either can't connect to it or has not yet been assigned a subnet.
160 160
 
161 161
 This can occur before the master becomes fully available and defines a
162
-record for the node to use; openshift-node will wait until that occurs,
162
+record for the node to use; the node will wait until that occurs,
163 163
 so the presence of this message in the node log isn't necessarily a
164 164
 problem as long as the SDN is actually working, but this message may
165 165
 help indicate the problem if it is not working.
... ...
@@ -30,10 +30,10 @@ func (d UnitStatus) CanRun() (bool, error) {
30 30
 func (d UnitStatus) Check() types.DiagnosticResult {
31 31
 	r := types.NewDiagnosticResult(UnitStatusName)
32 32
 
33
-	unitRequiresUnit(r, d.SystemdUnits["openshift-node"], d.SystemdUnits["iptables"], nodeRequiresIPTables)
34
-	unitRequiresUnit(r, d.SystemdUnits["openshift-node"], d.SystemdUnits["docker"], `Nodes use Docker to run containers.`)
35
-	unitRequiresUnit(r, d.SystemdUnits["openshift-node"], d.SystemdUnits["openvswitch"], sdUnitSDNreqOVS)
36
-	unitRequiresUnit(r, d.SystemdUnits["openshift-master"], d.SystemdUnits["openvswitch"], `Masters use openvswitch for access to cluster SDN networking`)
33
+	unitRequiresUnit(r, d.SystemdUnits["atomic-openshift-node"], d.SystemdUnits["iptables"], nodeRequiresIPTables)
34
+	unitRequiresUnit(r, d.SystemdUnits["atomic-openshift-node"], d.SystemdUnits["docker"], `Nodes use Docker to run containers.`)
35
+	unitRequiresUnit(r, d.SystemdUnits["atomic-openshift-node"], d.SystemdUnits["openvswitch"], sdUnitSDNreqOVS)
36
+	unitRequiresUnit(r, d.SystemdUnits["atomic-openshift-master"], d.SystemdUnits["openvswitch"], `Masters use openvswitch for access to cluster SDN networking`)
37 37
 	// all-in-one networking *could* be simpler, so fewer checks
38 38
 	unitRequiresUnit(r, d.SystemdUnits["openshift"], d.SystemdUnits["docker"], `Nodes use Docker to run containers.`)
39 39
 
... ...
@@ -65,8 +65,8 @@ iptables is used by nodes for container networking.
65 65
 Connections to a container will fail without it.`
66 66
 
67 67
 	sdUnitSDNreqOVS = `
68
-systemd unit openshift-node is running but openvswitch is not.
69
-Normally openshift-node starts openvswitch once initialized.
68
+systemd unit atomic-openshift-node is running but openvswitch is not.
69
+Normally atomic-openshift-node starts openvswitch once initialized.
70 70
 It is likely that openvswitch has crashed or been stopped.
71 71
 
72 72
 The software-defined network (SDN) enables networking between