Browse code

Component refs are not docker image refs

This was breaking osc new-app -f https://...

Clayton Coleman authored on 2015/06/11 13:40:34
Showing 2 changed files
... ...
@@ -44,10 +44,6 @@ func componentWithSource(s string) (component, repo string, builder bool, err er
44 44
 	} else {
45 45
 		component = s
46 46
 	}
47
-	// component must be of the form compatible with a pull spec *or* <namespace>/<name>
48
-	if _, err := imageapi.ParseDockerImageReference(component); err != nil {
49
-		return "", "", false, fmt.Errorf("%q is not a valid Docker pull specification: %s", component, err)
50
-	}
51 47
 	return
52 48
 }
53 49
 
... ...
@@ -68,9 +68,6 @@ type TemplateFileResolver struct {
68 68
 
69 69
 // Resolve attemps to read the template file and transform it into a template object
70 70
 func (r *TemplateFileResolver) Resolve(value string) (*ComponentMatch, error) {
71
-	if !isFile(value) {
72
-		return nil, fmt.Errorf("%s is not a file", value)
73
-	}
74 71
 	var isSingular bool
75 72
 	obj, err := resource.NewBuilder(r.Mapper, r.Typer, r.ClientMapper).
76 73
 		NamespaceParam(r.Namespace).RequireNamespace().