new file mode 100644

@@ -0,0 +1,78 @@

+apiVersion: v1

+items:

+- apiVersion: v1

+  kind: Pod

+  metadata:

+    annotations:

+      kubernetes.io/created-by: '{"kind":"SerializedReference","apiVersion":"v1","reference":{"kind":"ReplicationController","namespace":"example","name":"frontend-app-1","uid":"666e12d7-2996-11e5-b9e2-28d2447dc82b","apiVersion":"v1","resourceVersion":"32416"}}'

+      openshift.io/scc: restricted

+    creationTimestamp: 2015-07-13T19:36:04Z

+    generateName: frontend-app-1-

+    labels:

+      deconflict: frontend.app

+      name: frontend

+      template: ruby-helloworld-sample

+    name: frontend-app-1-bjwh8

+    namespace: example

+    resourceVersion: "32467"

+    selfLink: /api/v1/namespaces/example/pods/frontend-app-1-bjwh8

+    uid: 669a3b5d-2996-11e5-b9e2-28d2447dc82b

+  spec:

+    containers:

+    - env:

+      - name: ADMIN_USERNAME

+        value: admin6TM

+      - name: ADMIN_PASSWORD

+        value: xImx1tHR

+      - name: MYSQL_ROOT_PASSWORD

+        value: rQHfVnTo

+      - name: MYSQL_DATABASE

+        value: root

+      image: openshift/ruby-hello-world

+      imagePullPolicy: IfNotPresent

+      name: ruby-helloworld

+      ports:

+      - containerPort: 8080

+        protocol: TCP

+      resources: {}

+      securityContext:

+        capabilities: {}

+        privileged: false

+        runAsUser: 1000060000

+        seLinuxOptions:

+          level: s0:c8,c2

+      terminationMessagePath: /dev/termination-log

+      volumeMounts:

+      - mountPath: /var/run/secrets/kubernetes.io/serviceaccount

+        name: default-token-mmv27

+        readOnly: true

+    dnsPolicy: ClusterFirst

+    host: deads-dev-01

+    imagePullSecrets:

+    - name: default-dockercfg-yr2e3

+    nodeName: deads-dev-01

+    restartPolicy: Always

+    serviceAccount: default

+    serviceAccountName: default

+    volumes:

+    - name: default-token-mmv27

+      secret:

+        secretName: default-token-mmv27

+  status:

+    conditions:

+    - status: "False"

+      type: Ready

+    containerStatuses:

+    - image: openshift/ruby-hello-world

+      imageID: ""

+      lastState: {}

+      name: ruby-helloworld

+      ready: false

+      restartCount: 8

+      state:

+        waiting:

+          reason: 'Image: openshift/ruby-hello-world is not ready on the node'

+    phase: Pending

+    startTime: 2015-07-13T19:36:05Z

+kind: List

+metadata: {}

new file mode 100644

@@ -0,0 +1,44 @@

+package analysis

+

+import (

+	"fmt"

+

+	kapi "k8s.io/kubernetes/pkg/api"

+

+	osgraph "github.com/openshift/origin/pkg/api/graph"

+	kubegraph "github.com/openshift/origin/pkg/api/kubegraph/nodes"

+)

+

+const (

+	RestartingPodWarning = "RestartingPod"

+

+	RestartThreshold = 3

+)

+

+// FindRestartingPods inspects all Pods to see if they've restarted more than the threshold

+func FindRestartingPods(g osgraph.Graph) []osgraph.Marker {

+	markers := []osgraph.Marker{}

+

+	for _, uncastPodNode := range g.NodesByKind(kubegraph.PodNodeKind) {

+		podNode := uncastPodNode.(*kubegraph.PodNode)

+		pod, ok := podNode.Object().(*kapi.Pod)

+		if !ok {

+			continue

+		}

+

+		for _, containerStatus := range pod.Status.ContainerStatuses {

+			if containerStatus.RestartCount >= RestartThreshold {

+				markers = append(markers, osgraph.Marker{

+					Node: podNode,

+

+					Severity: osgraph.WarningSeverity,

+					Key:      RestartingPodWarning,

+					Message: fmt.Sprintf("container %q in %s has restarted %d times", containerStatus.Name,

+						podNode.ResourceString(), containerStatus.RestartCount),

+				})

+			}

+		}

+	}

+

+	return markers

+}

new file mode 100644

@@ -0,0 +1,22 @@

+package analysis

+

+import (

+	"testing"

+

+	osgraphtest "github.com/openshift/origin/pkg/api/graph/test"

+)

+

+func TestRestartingPodWarning(t *testing.T) {

+	g, _, err := osgraphtest.BuildGraph("../../../api/graph/test/restarting-pod.yaml")

+	if err != nil {

+		t.Fatalf("unexpected error: %v", err)

+	}

+

+	markers := FindRestartingPods(g)

+	if e, a := 1, len(markers); e != a {

+		t.Fatalf("expected %v, got %v", e, a)

+	}

+	if e, a := RestartingPodWarning, markers[0].Key; e != a {

+		t.Fatalf("expected %v, got %v", e, a)

+	}

+}

@@ -251,6 +251,7 @@ func createForbiddenMarkers(forbiddenResources sets.String) []osgraph.Marker {

 func getMarkerScanners() []osgraph.MarkerScanner {

 	return []osgraph.MarkerScanner{

+		kubeanalysis.FindRestartingPods,

 		kubeanalysis.FindDuelingReplicationControllers,

 		kubeanalysis.FindUnmountableSecrets,

 		kubeanalysis.FindMissingSecrets,

@@ -246,6 +246,18 @@ func TestProjectStatus(t *testing.T) {

 			},

 			Time: mustParseTime("2015-04-07T04:12:25Z"),

 		},

+		"restarting pod": {

+			Path: "../../../api/graph/test/restarting-pod.yaml",

+			Extra: []runtime.Object{

+				&projectapi.Project{

+					ObjectMeta: kapi.ObjectMeta{Name: "example", Namespace: ""},

+				},

+			},

+			ErrFn: func(err error) bool { return err == nil },

+			Contains: []string{

+				`container "ruby-helloworld" in pod/frontend-app-1-bjwh8 has restarted 8 times`,

+			},

+		},

 	}

 	oldTimeFn := timeNowFn

 	defer func() { timeNowFn = oldTimeFn }()